)]}'
{"id":"openstack%2Fpython-ironicclient~985246","triplet_id":"openstack%2Fpython-ironicclient~master~Id0ad270c08c98dea69f9209cc7bd88b7f319f09a","project":"openstack/python-ironicclient","branch":"master","attention_set":{"38828":{"account":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"last_update":"2026-04-21 18:49:54.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Id0ad270c08c98dea69f9209cc7bd88b7f319f09a","subject":"Stop ignoring attr-defined in tests","status":"NEW","created":"2026-04-18 20:22:42.000000000","updated":"2026-04-21 18:49:54.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7054710e164dc7f018213ff236941133ed6966d8","_number":985246,"virtual_id_number":985246,"owner":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-04-18 21:35:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-18 21:35:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6d1eb50c83afe52c13abfebb82e3ec630b61fa8f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"date":"2026-04-18 20:22:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"01e0722beca6a374809a1b0e56373c99384cb2cf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-18 21:35:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/f3fc5628d06f4b5f81921e44aba682d5\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/9c5bb449c5fc43439fe9748398ddbaae : POST_FAILURE in 2m 30s\n- requirements-check https://zuul.opendev.org/t/openstack/build/9bd794bfde3d400f827d8f5b4b693000 : POST_FAILURE in 1m 43s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/479bf8c0868045a68bc7edc014510e93 : POST_FAILURE in 3m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8f79f0f3905e44d9b05baeeaa73fa80c : POST_FAILURE in 3m 31s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/fe129c2bbf32401a95d478200f70e10f : POST_FAILURE in 3m 40s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/3d2cddb658a6405f8d4d028a39b60b6f : POST_FAILURE in 2m 27s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/eb93a4f6afb942cead24671f137e6e72 : POST_FAILURE in 5m 59s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/9a1c537abe924f6780c35c44bba6793e : POST_FAILURE in 5m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7a70bbbb300a4d96840e9918d641a980 : POST_FAILURE in 6m 03s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/1c16aa1e7bf644ba8be2d689a40ea7d3 : POST_FAILURE in 1h 06m 24s\n- ironicclient-tox-codespell https://zuul.opendev.org/t/openstack/build/2d73e28e77e14e15b1131bc1597b178c : POST_FAILURE in 2m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ae84de6c69d14fda687f0cac02e5a0f52a83ac2b","author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"date":"2026-04-21 17:43:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7054710e164dc7f018213ff236941133ed6966d8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-21 18:49:54.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/efc15ad6615948218fbc77fa4a03f5f2\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/9b1c53662b0947d286791be2bb4c3cc0 : SUCCESS in 2m 40s\n- requirements-check https://zuul.opendev.org/t/openstack/build/6fc3cdff3d6a4b278bec455fe0c718bf : SUCCESS in 2m 40s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7108a9cb9a7143a990e1652bf5e5028d : SUCCESS in 4m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1a105c8e3e64462f888bee2c97469013 : SUCCESS in 3m 38s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/b43ca2c2c5b14bd3a0aa8ee080afd20b : SUCCESS in 3m 22s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/bfc5683c31164765b1cc6a6caadf2581 : SUCCESS in 3m 42s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/dcc789cd7b5e446b86fc35bb687c9f7d : SUCCESS in 6m 33s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/fc3c2656207a4a3bbab0d39121e4a571 : SUCCESS in 5m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5c16db4265a24e2bbeeda870a6bf48ff : FAILURE in 5m 25s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/5478a109b59640399e34b483ac92d925 : POST_FAILURE in 52m 25s\n- ironicclient-tox-codespell https://zuul.opendev.org/t/openstack/build/a473ae43533e491a9c5688b79b162fb4 : SUCCESS in 2m 59s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"80ef966209f801944bf55d14be44edfca5bb05dc","revisions":{"80ef966209f801944bf55d14be44edfca5bb05dc":{"kind":"REWORK","_number":1,"created":"2026-04-18 20:22:42.000000000","uploader":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"ref":"refs/changes/46/985246/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/46/985246/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/46/985246/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/46/985246/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/46/985246/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/46/985246/1"}}},"commit":{"parents":[{"commit":"873e72d9790d1dc4497b48b470b798eba2b1be2e","subject":"Stop ignoring list-item in tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/873e72d9790d1dc4497b48b470b798eba2b1be2e"}]}],"author":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-04-18 20:21:02.000000000","tz":-240},"committer":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-04-18 20:22:33.000000000","tz":-240},"subject":"Stop ignoring attr-defined in tests","message":"Stop ignoring attr-defined in tests\n\nDrop attr-defined from the tests.* override and fix the errors that\nsurfaced:\n\n- VersionNegotiationMixin reads endpoint_override (provided by the\n  concrete adapter subclass). Declare it on the mixin so it can be\n  type-checked in isolation. While there, remove dead _make_connection_url\n  and get_server mocks in test_http.py that nothing actually invokes.\n\n- _validate_obj / _validate_list helpers in test_volume_target,\n  test_volume_connector, and test_node typed resources as object or\n  list[object]. Retype to the real Resource subclasses; their\n  __getattr__ -\u003e Any covers the dynamic field access.\n\n- Tests reached attributes through implicit re-exports\n  (client.DEFAULT_VER, client.node.NodeManager, plugin.utils.env).\n  Mypy strict mode rejects this; import the names from where they\u0027re\n  defined instead.\n\n- ironicclient.tests.unit.osc.fakes.FakeClientManager was missing the\n  get_endpoint_for_service_type attribute test_plugin assigns to. Add a\n  declaration-only annotation.\n\n- osc_lib\u0027s FakeClientManager has no baremetal attribute. Move the\n  baremetal_mock setup into TestBaremetal.setUp using setattr (same\n  pattern as auth_ref) and drop the duplicated two-line shortcut from\n  the 13 subclass setUp methods that re-fetched it.\n\nChange-Id: Id0ad270c08c98dea69f9209cc7bd88b7f319f09a\nSigned-off-by: Karan Anand \u003canandkarancompsci@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/80ef966209f801944bf55d14be44edfca5bb05dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/80ef966209f801944bf55d14be44edfca5bb05dc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}