)]}'
{"id":"openstack%2Fpython-ironicclient~985247","triplet_id":"openstack%2Fpython-ironicclient~master~I61364d5f59bd8baecf81793c0c07803dfafbded1","project":"openstack/python-ironicclient","branch":"master","attention_set":{"38828":{"account":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"last_update":"2026-04-21 19:01:55.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I61364d5f59bd8baecf81793c0c07803dfafbded1","subject":"Stop ignoring union-attr in tests","status":"NEW","created":"2026-04-18 20:51:29.000000000","updated":"2026-04-21 19:01:55.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c868fc880b5ba83b03bdbd6adb84bacb2f094edb","_number":985247,"virtual_id_number":985247,"owner":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-04-18 22:02:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-18 22:02:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"74b7150b012092cb33b75dde7591afa336219090","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"date":"2026-04-18 20:51:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1f945b2674c380c4a9bacc69e8e83406821c32e6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-18 22:02:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/141668da13174627a620e51a95c427d8\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/b072ddc4eb5b48b7aefb2c2e8f3ec437 : POST_FAILURE in 2m 57s\n- requirements-check https://zuul.opendev.org/t/openstack/build/59dd1bbe49cc4ccaa560172c854bc7e2 : POST_FAILURE in 2m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5051ea101d9840889f67c84663a4f641 : POST_FAILURE in 4m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ed6c15545bd44e77805a65cc578f4d54 : POST_FAILURE in 3m 53s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/c9586e0d83044b178a8404eed7f52878 : POST_FAILURE in 3m 17s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/343b310999c644bca16ff82db7c925ad : POST_FAILURE in 2m 07s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/4d8ab37dc0e84d39aeeb282e78cca581 : POST_FAILURE in 6m 13s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/8736a5d668e943719af729cafb76f971 : POST_FAILURE in 5m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f5607a9043db44278b696c5e4360e84a : POST_FAILURE in 5m 12s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/f8b73b5f615645f7a6c5964ab80d7b49 : POST_FAILURE in 1h 04m 28s\n- ironicclient-tox-codespell https://zuul.opendev.org/t/openstack/build/2dcab5e5516245b0a4e1afa0436d7e2e : POST_FAILURE in 2m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"714ac012b57f880538b5ece1154a42438cc3314f","author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"date":"2026-04-21 17:43:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c868fc880b5ba83b03bdbd6adb84bacb2f094edb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-21 19:01:55.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/7420da5d261a4785955983f239d314c2\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/537187edc8cb4a55b410004cd8ee7951 : SUCCESS in 2m 45s\n- requirements-check https://zuul.opendev.org/t/openstack/build/40984dc9a0954655819d753584fbefc1 : SUCCESS in 3m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a582ef3f380b457c8555b21d2c1424fa : SUCCESS in 4m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5c33ea91ed46435fb3ef8e9191064c44 : SUCCESS in 3m 49s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/c3192073e4544ec1aa901e86ad6eb2f6 : SUCCESS in 3m 31s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/91e6f3c4e97a4b938ab57e36db63ce4e : SUCCESS in 3m 20s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/1cee9a005db24e288f472f71d7b6654a : SUCCESS in 6m 02s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/fbcbd0b5e12148f1894ae2c75d52bb77 : SUCCESS in 7m 54s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e39ebc03f05441909fc1c9b2fab44cd1 : FAILURE in 6m 32s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/eefa7c0b2000402bb2002a90429db674 : SUCCESS in 1h 11m 43s\n- ironicclient-tox-codespell https://zuul.opendev.org/t/openstack/build/150ac33047714e0ba5b66121176f64b1 : SUCCESS in 3m 03s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"585c6ae2eaf8b1505dc82f90b4bc18f582d6323b","revisions":{"585c6ae2eaf8b1505dc82f90b4bc18f582d6323b":{"kind":"REWORK","_number":1,"created":"2026-04-18 20:51:29.000000000","uploader":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"ref":"refs/changes/47/985247/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/47/985247/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/47/985247/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/47/985247/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/47/985247/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/47/985247/1"}}},"commit":{"parents":[{"commit":"80ef966209f801944bf55d14be44edfca5bb05dc","subject":"Stop ignoring attr-defined in tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/80ef966209f801944bf55d14be44edfca5bb05dc"}]}],"author":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-04-18 20:50:21.000000000","tz":-240},"committer":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-04-18 20:51:21.000000000","tz":-240},"subject":"Stop ignoring union-attr in tests","message":"Stop ignoring union-attr in tests\n\nManager methods like `get`, `update`, and `_get` return `Resource | None`,\nso test code that immediately reads `.uuid`, `.name`, etc. on the result\ntrips mypy\u0027s `union-attr`. The FakeAPI fixtures always return a populated\nbody, so the `None` branch is unreachable in practice.\n\nWrap those call sites with `cast(\u003cResourceClass\u003e, ...)` at the fake-real\nboundary, matching the existing `cast(http.SessionClient, self.api)`\npattern in these files. Also cast `self.body` in `FakeResponse.read`,\nwhich is similarly never `None` in the tests that exercise it.\n\nDrop `union-attr` from the `ironicclient.tests.*` mypy override.\n\nChange-Id: I61364d5f59bd8baecf81793c0c07803dfafbded1\nSigned-off-by: Karan Anand \u003canandkarancompsci@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/585c6ae2eaf8b1505dc82f90b4bc18f582d6323b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/585c6ae2eaf8b1505dc82f90b4bc18f582d6323b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}