)]}'
{"id":"openstack%2Fpython-ironicclient~985248","triplet_id":"openstack%2Fpython-ironicclient~master~I45713546ce3b99d4818197a1250f9dbe83ffaad0","project":"openstack/python-ironicclient","branch":"master","attention_set":{"38828":{"account":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"last_update":"2026-04-21 18:53:03.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I45713546ce3b99d4818197a1250f9dbe83ffaad0","subject":"Stop ignoring var-annotated in tests","status":"NEW","created":"2026-04-19 03:30:48.000000000","updated":"2026-04-21 18:53:03.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8f8eb3aebec4ea2fcfa16b7f94ff2954d240f591","_number":985248,"virtual_id_number":985248,"owner":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-04-19 04:16:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-19 04:16:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"136b9225e22496c3a09127a3a77c6b476ba33a03","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"date":"2026-04-19 03:30:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2d0137ede08b2305dd51bbe9f9d9a78af42bf28d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-19 04:16:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/3e0c972d021a4ddc919fa7f02a7dc26e\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/5d5b29d843be4515a28fdd10f4f5a165 : POST_FAILURE in 2m 40s\n- requirements-check https://zuul.opendev.org/t/openstack/build/3907adb67b194527b11bd2ee0f217347 : POST_FAILURE in 2m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3d796fbe7ba14e2fa0c60faba7bd6329 : POST_FAILURE in 3m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fc292219f51c41f4816c50346e804f3e : POST_FAILURE in 2m 45s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ee1db902ae7c49a29f5a28d3c770c79e : POST_FAILURE in 3m 17s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/50fcd628c4d34dcba4f35c93934f7cb0 : POST_FAILURE in 3m 29s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/f7f8dbfd4a5e423186bf19ed477b0215 : POST_FAILURE in 4m 06s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/e7561c8f7b584cde8c7259185ac510ec : POST_FAILURE in 4m 03s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8402c56509ac446abc96bccdb48475c4 : POST_FAILURE in 5m 32s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/e6725626e76a445a958c78cb2ced3c8d : POST_FAILURE in 43m 30s\n- ironicclient-tox-codespell https://zuul.opendev.org/t/openstack/build/9bdd85aff1004638bbc712c72f3492bf : POST_FAILURE in 3m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2e15f1052b7e7cdf37ef247bbedd3230b99fae4d","author":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"date":"2026-04-21 17:43:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8f8eb3aebec4ea2fcfa16b7f94ff2954d240f591","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-21 18:53:03.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/b3dec63384494cffb5bc3e91fe5cb99a\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/ec885a5f78664ed5bc2b6fd6c943da82 : SUCCESS in 2m 45s\n- requirements-check https://zuul.opendev.org/t/openstack/build/dfcc0c076e8d47a19cd8aa58b8dc7c35 : SUCCESS in 2m 19s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2e89042a11ad49caaa89051e3f7133b8 : SUCCESS in 4m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/79132f6152704d5dbc498932cb25a83e : SUCCESS in 3m 40s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/61924c0691db448ba3fe1674cd07d55b : SUCCESS in 3m 46s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/97c25e694e4548bfb1e4bf97a4cb5c4f : SUCCESS in 4m 05s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/6c0f313543614b4ebea5a402637e7814 : SUCCESS in 6m 47s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/33c85bc712464281bbcd98162f728167 : SUCCESS in 3m 55s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/36dd418aa87b4ecaac6096a337324a7c : FAILURE in 6m 14s\n- ironicclient-tempest https://zuul.opendev.org/t/openstack/build/2339cf3fae3b441ea8c010e0bcdcd471 : SUCCESS in 1h 03m 17s\n- ironicclient-tox-codespell https://zuul.opendev.org/t/openstack/build/f748389ae6f64cee878a3049f8a7595c : SUCCESS in 4m 29s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cdd1e37b8a4da3125252d9414ca53f72ea95d769","revisions":{"cdd1e37b8a4da3125252d9414ca53f72ea95d769":{"kind":"REWORK","_number":1,"created":"2026-04-19 03:30:48.000000000","uploader":{"_account_id":38828,"name":"Karan Anand","display_name":"Karan","email":"anandkarancompsci@gmail.com","username":"anandkaranubc"},"ref":"refs/changes/48/985248/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/48/985248/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/48/985248/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/48/985248/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/48/985248/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/48/985248/1"}}},"commit":{"parents":[{"commit":"585c6ae2eaf8b1505dc82f90b4bc18f582d6323b","subject":"Stop ignoring union-attr in tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/585c6ae2eaf8b1505dc82f90b4bc18f582d6323b"}]}],"author":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-04-19 03:29:22.000000000","tz":-240},"committer":{"name":"Karan Anand","email":"anandkarancompsci@gmail.com","date":"2026-04-19 03:30:40.000000000","tz":-240},"subject":"Stop ignoring var-annotated in tests","message":"Stop ignoring var-annotated in tests\n\nEmpty literals like `arglist \u003d []`, `verifylist \u003d []`, and tuples\ncontaining empty `{}` headers leave mypy with no element type to\ninfer under strict mode, which `var-annotated` was suppressing.\n\nAnnotate these sites with the types declared upstream so the test\nfixtures match what the code under test actually consumes:\n\n- `arglist: list[str]` and `verifylist: list[tuple[str, Any]]` —\n  matches `osc_lib.tests.utils.TestCommand.check_parser`.\n- `expect: list[tuple[Any, ...]]` — matches `FakeAPI.calls`.\n- `expected_resp: tuple[dict[str, str], Any]` — matches the\n  `FakeAPI.responses[url][method]` value type.\n- `fake_responses*: dict[str, dict[str, tuple[dict[str, str], Any]]]`\n  — matches the `FakeAPI.__init__` parameter signature.\n\nA handful of heterogeneous module-level fixtures (`ALLOCATION`,\n`BAREMETAL`, `baremetal_chassis_extra`) get `dict[str, Any]` since\ntheir values are genuinely a `str | None | bool | list | dict` union.\n\nDrop `var-annotated` from theclient.tests.*` mypy override.\n\nChange-Id: I45713546ce3b99d4818197a1250f9dbe83ffaad0\nSigned-off-by: Karan Anand \u003canandkarancompsci@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/cdd1e37b8a4da3125252d9414ca53f72ea95d769"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/cdd1e37b8a4da3125252d9414ca53f72ea95d769"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}