)]}'
{"id":"openstack%2Fpython-karborclient~331609","triplet_id":"openstack%2Fpython-karborclient~master~I30c8eb4468d8fba830a64f336dd6cfa7793f0b48","project":"openstack/python-karborclient","branch":"master","topic":"create-dont-return-raw","hashtags":[],"change_id":"I30c8eb4468d8fba830a64f336dd6cfa7793f0b48","subject":"Return actual object, not raw, when creating","status":"MERGED","created":"2016-06-20 10:33:52.000000000","updated":"2016-06-28 09:27:19.000000000","submitted":"2016-06-28 09:27:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"95f33315fa7437a401b01f927b16b0eb9c25d8ed","_number":331609,"virtual_id_number":331609,"owner":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},{"value":2,"date":"2016-06-28 09:27:19.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"value":0,"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"recommended":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"all":[{"value":1,"date":"2016-06-22 08:19:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-28 09:18:27.000000000","_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"value":2,"date":"2016-06-22 08:44:59.000000000","_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"all":[{"value":0,"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-06-28 09:18:27.000000000","_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"value":0,"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-22 08:19:37.000000000","updated_by":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"reviewer":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"state":"REVIEWER"},{"updated":"2016-06-22 08:44:59.000000000","updated_by":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"reviewer":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"state":"REVIEWER"},{"updated":"2016-06-28 09:27:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"30638eb10c36c03f07d9e606f78491d97a936027","author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"date":"2016-06-20 10:33:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"789b687a3ddf29ce37a68a9c9112af41e9c93698","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 10:42:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-smaugclient-docs http://docs-draft.openstack.org/09/331609/1/check/gate-python-smaugclient-docs/f8bd1d7//doc/build/html/ : SUCCESS in 3m 40s\n- gate-python-smaugclient-pep8 http://logs.openstack.org/09/331609/1/check/gate-python-smaugclient-pep8/e551b85/ : SUCCESS in 5m 19s\n- gate-python-smaugclient-python27 http://logs.openstack.org/09/331609/1/check/gate-python-smaugclient-python27/486b5e3/ : SUCCESS in 2m 56s\n- gate-python-smaugclient-python34 http://logs.openstack.org/09/331609/1/check/gate-python-smaugclient-python34/4bacfe8/ : SUCCESS in 5m 40s","accounts_in_message":[],"_revision_number":1},{"id":"9f522540f638446be6d343129b06522fe9af48c5","author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"date":"2016-06-20 11:37:04.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"f60c06a5e47e3f2fa0e267458018d1a428d07fdc","author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"date":"2016-06-20 14:15:30.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"e55d762806f74e9abc3320dacc46619ff63cff6e","author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"date":"2016-06-20 14:16:04.000000000","message":"Patch Set 1:\n\nPlease review, but do not do a workflow.\nThis patch requires changes in Smaug, to match these changes","accounts_in_message":[],"_revision_number":1},{"id":"37392ac6fdb3f053de7106663e4bfc183eb1b823","author":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"date":"2016-06-21 08:55:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"46c60e30a912dbdb28b4fc841b61d43ef471da95","author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"date":"2016-06-21 09:00:24.000000000","message":"Patch Set 1:\n\nalso need update the print statement of objects in \u0027create\u0027 cmd.\nhttps://github.com/openstack/python-smaugclient/blob/master/smaugclient/v1/shell.py#l131","accounts_in_message":[],"_revision_number":1},{"id":"d6562fb55dec3aca4f7cfb18a08e18cbc120bbb1","author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"date":"2016-06-22 07:50:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c0d43951f5d8850c7f13f90ddb7e8232b9576522","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-22 07:54:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-smaugclient-docs http://docs-draft.openstack.org/09/331609/2/check/gate-python-smaugclient-docs/cf66cba//doc/build/html/ : SUCCESS in 3m 31s\n- gate-python-smaugclient-pep8 http://logs.openstack.org/09/331609/2/check/gate-python-smaugclient-pep8/64e17e7/ : SUCCESS in 2m 27s\n- gate-python-smaugclient-python27 http://logs.openstack.org/09/331609/2/check/gate-python-smaugclient-python27/e3ef07e/ : SUCCESS in 3m 15s\n- gate-python-smaugclient-python34 http://logs.openstack.org/09/331609/2/check/gate-python-smaugclient-python34/1f3f5ce/ : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":2},{"id":"7a6e1966c628d174e59ac4fc93053d93986dd294","author":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"date":"2016-06-22 08:19:37.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"3c8908d81c2459352302ac598d6ce160a67ca993","author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"date":"2016-06-22 08:44:59.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e20a60bc28dc78232d66e94e083f34f9a0192d79","author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"date":"2016-06-28 09:18:27.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f09c32adda7c927bca18a53e764fe53bd922a5b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-28 09:18:37.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"daa341d30dc6c8a36f352d3a61c9c1b3d04bc4cf","date":"2016-06-28 09:27:19.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"ccff4a3478baeb0eee1cbcf12535abe66006b1e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-28 09:27:19.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-smaugclient-docs http://docs-draft.openstack.org/09/331609/2/gate/gate-python-smaugclient-docs/fbb93c7//doc/build/html/ : SUCCESS in 2m 41s\n- gate-python-smaugclient-pep8 http://logs.openstack.org/09/331609/2/gate/gate-python-smaugclient-pep8/e6425fa/ : SUCCESS in 4m 08s\n- gate-python-smaugclient-python27 http://logs.openstack.org/09/331609/2/gate/gate-python-smaugclient-python27/2e1538a/ : SUCCESS in 5m 03s\n- gate-python-smaugclient-python34 http://logs.openstack.org/09/331609/2/gate/gate-python-smaugclient-python34/961d188/ : SUCCESS in 5m 41s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0644b6e175c43eaadfda967073d8b12283af352e","revisions":{"9d708578b109298c45b2a2fa1289fca997d69043":{"kind":"REWORK","_number":1,"created":"2016-06-20 10:33:52.000000000","uploader":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"ref":"refs/changes/09/331609/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-karborclient","ref":"refs/changes/09/331609/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/09/331609/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/09/331609/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/09/331609/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-karborclient refs/changes/09/331609/1"}}},"commit":{"parents":[{"commit":"18ae2eb061e7635af466cccfe6268e390ab77611","subject":"Fix creating scheduled_operations error","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/18ae2eb061e7635af466cccfe6268e390ab77611"}]}],"author":{"name":"Yuval Brik","email":"yuval@brik.org.il","date":"2016-06-20 10:33:25.000000000","tz":180},"committer":{"name":"Yuval Brik","email":"yuval@brik.org.il","date":"2016-06-20 10:33:25.000000000","tz":180},"subject":"Return actual object, not raw, when creating","message":"Return actual object, not raw, when creating\n\nWhen creating objects (checkpoint, plan, restore, scheduled operation,\ntrigger, etc) return the actual object, and not a raw dictionary.\nBecause a raw dictionary was returned on create and an actual object was\nreturned on get, this lead to the following confusion:\n\n  checkpoint \u003d smaug_client.checkpoint.create(...)\n  checkpoint_id \u003d checkpoint[\u0027id\u0027]\n  checkpoint \u003d smaug_client.checkpoint.get(...)\n  checkpoint_id \u003d checkpoint.id\n\nChange-Id: I30c8eb4468d8fba830a64f336dd6cfa7793f0b48\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/9d708578b109298c45b2a2fa1289fca997d69043"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/9d708578b109298c45b2a2fa1289fca997d69043"}]},"branch":"refs/heads/master"},"0644b6e175c43eaadfda967073d8b12283af352e":{"kind":"REWORK","_number":2,"created":"2016-06-22 07:50:00.000000000","uploader":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"ref":"refs/changes/09/331609/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-karborclient","ref":"refs/changes/09/331609/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/09/331609/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/09/331609/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/09/331609/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-karborclient refs/changes/09/331609/2"}}},"commit":{"parents":[{"commit":"4225036154f8b218d3a84adafbd7103340eb8243","subject":"Merge \"The parameters of plan could be an empty dict without being configured\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/4225036154f8b218d3a84adafbd7103340eb8243"}]}],"author":{"name":"Yuval Brik","email":"yuval@brik.org.il","date":"2016-06-22 07:49:06.000000000","tz":180},"committer":{"name":"Yuval Brik","email":"yuval@brik.org.il","date":"2016-06-22 07:49:06.000000000","tz":180},"subject":"Return actual object, not raw, when creating","message":"Return actual object, not raw, when creating\n\nWhen creating objects (checkpoint, plan, restore, scheduled operation,\ntrigger, etc) return the actual object, and not a raw dictionary.\nBecause a raw dictionary was returned on create and an actual object was\nreturned on get, this lead to the following confusion:\n\n  checkpoint \u003d smaug_client.checkpoint.create(...)\n  checkpoint_id \u003d checkpoint[\u0027id\u0027]\n  checkpoint \u003d smaug_client.checkpoint.get(...)\n  checkpoint_id \u003d checkpoint.id\n\nChange-Id: I30c8eb4468d8fba830a64f336dd6cfa7793f0b48\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/0644b6e175c43eaadfda967073d8b12283af352e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/0644b6e175c43eaadfda967073d8b12283af352e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}