)]}'
{"karborclient/v1/shell.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"20b585a2b64025f4a58c3fcf6bf9d3b28c2f1d5e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                resource[\"type\"], resource[\"id\"])"},{"line_number":231,"context_line":"        except exceptions.NotFound:"},{"line_number":232,"context_line":"            raise exceptions.CommandError("},{"line_number":233,"context_line":"                \"The resource:%s can not be found.\" % resource[\"id\"])"},{"line_number":234,"context_line":"        else:"},{"line_number":235,"context_line":"            if return_val is None:"},{"line_number":236,"context_line":"                raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_d794aee9","line":233,"range":{"start_line":233,"start_character":29,"end_line":233,"end_character":31},"updated":"2017-01-10 14:35:16.000000000","message":"missing space","commit_id":"02700d5d0e41055d159cc7d9c3763f4cdcea3da6"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"92f113b40d770ce6b5e769e52db764c89ad2907d","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                resource[\"type\"], resource[\"id\"])"},{"line_number":231,"context_line":"        except exceptions.NotFound:"},{"line_number":232,"context_line":"            raise exceptions.CommandError("},{"line_number":233,"context_line":"                \"The resource:%s can not be found.\" % resource[\"id\"])"},{"line_number":234,"context_line":"        else:"},{"line_number":235,"context_line":"            if return_val is None:"},{"line_number":236,"context_line":"                raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_6a9bffc9","line":233,"range":{"start_line":233,"start_character":29,"end_line":233,"end_character":31},"in_reply_to":"ba5201f7_d794aee9","updated":"2017-01-11 02:23:49.000000000","message":"Done","commit_id":"02700d5d0e41055d159cc7d9c3763f4cdcea3da6"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"20b585a2b64025f4a58c3fcf6bf9d3b28c2f1d5e","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        else:"},{"line_number":235,"context_line":"            if return_val is None:"},{"line_number":236,"context_line":"                raise exceptions.CommandError("},{"line_number":237,"context_line":"                    \"The resource:%s is invalid.\" % resource[\"id\"])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"@utils.arg(\u0027provider_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_979306fa","line":237,"range":{"start_line":237,"start_character":33,"end_line":237,"end_character":35},"updated":"2017-01-10 14:35:16.000000000","message":"ditto","commit_id":"02700d5d0e41055d159cc7d9c3763f4cdcea3da6"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"92f113b40d770ce6b5e769e52db764c89ad2907d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        else:"},{"line_number":235,"context_line":"            if return_val is None:"},{"line_number":236,"context_line":"                raise exceptions.CommandError("},{"line_number":237,"context_line":"                    \"The resource:%s is invalid.\" % resource[\"id\"])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"@utils.arg(\u0027provider_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_8a9e63b6","line":237,"range":{"start_line":237,"start_character":33,"end_line":237,"end_character":35},"in_reply_to":"ba5201f7_979306fa","updated":"2017-01-11 02:23:49.000000000","message":"Done","commit_id":"02700d5d0e41055d159cc7d9c3763f4cdcea3da6"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"981d6b92297336e4eb44deea1f44873f8be873f2","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    # check the resource whether it is available"},{"line_number":227,"context_line":"    for resource in resources:"},{"line_number":228,"context_line":"        try:"},{"line_number":229,"context_line":"            return_val \u003d cs.protectables.get_instance("},{"line_number":230,"context_line":"                resource[\"type\"], resource[\"id\"])"},{"line_number":231,"context_line":"        except exceptions.NotFound:"},{"line_number":232,"context_line":"            raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_a4b7d3f3","line":229,"range":{"start_line":229,"start_character":12,"end_line":229,"end_character":22},"updated":"2017-01-11 08:21:11.000000000","message":"1. Can it actually be None?\n2. If yes, can we change that to a more meaningful variable name?","commit_id":"59ba5e1dfdca3d60f5becd0cb4d80b46b0e3586c"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"e0255a9f4d1f41af9a5fd76876e1e8588062c83b","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    # check the resource whether it is available"},{"line_number":227,"context_line":"    for resource in resources:"},{"line_number":228,"context_line":"        try:"},{"line_number":229,"context_line":"            return_val \u003d cs.protectables.get_instance("},{"line_number":230,"context_line":"                resource[\"type\"], resource[\"id\"])"},{"line_number":231,"context_line":"        except exceptions.NotFound:"},{"line_number":232,"context_line":"            raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_fc634e18","line":229,"range":{"start_line":229,"start_character":12,"end_line":229,"end_character":22},"in_reply_to":"ba5201f7_a4b7d3f3","updated":"2017-01-15 12:57:41.000000000","message":"Yes, the value is returned by vendor\u0027s plugins. It could be None.","commit_id":"59ba5e1dfdca3d60f5becd0cb4d80b46b0e3586c"}]}