)]}'
{"id":"openstack%2Fpython-karborclient~452612","triplet_id":"openstack%2Fpython-karborclient~master~I3bdceff37eb43058b9a4c7a1f55c2875eb61c9a4","project":"openstack/python-karborclient","branch":"master","hashtags":[],"change_id":"I3bdceff37eb43058b9a4c7a1f55c2875eb61c9a4","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2017-04-03 06:38:08.000000000","updated":"2017-05-17 07:42:35.000000000","submitted":"2017-05-17 07:42:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"39f9c36a8d69610361645157208aff2ccc633026","_number":452612,"virtual_id_number":452612,"owner":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"value":2,"date":"2017-05-17 07:42:35.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"all":[{"value":2,"date":"2017-04-06 14:44:49.000000000","_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"all":[{"value":1,"date":"2017-05-17 07:38:56.000000000","_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-17 07:38:56.000000000","updated_by":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"reviewer":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"state":"REVIEWER"},{"updated":"2017-05-17 07:42:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8d925258383574bd158cd2618ed8a87f097877f1","author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"date":"2017-04-03 06:38:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"59455a4c916117ae6aac17df9ee915b110764a5f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 06:42:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-karborclient-docs-ubuntu-xenial http://docs-draft.openstack.org/12/452612/1/check/gate-python-karborclient-docs-ubuntu-xenial/e482729//doc/build/html/ : SUCCESS in 1m 49s\n- gate-python-karborclient-pep8-ubuntu-xenial http://logs.openstack.org/12/452612/1/check/gate-python-karborclient-pep8-ubuntu-xenial/9053242/ : SUCCESS in 3m 24s\n- gate-python-karborclient-python27-ubuntu-xenial http://logs.openstack.org/12/452612/1/check/gate-python-karborclient-python27-ubuntu-xenial/8456c93/ : SUCCESS in 2m 43s\n- gate-python-karborclient-python35 http://logs.openstack.org/12/452612/1/check/gate-python-karborclient-python35/eabb11c/ : SUCCESS in 1m 52s\n- python-karborclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/12/452612/1/check/python-karborclient-coverage-ubuntu-xenial-nv/9625ce0/ : SUCCESS in 2m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5b493f136e73fd9198cb246d5509151e27beda5e","author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"date":"2017-04-06 14:44:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c205737ff04357c8b49bb7a029b935c82b27ad35","author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"date":"2017-05-17 07:38:56.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8d1538d8e92b43c2581167397cf6de8cff3ba658","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-17 07:39:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"363609ccdfe6a7308280e758f0e98affacc5a0f2","date":"2017-05-17 07:42:35.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"39f9c36a8d69610361645157208aff2ccc633026","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-17 07:42:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-karborclient-docs-ubuntu-xenial http://docs-draft.openstack.org/12/452612/1/gate/gate-python-karborclient-docs-ubuntu-xenial/5e02f9c//doc/build/html/ : SUCCESS in 3m 04s\n- gate-python-karborclient-pep8-ubuntu-xenial http://logs.openstack.org/12/452612/1/gate/gate-python-karborclient-pep8-ubuntu-xenial/a339f8b/ : SUCCESS in 2m 54s\n- gate-python-karborclient-python27-ubuntu-xenial http://logs.openstack.org/12/452612/1/gate/gate-python-karborclient-python27-ubuntu-xenial/5027bf0/ : SUCCESS in 2m 46s\n- gate-python-karborclient-python35 http://logs.openstack.org/12/452612/1/gate/gate-python-karborclient-python35/5ab63c0/ : SUCCESS in 3m 06s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"68d0a7ece4e8e77bbe0bec740a6642b78a59cef5","revisions":{"68d0a7ece4e8e77bbe0bec740a6642b78a59cef5":{"kind":"REWORK","_number":1,"created":"2017-04-03 06:38:08.000000000","uploader":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"ref":"refs/changes/12/452612/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-karborclient","ref":"refs/changes/12/452612/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/12/452612/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/12/452612/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/12/452612/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-karborclient refs/changes/12/452612/1"}}},"commit":{"parents":[{"commit":"3c9286973550f5e20fd6bfdfafbe11bfe8df4d49","subject":"Remove log translations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/3c9286973550f5e20fd6bfdfafbe11bfe8df4d49"}]}],"author":{"name":"M V P Nitesh","email":"m.nitesh@nectechnologies.in","date":"2017-04-03 06:35:19.000000000","tz":330},"committer":{"name":"M V P Nitesh","email":"m.nitesh@nectechnologies.in","date":"2017-04-03 06:37:03.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I3bdceff37eb43058b9a4c7a1f55c2875eb61c9a4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/68d0a7ece4e8e77bbe0bec740a6642b78a59cef5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/68d0a7ece4e8e77bbe0bec740a6642b78a59cef5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
