)]}'
{"karborclient/osc/v1/checkpoints.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"d71f9fa393f09dfdc6c07bb719fdb4f5b435164e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                client.checkpoints.delete(parsed_args.provider_id,\r"},{"line_number":196,"context_line":"                                          checkpoint_id)\r"},{"line_number":197,"context_line":"            except exceptions.NotFound:\r"},{"line_number":198,"context_line":"                failure_count +\u003d 1\r"},{"line_number":199,"context_line":"                raise exceptions.CommandError(\r"},{"line_number":200,"context_line":"                    \"Failed to delete \u0027{0}\u0027; checkpoint not found\".\r"},{"line_number":201,"context_line":"                    format(checkpoint_id))\r"},{"line_number":202,"context_line":"        if failure_count \u003d\u003d len(parsed_args.checkpoint):\r"},{"line_number":203,"context_line":"            raise exceptions.CommandError(\r"},{"line_number":204,"context_line":"                \"Unable to find and delete any of the \"\r"},{"line_number":205,"context_line":"                \"specified checkpoint.\")\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_56d4f747","line":205,"range":{"start_line":198,"start_character":0,"end_line":205,"end_character":40},"updated":"2017-07-05 07:12:56.000000000","message":"if there is a failure, we increment failure_count, but then raise and exception, so we don\u0027t continue to the other checkpoints, and never reach line 202.\nHow about replace line 199-201 with a log instead of a raise?\n\n(I just noticed this is the same in the plan module of OpenStack Client of karbor)","commit_id":"4ef9597aefbcdc153de4a13e3d22c672ea52854f"},{"author":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"change_message_id":"a58528be915c5d11617150b50d1ff25c549aafc8","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                client.checkpoints.delete(parsed_args.provider_id,\r"},{"line_number":196,"context_line":"                                          checkpoint_id)\r"},{"line_number":197,"context_line":"            except exceptions.NotFound:\r"},{"line_number":198,"context_line":"                failure_count +\u003d 1\r"},{"line_number":199,"context_line":"                raise exceptions.CommandError(\r"},{"line_number":200,"context_line":"                    \"Failed to delete \u0027{0}\u0027; checkpoint not found\".\r"},{"line_number":201,"context_line":"                    format(checkpoint_id))\r"},{"line_number":202,"context_line":"        if failure_count \u003d\u003d len(parsed_args.checkpoint):\r"},{"line_number":203,"context_line":"            raise exceptions.CommandError(\r"},{"line_number":204,"context_line":"                \"Unable to find and delete any of the \"\r"},{"line_number":205,"context_line":"                \"specified checkpoint.\")\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_d13db1c4","line":205,"range":{"start_line":198,"start_character":0,"end_line":205,"end_character":40},"in_reply_to":"3f1d235d_56d4f747","updated":"2017-07-05 07:41:50.000000000","message":"Ok, thanks for your review. I\u0027ll fix it later.","commit_id":"4ef9597aefbcdc153de4a13e3d22c672ea52854f"}]}