)]}'
{"karborclient/osc/v1/scheduled_operations.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"938039aa80e80c356e7e3a0c048cb61686573e71","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                so \u003d osc_utils.find_resource(client.scheduled_operations,\r"},{"line_number":199,"context_line":"                                             so_id)\r"},{"line_number":200,"context_line":"                client.scheduled_operations.delete(so.id)\r"},{"line_number":201,"context_line":"            except exceptions.NotFound:\r"},{"line_number":202,"context_line":"                failure_count +\u003d 1\r"},{"line_number":203,"context_line":"                raise exceptions.CommandError(\r"},{"line_number":204,"context_line":"                    \"Failed to delete \u0027{0}\u0027; scheduled operation not found\".\r"},{"line_number":205,"context_line":"                    format(so_id))\r"},{"line_number":206,"context_line":"        if failure_count \u003d\u003d len(parsed_args.scheduledoperation):\r"},{"line_number":207,"context_line":"            raise exceptions.CommandError(\r"},{"line_number":208,"context_line":"                \"Unable to find and delete any of the \"\r"},{"line_number":209,"context_line":"                \"specified scheduled operation.\")\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_b6e58b0b","line":209,"range":{"start_line":201,"start_character":0,"end_line":209,"end_character":49},"updated":"2017-07-05 07:14:36.000000000","message":"if there is a failure, we increment failure_count, but then raise and exception, so we don\u0027t continue to the other checkpoints, and never reach line 206.\nHow about replace line 203-205 with a log instead of a raise?\n(I just noticed this is the same in the plan module of OpenStack Client of karbor)","commit_id":"9e6079898855b6788aa4affb1d3a84360f83aa3a"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"30451a8e2beb68d19651520c4b3981f9d9a6d82f","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                so \u003d osc_utils.find_resource(client.scheduled_operations,\r"},{"line_number":199,"context_line":"                                             so_id)\r"},{"line_number":200,"context_line":"                client.scheduled_operations.delete(so.id)\r"},{"line_number":201,"context_line":"            except exceptions.NotFound:\r"},{"line_number":202,"context_line":"                failure_count +\u003d 1\r"},{"line_number":203,"context_line":"                raise exceptions.CommandError(\r"},{"line_number":204,"context_line":"                    \"Failed to delete \u0027{0}\u0027; scheduled operation not found\".\r"},{"line_number":205,"context_line":"                    format(so_id))\r"},{"line_number":206,"context_line":"        if failure_count \u003d\u003d len(parsed_args.scheduledoperation):\r"},{"line_number":207,"context_line":"            raise exceptions.CommandError(\r"},{"line_number":208,"context_line":"                \"Unable to find and delete any of the \"\r"},{"line_number":209,"context_line":"                \"specified scheduled operation.\")\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_564e3797","line":209,"range":{"start_line":201,"start_character":0,"end_line":209,"end_character":49},"in_reply_to":"3f1d235d_b6e58b0b","updated":"2017-07-05 07:36:34.000000000","message":"Ahh, nice catch. Let me fix this and the other modules.","commit_id":"9e6079898855b6788aa4affb1d3a84360f83aa3a"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"5a720e31eb3614290f4a036ad70d2ee16f25132c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                client.scheduled_operations.delete(so.id)\r"},{"line_number":201,"context_line":"            except exceptions.NotFound:\r"},{"line_number":202,"context_line":"                failure_count +\u003d 1\r"},{"line_number":203,"context_line":"                print(\"Failed to delete \u0027%s\u0027; scheduled operation \"\r"},{"line_number":204,"context_line":"                      \"not found\" % so_id)\r"},{"line_number":205,"context_line":"        if failure_count \u003d\u003d len(parsed_args.scheduledoperation):\r"},{"line_number":206,"context_line":"            raise exceptions.CommandError(\r"},{"line_number":207,"context_line":"                \"Unable to find and delete any of the \"\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_91c73965","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":42},"updated":"2017-07-05 07:52:03.000000000","message":"Hi yuval, I replace raise with print function. I think it\u0027s better we just print the error in CLI.","commit_id":"f213bf451d5ab99d13ea129e88e99c5165010296"}]}