)]}'
{"karborclient/osc/v1/triggers.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"d32b6a7a7bab56f929fb7f53a78dbbd066eaedef","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                trigger \u003d osc_utils.find_resource(client.triggers, trigger_id)\r"},{"line_number":220,"context_line":"                client.triggers.delete(trigger.id)\r"},{"line_number":221,"context_line":"            except exceptions.NotFound:\r"},{"line_number":222,"context_line":"                failure_count +\u003d 1\r"},{"line_number":223,"context_line":"                raise exceptions.CommandError(\r"},{"line_number":224,"context_line":"                    \"Failed to delete \u0027{0}\u0027; trigger not found\".\r"},{"line_number":225,"context_line":"                    format(trigger_id))\r"},{"line_number":226,"context_line":"        if failure_count \u003d\u003d len(parsed_args.trigger):\r"},{"line_number":227,"context_line":"            raise exceptions.CommandError(\r"},{"line_number":228,"context_line":"                \"Unable to find and delete any of the \"\r"},{"line_number":229,"context_line":"                \"specified trigger.\")\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_f6b8a3e5","line":229,"range":{"start_line":222,"start_character":0,"end_line":229,"end_character":37},"updated":"2017-07-05 07:15:26.000000000","message":"if there is a failure, we increment failure_count, but then raise and exception, so we don\u0027t continue to the other triggers, and never reach line 226.\nHow about replace line 223-225 with a log instead of a raise?\n(I just noticed this is the same in the plan module of OpenStack Client of karbor)","commit_id":"b3bba4e888566f31d375cc43cecb10bfcb6c85b0"}]}
