)]}'
{"id":"openstack%2Fpython-karborclient~480560","triplet_id":"openstack%2Fpython-karborclient~master~Ib752ad4c3aed525c4bea9dbd5710172ddbaf193b","project":"openstack/python-karborclient","branch":"master","topic":"iteritems","hashtags":[],"change_id":"Ib752ad4c3aed525c4bea9dbd5710172ddbaf193b","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2017-07-05 12:41:45.000000000","updated":"2017-07-13 12:13:25.000000000","submitted":"2017-07-13 12:13:25.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"401391dcf68d449deb6f583f2f8f76d6896d52da","_number":480560,"virtual_id_number":480560,"owner":{"_account_id":25006,"name":"sudhir agarwal","email":"sudhir.agarwal@nectechnologies.in","username":"sudhir_agarwal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-07-13 12:13:25.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"value":0,"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-06 06:54:35.000000000","_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"value":2,"date":"2017-07-13 12:08:40.000000000","_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},{"value":1,"date":"2017-07-13 12:08:40.000000000","_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-06 06:54:35.000000000","updated_by":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"reviewer":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"state":"REVIEWER"},{"updated":"2017-07-13 12:08:40.000000000","updated_by":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"reviewer":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"state":"REVIEWER"},{"updated":"2017-07-13 12:13:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4baa4c5502152576f6876b3500beeaa421b61473","author":{"_account_id":25006,"name":"sudhir agarwal","email":"sudhir.agarwal@nectechnologies.in","username":"sudhir_agarwal"},"date":"2017-07-05 12:41:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"97214c029455e3d72da778a4c13d12b63996ffe6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-05 12:49:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-karborclient-docs-ubuntu-xenial http://docs-draft.openstack.org/60/480560/1/check/gate-python-karborclient-docs-ubuntu-xenial/fce1f66//doc/build/html/ : SUCCESS in 5m 45s\n- gate-python-karborclient-pep8-ubuntu-xenial http://logs.openstack.org/60/480560/1/check/gate-python-karborclient-pep8-ubuntu-xenial/a1e88f5/ : FAILURE in 3m 49s\n- gate-python-karborclient-python27-ubuntu-xenial http://logs.openstack.org/60/480560/1/check/gate-python-karborclient-python27-ubuntu-xenial/bb85f66/ : SUCCESS in 2m 52s\n- gate-python-karborclient-python35 http://logs.openstack.org/60/480560/1/check/gate-python-karborclient-python35/b9e798e/ : SUCCESS in 2m 40s\n- python-karborclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/60/480560/1/check/python-karborclient-coverage-ubuntu-xenial-nv/4ae9716/ : SUCCESS in 4m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"57d5f1e25e5dc21de73d1a1105fb44a6ade5e34b","author":{"_account_id":25006,"name":"sudhir agarwal","email":"sudhir.agarwal@nectechnologies.in","username":"sudhir_agarwal"},"date":"2017-07-05 12:53:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"66c4e6bc19369960ffe9599bb0e970f49caa0dcc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-05 13:00:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-karborclient-docs-ubuntu-xenial http://docs-draft.openstack.org/60/480560/2/check/gate-python-karborclient-docs-ubuntu-xenial/7245131//doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-karborclient-pep8-ubuntu-xenial http://logs.openstack.org/60/480560/2/check/gate-python-karborclient-pep8-ubuntu-xenial/f5db442/ : SUCCESS in 2m 52s\n- gate-python-karborclient-python27-ubuntu-xenial http://logs.openstack.org/60/480560/2/check/gate-python-karborclient-python27-ubuntu-xenial/436bbed/ : SUCCESS in 1m 19s\n- gate-python-karborclient-python35 http://logs.openstack.org/60/480560/2/check/gate-python-karborclient-python35/8072f63/ : SUCCESS in 1m 13s\n- python-karborclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/60/480560/2/check/python-karborclient-coverage-ubuntu-xenial-nv/39e1c47/ : SUCCESS in 1m 13s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"58cf5962f90af39fbf7075f5f8574b4afd3bb41b","author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"date":"2017-07-06 06:54:35.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5dc157de2890790216ef13197f476f0894d50f2c","author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"date":"2017-07-13 12:08:40.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"fe179b4a839d84bb3efdb277ce2336db5fddd982","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 12:09:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"38794c4ca64f349d385b050678f9832dc9ff7bcb","date":"2017-07-13 12:13:25.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"4a8bfd0d293a7338d5608055da6edd0b5e7112a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 12:13:25.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-karborclient-docs-ubuntu-xenial http://docs-draft.openstack.org/60/480560/2/gate/gate-python-karborclient-docs-ubuntu-xenial/517f4fb//doc/build/html/ : SUCCESS in 2m 01s\n- gate-python-karborclient-pep8-ubuntu-xenial http://logs.openstack.org/60/480560/2/gate/gate-python-karborclient-pep8-ubuntu-xenial/7dc6668/ : SUCCESS in 2m 25s\n- gate-python-karborclient-python27-ubuntu-xenial http://logs.openstack.org/60/480560/2/gate/gate-python-karborclient-python27-ubuntu-xenial/49abaec/ : SUCCESS in 2m 25s\n- gate-python-karborclient-python35 http://logs.openstack.org/60/480560/2/gate/gate-python-karborclient-python35/979c3e4/ : SUCCESS in 3m 19s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"eb70a9d460af9cdf3ec1fa99c367460e85d55c80","revisions":{"f2068395caae62cb25a058420cecfdc3e5f7aa40":{"kind":"REWORK","_number":1,"created":"2017-07-05 12:41:45.000000000","uploader":{"_account_id":25006,"name":"sudhir agarwal","email":"sudhir.agarwal@nectechnologies.in","username":"sudhir_agarwal"},"ref":"refs/changes/60/480560/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-karborclient","ref":"refs/changes/60/480560/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/60/480560/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/60/480560/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/60/480560/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-karborclient refs/changes/60/480560/1"}}},"commit":{"parents":[{"commit":"1a7243354e90b8c5d4245dad6ac3a66ec3b38863","subject":"Merge \"Add OpenStackClient plugin for checkpoint\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/1a7243354e90b8c5d4245dad6ac3a66ec3b38863"}]}],"author":{"name":"sudhir_agarwal","email":"sudhir.agarwal@nectechnologies.in","date":"2017-07-05 12:43:02.000000000","tz":330},"committer":{"name":"sudhir_agarwal","email":"sudhir.agarwal@nectechnologies.in","date":"2017-07-05 12:44:37.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Ib752ad4c3aed525c4bea9dbd5710172ddbaf193b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/f2068395caae62cb25a058420cecfdc3e5f7aa40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/f2068395caae62cb25a058420cecfdc3e5f7aa40"}]},"branch":"refs/heads/master"},"eb70a9d460af9cdf3ec1fa99c367460e85d55c80":{"kind":"REWORK","_number":2,"created":"2017-07-05 12:53:19.000000000","uploader":{"_account_id":25006,"name":"sudhir agarwal","email":"sudhir.agarwal@nectechnologies.in","username":"sudhir_agarwal"},"ref":"refs/changes/60/480560/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-karborclient","ref":"refs/changes/60/480560/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/60/480560/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/60/480560/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-karborclient refs/changes/60/480560/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-karborclient refs/changes/60/480560/2"}}},"commit":{"parents":[{"commit":"1a7243354e90b8c5d4245dad6ac3a66ec3b38863","subject":"Merge \"Add OpenStackClient plugin for checkpoint\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/1a7243354e90b8c5d4245dad6ac3a66ec3b38863"}]}],"author":{"name":"sudhir_agarwal","email":"sudhir.agarwal@nectechnologies.in","date":"2017-07-05 12:43:02.000000000","tz":330},"committer":{"name":"sudhir_agarwal","email":"sudhir.agarwal@nectechnologies.in","date":"2017-07-05 12:56:01.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Ib752ad4c3aed525c4bea9dbd5710172ddbaf193b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/eb70a9d460af9cdf3ec1fa99c367460e85d55c80"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-karborclient/commit/eb70a9d460af9cdf3ec1fa99c367460e85d55c80"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}