)]}'
{"keystoneclient/auth/identity/v2.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9ba7b98f2e3ae22e44ca9dce40f20d84c9b23c12","unresolved":false,"context_lines":[{"line_number":76,"context_line":"class Password(Auth):"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, auth_url, username, password,"},{"line_number":79,"context_line":"                 #the following three parameters are for parity with the"},{"line_number":80,"context_line":"                 #V3 Plugin only.  They will be ignored if passed in."},{"line_number":81,"context_line":"                 user_id\u003dNone,"},{"line_number":82,"context_line":"                 user_domain_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1ad8e81c","line":79,"updated":"2014-06-21 00:34:51.000000000","message":"needs a space after the #","commit_id":"c37eb18154de498d4991d099bc910ad77fcdb965"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"969b34a8a6fdca66170051b061e460556fcfe880","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                 #V3 Plugin only.  They will be ignored if passed in."},{"line_number":81,"context_line":"                 user_id\u003dNone,"},{"line_number":82,"context_line":"                 user_domain_id\u003dNone,"},{"line_number":83,"context_line":"                 user_domain_name\u003dNone,"},{"line_number":84,"context_line":"                 **kwargs):"},{"line_number":85,"context_line":"        \"\"\"A plugin for authenticating with a username and password."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e6fd6f3c","line":83,"updated":"2014-06-20 20:58:51.000000000","message":"I don\u0027t understand this change. What\u0027s the point of passing keyword arguments (to be ignored) where there\u0027s already a **kwargs?","commit_id":"c37eb18154de498d4991d099bc910ad77fcdb965"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9ba7b98f2e3ae22e44ca9dce40f20d84c9b23c12","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                 #V3 Plugin only.  They will be ignored if passed in."},{"line_number":81,"context_line":"                 user_id\u003dNone,"},{"line_number":82,"context_line":"                 user_domain_id\u003dNone,"},{"line_number":83,"context_line":"                 user_domain_name\u003dNone,"},{"line_number":84,"context_line":"                 **kwargs):"},{"line_number":85,"context_line":"        \"\"\"A plugin for authenticating with a username and password."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_facc1c63","line":83,"in_reply_to":"1ae5cdf2_e6fd6f3c","updated":"2014-06-21 00:34:51.000000000","message":"I think that this is trying to make the plugin have the same signature as v3\u0027s PasswordMethod. If I read the bug correctly Horizon is maybe detecting v2 vs. v3 so it can call with the right params?  If this is the case I think it\u0027s a good change.\n\nkwargs isn\u0027t the right solution if these params shouldn\u0027t be used anyway.  I bet that whatever gets the kwargs doesn\u0027t like the extra param and that\u0027s what Horizon has to do what it does.","commit_id":"c37eb18154de498d4991d099bc910ad77fcdb965"}]}
