)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"2da62824fbfddcba716155b95db265ede71d2f80","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harry Rybacki \u003chrybacki@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-26 11:22:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add optional parameters to EndpointManger create()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I490e35b89f7ae7c6cdbced6ba8d3b82d5132c19d"},{"line_number":10,"context_line":"Closes-Bug: #1318436"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_322b5a34","line":7,"updated":"2014-06-26 16:14:11.000000000","message":"Based on the changes, it is more accurate to say \"Make adminurl and internalurl parameters to EndpointManager create() optional\"","commit_id":"d2e2277fb47b711bb08cbb06714d0c97f89e502e"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"4d46d0055268890488ce0a6a193c7de3780b17f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harry Rybacki \u003chrybacki@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-26 11:22:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add optional parameters to EndpointManger create()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I490e35b89f7ae7c6cdbced6ba8d3b82d5132c19d"},{"line_number":10,"context_line":"Closes-Bug: #1318436"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_58c5608e","line":7,"in_reply_to":"1ae5cdf2_322b5a34","updated":"2014-06-26 19:39:37.000000000","message":"Agreed. Will change for PS #3","commit_id":"d2e2277fb47b711bb08cbb06714d0c97f89e502e"}],"keystoneclient/v2_0/endpoints.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"56287ebfc12313a2621c40a850dc948949e98560","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               region\u003dNone,"},{"line_number":38,"context_line":"               adminurl\u003dNone,"},{"line_number":39,"context_line":"               internalurl\u003dNone):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        \"\"\"Create a new endpoint.\"\"\""},{"line_number":42,"context_line":"        body \u003d {\u0027endpoint\u0027: {\u0027region\u0027: region,"},{"line_number":43,"context_line":"                             \u0027service_id\u0027: service_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_450f5e2e","line":40,"updated":"2014-06-26 01:26:43.000000000","message":"-1: changing the order of arguments will break consumers, so it doesn\u0027t look like we can default region to None unless we also default service_id and publicurl to something, which wouldn\u0027t make sense. It looks like the best we can do is defaulting adminurl and internalurl to None :-/\n\nnits: We don\u0027t normally format method signatures this way, although I appreciate the benefit of doing so. the community standard is to fill up the 79 chars, and line wrap to the same character column that you did here (after the paren). The newline after the method signature can also be removed.","commit_id":"b4f58dac98660f6307a3874f1d47e76bf34e3c58"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"2ec26e8a9ad690bd14ea151f05031bfbb78ce5d9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               region\u003dNone,"},{"line_number":38,"context_line":"               adminurl\u003dNone,"},{"line_number":39,"context_line":"               internalurl\u003dNone):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        \"\"\"Create a new endpoint.\"\"\""},{"line_number":42,"context_line":"        body \u003d {\u0027endpoint\u0027: {\u0027region\u0027: region,"},{"line_number":43,"context_line":"                             \u0027service_id\u0027: service_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_fab9ceec","line":40,"in_reply_to":"1ae5cdf2_450f5e2e","updated":"2014-06-26 14:32:57.000000000","message":"@Dolph Mathews -- nods. That makes sense --- I thought it smelled funny. I\u0027ll make the changes. Thanks!","commit_id":"b4f58dac98660f6307a3874f1d47e76bf34e3c58"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"3757029aa3f0cbee34aec8b31fd2ee041bc7d957","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               region\u003dNone,"},{"line_number":38,"context_line":"               adminurl\u003dNone,"},{"line_number":39,"context_line":"               internalurl\u003dNone):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        \"\"\"Create a new endpoint.\"\"\""},{"line_number":42,"context_line":"        body \u003d {\u0027endpoint\u0027: {\u0027region\u0027: region,"},{"line_number":43,"context_line":"                             \u0027service_id\u0027: service_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8bab1ed5","line":40,"in_reply_to":"1ae5cdf2_450f5e2e","updated":"2014-06-26 15:24:53.000000000","message":"Done","commit_id":"b4f58dac98660f6307a3874f1d47e76bf34e3c58"}],"keystoneclient/v2_0/shell.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"56287ebfc12313a2621c40a850dc948949e98560","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                                   args.publicurl,"},{"line_number":524,"context_line":"                                   args.region,"},{"line_number":525,"context_line":"                                   args.adminurl,"},{"line_number":526,"context_line":"                                   args.internalurl)"},{"line_number":527,"context_line":"    utils.print_dict(endpoint._info)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_0521d69d","line":526,"updated":"2014-06-26 01:26:43.000000000","message":"this module (being just one of many consumers of the API in the other file) shouldn\u0027t be impacted by this change","commit_id":"b4f58dac98660f6307a3874f1d47e76bf34e3c58"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"2ec26e8a9ad690bd14ea151f05031bfbb78ce5d9","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                                   args.publicurl,"},{"line_number":524,"context_line":"                                   args.region,"},{"line_number":525,"context_line":"                                   args.adminurl,"},{"line_number":526,"context_line":"                                   args.internalurl)"},{"line_number":527,"context_line":"    utils.print_dict(endpoint._info)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_faa0eea6","line":526,"in_reply_to":"1ae5cdf2_0521d69d","updated":"2014-06-26 14:32:57.000000000","message":"@Dolph Mathews -- Nods. Thanks!","commit_id":"b4f58dac98660f6307a3874f1d47e76bf34e3c58"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"3757029aa3f0cbee34aec8b31fd2ee041bc7d957","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                                   args.publicurl,"},{"line_number":524,"context_line":"                                   args.region,"},{"line_number":525,"context_line":"                                   args.adminurl,"},{"line_number":526,"context_line":"                                   args.internalurl)"},{"line_number":527,"context_line":"    utils.print_dict(endpoint._info)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_0b870e62","line":526,"in_reply_to":"1ae5cdf2_0521d69d","updated":"2014-06-26 15:24:53.000000000","message":"Done","commit_id":"b4f58dac98660f6307a3874f1d47e76bf34e3c58"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"2da62824fbfddcba716155b95db265ede71d2f80","unresolved":false,"context_lines":[{"line_number":518,"context_line":"def do_endpoint_create(kc, args):"},{"line_number":519,"context_line":"    \"\"\"Create a new endpoint associated with a service.\"\"\""},{"line_number":520,"context_line":"    service_id \u003d utils.find_resource(kc.services, args.service).id"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    endpoint \u003d kc.endpoints.create(args.region,"},{"line_number":523,"context_line":"                                   service_id,"},{"line_number":524,"context_line":"                                   args.publicurl,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_72afa29d","line":521,"updated":"2014-06-26 16:14:11.000000000","message":"What\u0027s the purpose of a new line here?","commit_id":"d2e2277fb47b711bb08cbb06714d0c97f89e502e"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"721abc5bf2f70115775d4bff8ae411fa5ad957d1","unresolved":false,"context_lines":[{"line_number":518,"context_line":"def do_endpoint_create(kc, args):"},{"line_number":519,"context_line":"    \"\"\"Create a new endpoint associated with a service.\"\"\""},{"line_number":520,"context_line":"    service_id \u003d utils.find_resource(kc.services, args.service).id"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    endpoint \u003d kc.endpoints.create(args.region,"},{"line_number":523,"context_line":"                                   service_id,"},{"line_number":524,"context_line":"                                   args.publicurl,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_18e83815","line":521,"in_reply_to":"1ae5cdf2_72afa29d","updated":"2014-06-26 19:38:49.000000000","message":"Ah, good catch. Thank you, will be removed in PS #3","commit_id":"d2e2277fb47b711bb08cbb06714d0c97f89e502e"}]}