)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"35b572184c6e6b8593f6ed924f85b470c98f6ae9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harry Rybacki \u003chrybacki@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-27 15:48:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests for optional create endpoint params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2cd542a15a54017beb9430a429fb4be86130a15c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab895d6_4df37973","line":7,"updated":"2014-06-29 07:33:12.000000000","message":"Slightly confusing title, you\u0027re really testing what happens when you don\u0027t specify the optional params","commit_id":"63bee3782f5d119cdf4c59176c6d21aee4270380"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"10bd9d2142700bcb28c798cf94fc4d84732aa49d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harry Rybacki \u003chrybacki@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-27 15:48:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests for optional create endpoint params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2cd542a15a54017beb9430a429fb4be86130a15c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_8149e08d","line":7,"in_reply_to":"dab895d6_4df37973","updated":"2014-06-30 15:43:05.000000000","message":"Valid point, noted that it was tests _without_ optional params in PS #2","commit_id":"63bee3782f5d119cdf4c59176c6d21aee4270380"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"9b13bd573b9324fae1c41ac8b10c31a2a420bf08","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harry Rybacki \u003chrybacki@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-03 09:35:37 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests without optional create endpoint params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2cd542a15a54017beb9430a429fb4be86130a15c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"baada198_b06105d5","line":7,"updated":"2014-07-07 03:49:51.000000000","message":"could use some more description. why?","commit_id":"f22ca87e0e419c7bc129163d927e26f68e5e904d"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"3dbc8250fedccc706db3cc2cf7ed9c0039696e9c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harry Rybacki \u003chrybacki@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-03 09:35:37 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests without optional create endpoint params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2cd542a15a54017beb9430a429fb4be86130a15c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"baada198_13ac5f8b","line":7,"in_reply_to":"baada198_b06105d5","updated":"2014-07-07 18:36:05.000000000","message":"I\u0027ll modify the commit message to state this is a follow on test set for making adminurl and internalurl optional parameters","commit_id":"f22ca87e0e419c7bc129163d927e26f68e5e904d"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"bf10a79e42438758dea24f0860f942c490131ea6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests without optional create endpoint params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Follow up tests for change #102602 "},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"With internalurl and adminurl now being optional parameters"},{"line_number":12,"context_line":"there needs to be tests to ensure calls to create() without"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baada198_1ed53fe4","line":9,"updated":"2014-07-07 23:34:34.000000000","message":"Remove the extra space after #102602","commit_id":"6e8ade2efd3966f2753a9607f830cb169ef1d50d"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"9f15ea996f953ae100dc02c141aa868871bbd71d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests without optional create endpoint params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Follow up tests for change #102602 "},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"With internalurl and adminurl now being optional parameters"},{"line_number":12,"context_line":"there needs to be tests to ensure calls to create() without"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baada198_903d73be","line":9,"in_reply_to":"baada198_1ed53fe4","updated":"2014-07-09 17:16:27.000000000","message":"Done","commit_id":"6e8ade2efd3966f2753a9607f830cb169ef1d50d"}],"keystoneclient/tests/v2_0/test_endpoints.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"35b572184c6e6b8593f6ed924f85b470c98f6ae9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \"service_id\": \"e044e21\","},{"line_number":81,"context_line":"                \"publicurl\": \"http://host-3:8774/v1.1/$(tenant_id)s\","},{"line_number":82,"context_line":"                \"adminurl\": None,"},{"line_number":83,"context_line":"                \"internalurl\": None,"},{"line_number":84,"context_line":"            }"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab895d6_8ded918e","line":83,"updated":"2014-06-29 07:33:12.000000000","message":"maybe even have two req_bodies for the test...one when \u0027None\" is included and one when you simply omit the optional attributes entirely from the dict?","commit_id":"63bee3782f5d119cdf4c59176c6d21aee4270380"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"10bd9d2142700bcb28c798cf94fc4d84732aa49d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \"service_id\": \"e044e21\","},{"line_number":81,"context_line":"                \"publicurl\": \"http://host-3:8774/v1.1/$(tenant_id)s\","},{"line_number":82,"context_line":"                \"adminurl\": None,"},{"line_number":83,"context_line":"                \"internalurl\": None,"},{"line_number":84,"context_line":"            }"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_2131f40b","line":83,"in_reply_to":"dab895d6_8ded918e","updated":"2014-06-30 15:43:05.000000000","message":"added another request set without the optional params and verified that it created the endpoint instance in PS #2","commit_id":"63bee3782f5d119cdf4c59176c6d21aee4270380"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"45307ea87fb401a6d61cbe7681e6df85ac5f52e6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        req_body_with_defaults \u003d {"},{"line_number":78,"context_line":"            \"endpoint\": {"},{"line_number":79,"context_line":"                \"region\": \"RegionOne\","},{"line_number":80,"context_line":"                \"service_id\": \"e044e21\","},{"line_number":81,"context_line":"                \"publicurl\": \"http://host-3:8774/v1.1/$(tenant_id)s\","},{"line_number":82,"context_line":"                \"adminurl\": None,"},{"line_number":83,"context_line":"                \"internalurl\": None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d371e378","line":80,"updated":"2014-06-30 19:37:06.000000000","message":"use a random uuid for the service id.","commit_id":"3be4f92f37a719cf23a4a3325dfa0ee389fcdc4e"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"2c7318f96643bef5e6290fbf84646b6dd2e26925","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        req_body_with_defaults \u003d {"},{"line_number":78,"context_line":"            \"endpoint\": {"},{"line_number":79,"context_line":"                \"region\": \"RegionOne\","},{"line_number":80,"context_line":"                \"service_id\": \"e044e21\","},{"line_number":81,"context_line":"                \"publicurl\": \"http://host-3:8774/v1.1/$(tenant_id)s\","},{"line_number":82,"context_line":"                \"adminurl\": None,"},{"line_number":83,"context_line":"                \"internalurl\": None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_eab6cc89","line":80,"in_reply_to":"baada198_d371e378","updated":"2014-07-01 14:40:43.000000000","message":"Okay -- I\u0027m assuming this should be done for the test before it as well. Should I include that with this change or should that be a new change completely?","commit_id":"3be4f92f37a719cf23a4a3325dfa0ee389fcdc4e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"45307ea87fb401a6d61cbe7681e6df85ac5f52e6","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.stub_url(httpretty.POST, [\u0027endpoints\u0027], json\u003dresp_body)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        endpoint_with_defaults \u003d self.client.endpoints.create("},{"line_number":106,"context_line":"            region\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027region\u0027],"},{"line_number":107,"context_line":"            publicurl\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027publicurl\u0027],"},{"line_number":108,"context_line":"            service_id\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027service_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_33ee9fed","line":105,"updated":"2014-06-30 19:37:06.000000000","message":"what\u0027s the point of doing this? the same thing was done at line 65. add a comment.","commit_id":"3be4f92f37a719cf23a4a3325dfa0ee389fcdc4e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"18cd103dfca914d89112b8b037a7e1616b296d85","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.stub_url(httpretty.POST, [\u0027endpoints\u0027], json\u003dresp_body)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        endpoint_with_defaults \u003d self.client.endpoints.create("},{"line_number":106,"context_line":"            region\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027region\u0027],"},{"line_number":107,"context_line":"            publicurl\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027publicurl\u0027],"},{"line_number":108,"context_line":"            service_id\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027service_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c41114ae","line":105,"in_reply_to":"baada198_33ee9fed","updated":"2014-07-01 02:34:09.000000000","message":"Yeah, I\u0027m confused as to why this test is testing both \u0027with\u0027 and \u0027without\u0027 the optional params.","commit_id":"3be4f92f37a719cf23a4a3325dfa0ee389fcdc4e"},{"author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"change_message_id":"483a5117f686d5a238738c49320992cbc6ba6e2a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.stub_url(httpretty.POST, [\u0027endpoints\u0027], json\u003dresp_body)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        endpoint_with_defaults \u003d self.client.endpoints.create("},{"line_number":106,"context_line":"            region\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027region\u0027],"},{"line_number":107,"context_line":"            publicurl\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027publicurl\u0027],"},{"line_number":108,"context_line":"            service_id\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027service_id\u0027],"},{"line_number":109,"context_line":"            adminurl\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027adminurl\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_05206348","line":106,"updated":"2014-07-01 07:29:23.000000000","message":"I am confused too. I thought this test is for \u0027without\u0027 optional params.","commit_id":"3be4f92f37a719cf23a4a3325dfa0ee389fcdc4e"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"2c7318f96643bef5e6290fbf84646b6dd2e26925","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.stub_url(httpretty.POST, [\u0027endpoints\u0027], json\u003dresp_body)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        endpoint_with_defaults \u003d self.client.endpoints.create("},{"line_number":106,"context_line":"            region\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027region\u0027],"},{"line_number":107,"context_line":"            publicurl\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027publicurl\u0027],"},{"line_number":108,"context_line":"            service_id\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027service_id\u0027],"},{"line_number":109,"context_line":"            adminurl\u003dreq_body_with_defaults[\u0027endpoint\u0027][\u0027adminurl\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6a81dc8e","line":106,"in_reply_to":"baada198_05206348","updated":"2014-07-01 14:40:43.000000000","message":"You are right, the optional params need to be removed. I wasn\u0027t understanding how this was all working. Thanks for making me dig deeper!","commit_id":"3be4f92f37a719cf23a4a3325dfa0ee389fcdc4e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"45307ea87fb401a6d61cbe7681e6df85ac5f52e6","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        )"},{"line_number":117,"context_line":"        self.assertIsInstance(endpoint_with_defaults, endpoints.Endpoint)"},{"line_number":118,"context_line":"        self.assertIsInstance(endpoint_without_defaults, endpoints.Endpoint)"},{"line_number":119,"context_line":"        self.assertRequestBodyIs(json\u003dreq_body_with_defaults)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @httpretty.activate"},{"line_number":122,"context_line":"    def test_delete(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_73d81754","line":119,"updated":"2014-06-30 19:37:06.000000000","message":"there should be something that asserts that the correct req body is used when there\u0027s no defaults.","commit_id":"3be4f92f37a719cf23a4a3325dfa0ee389fcdc4e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"c615f19afc7cca6140dd259126269c41c51743a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import httpretty"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneclient.tests.v2_0 import utils"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_67cbaaa5","line":13,"updated":"2014-07-02 13:00:39.000000000","message":"Imports still need to be fixed:\n\nhttp://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"e0735c22d8fb338a95a6d518ad10588efca412a0"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"dfb4c39e5770736b6b94f4adf026bae897ac9367","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import httpretty"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneclient.tests.v2_0 import utils"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_79350ef6","line":13,"in_reply_to":"baada198_67cbaaa5","updated":"2014-07-02 13:53:07.000000000","message":"Done","commit_id":"e0735c22d8fb338a95a6d518ad10588efca412a0"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"2f4c0f98f4a562956c53523ae2ef47a98796a906","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @httpretty.activate"},{"line_number":77,"context_line":"    def test_create_without_optional_params(self):"},{"line_number":78,"context_line":"        req_body_without_defaults \u003d {"},{"line_number":79,"context_line":"            \"endpoint\": {"},{"line_number":80,"context_line":"                \"region\": \"RegionOne\","},{"line_number":81,"context_line":"                \"service_id\": uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_52cbca1d","line":78,"updated":"2014-07-02 10:15:16.000000000","message":"so I think the comments on your patch 2 regarding why you were testing with and without optional parameters confused what you were trying to do (partly because you called the two dicts \"with\" and \"without\".  I think what the attempt was to have two dicts:\n\nreq_body_without_optional_params, and\nreq_body_with_optional_params_set_to_none\n\nBoth of these tests, I think, would be valid.","commit_id":"e0735c22d8fb338a95a6d518ad10588efca412a0"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"dfb4c39e5770736b6b94f4adf026bae897ac9367","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @httpretty.activate"},{"line_number":77,"context_line":"    def test_create_without_optional_params(self):"},{"line_number":78,"context_line":"        req_body_without_defaults \u003d {"},{"line_number":79,"context_line":"            \"endpoint\": {"},{"line_number":80,"context_line":"                \"region\": \"RegionOne\","},{"line_number":81,"context_line":"                \"service_id\": uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_9c0d7093","line":78,"in_reply_to":"baada198_07b58e30","updated":"2014-07-02 13:53:07.000000000","message":"David, I think that\u0027s a good idea and a much clearer way of testing this.","commit_id":"e0735c22d8fb338a95a6d518ad10588efca412a0"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"c615f19afc7cca6140dd259126269c41c51743a9","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @httpretty.activate"},{"line_number":77,"context_line":"    def test_create_without_optional_params(self):"},{"line_number":78,"context_line":"        req_body_without_defaults \u003d {"},{"line_number":79,"context_line":"            \"endpoint\": {"},{"line_number":80,"context_line":"                \"region\": \"RegionOne\","},{"line_number":81,"context_line":"                \"service_id\": uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_07b58e30","line":78,"in_reply_to":"baada198_52cbca1d","updated":"2014-07-02 13:00:39.000000000","message":"If that\u0027s the case, having another test method test_create_with_optional_params_as_none (or whatever) would be nice.","commit_id":"e0735c22d8fb338a95a6d518ad10588efca412a0"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"dfb4c39e5770736b6b94f4adf026bae897ac9367","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @httpretty.activate"},{"line_number":77,"context_line":"    def test_create_without_optional_params(self):"},{"line_number":78,"context_line":"        req_body_without_defaults \u003d {"},{"line_number":79,"context_line":"            \"endpoint\": {"},{"line_number":80,"context_line":"                \"region\": \"RegionOne\","},{"line_number":81,"context_line":"                \"service_id\": uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_1c2160fb","line":78,"in_reply_to":"baada198_52cbca1d","updated":"2014-07-02 13:53:07.000000000","message":"Yeah, it was very confusing. I\u0027m creating a second test per David\u0027s request. PS coming soon.","commit_id":"e0735c22d8fb338a95a6d518ad10588efca412a0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cfd71c0ba31d4c08f0b2d0ca6a1632092856dd8a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import httpretty"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from keystoneclient.tests.v2_0 import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2f734816","line":14,"updated":"2014-07-02 14:23:09.000000000","message":"uuid is stdlib so should be in a separate section. See https://github.com/openstack-dev/hacking/blame/master/HACKING.rst#L56","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"da07a932e42db870f1a39130b1f2a0675ddebfe0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import httpretty"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from keystoneclient.tests.v2_0 import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_fdd47bbe","line":14,"in_reply_to":"baada198_2f734816","updated":"2014-07-03 13:41:58.000000000","message":"Done","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cfd71c0ba31d4c08f0b2d0ca6a1632092856dd8a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        resp_body \u003d {"},{"line_number":90,"context_line":"            \"endpoint\": {"},{"line_number":91,"context_line":"                \"region\": \"RegionOne\","},{"line_number":92,"context_line":"                \"id\": \"1fd485b2ffd54f409a5ecd42cba11401\","},{"line_number":93,"context_line":"                \"publicurl\": \"http://host-3:8774/v1.1/$(tenant_id)s\","},{"line_number":94,"context_line":"                \"adminurl\": None,"},{"line_number":95,"context_line":"                \"internalurl\": None,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_afa3d84d","line":92,"updated":"2014-07-02 14:23:09.000000000","message":"use a random uuid here -- uuid.uuid4().hex","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"da07a932e42db870f1a39130b1f2a0675ddebfe0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        resp_body \u003d {"},{"line_number":90,"context_line":"            \"endpoint\": {"},{"line_number":91,"context_line":"                \"region\": \"RegionOne\","},{"line_number":92,"context_line":"                \"id\": \"1fd485b2ffd54f409a5ecd42cba11401\","},{"line_number":93,"context_line":"                \"publicurl\": \"http://host-3:8774/v1.1/$(tenant_id)s\","},{"line_number":94,"context_line":"                \"adminurl\": None,"},{"line_number":95,"context_line":"                \"internalurl\": None,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_bd1f636b","line":92,"in_reply_to":"baada198_afa3d84d","updated":"2014-07-03 13:41:58.000000000","message":"Done","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cfd71c0ba31d4c08f0b2d0ca6a1632092856dd8a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            region\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027region\u0027],"},{"line_number":103,"context_line":"            publicurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027publicurl\u0027],"},{"line_number":104,"context_line":"            service_id\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027service_id\u0027],"},{"line_number":105,"context_line":"            adminurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027adminurl\u0027],"},{"line_number":106,"context_line":"            internalurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027internalurl\u0027]"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":"        self.assertIsInstance(endpoint_without_defaults, endpoints.Endpoint)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_cf02cc3d","line":105,"updated":"2014-07-02 14:23:09.000000000","message":"using adminurl\u003dNone would be more obvious here","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"da07a932e42db870f1a39130b1f2a0675ddebfe0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            region\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027region\u0027],"},{"line_number":103,"context_line":"            publicurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027publicurl\u0027],"},{"line_number":104,"context_line":"            service_id\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027service_id\u0027],"},{"line_number":105,"context_line":"            adminurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027adminurl\u0027],"},{"line_number":106,"context_line":"            internalurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027internalurl\u0027]"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":"        self.assertIsInstance(endpoint_without_defaults, endpoints.Endpoint)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_dd10975b","line":105,"in_reply_to":"baada198_cf02cc3d","updated":"2014-07-03 13:41:58.000000000","message":"Done","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cfd71c0ba31d4c08f0b2d0ca6a1632092856dd8a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            publicurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027publicurl\u0027],"},{"line_number":104,"context_line":"            service_id\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027service_id\u0027],"},{"line_number":105,"context_line":"            adminurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027adminurl\u0027],"},{"line_number":106,"context_line":"            internalurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027internalurl\u0027]"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":"        self.assertIsInstance(endpoint_without_defaults, endpoints.Endpoint)"},{"line_number":109,"context_line":"        self.assertRequestBodyIs(json\u003dreq_body_without_defaults)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2ff8a848","line":106,"updated":"2014-07-02 14:23:09.000000000","message":"using internalurl\u003dNone would be more obvious here","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"da07a932e42db870f1a39130b1f2a0675ddebfe0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            publicurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027publicurl\u0027],"},{"line_number":104,"context_line":"            service_id\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027service_id\u0027],"},{"line_number":105,"context_line":"            adminurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027adminurl\u0027],"},{"line_number":106,"context_line":"            internalurl\u003dreq_body_without_defaults[\u0027endpoint\u0027][\u0027internalurl\u0027]"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":"        self.assertIsInstance(endpoint_without_defaults, endpoints.Endpoint)"},{"line_number":109,"context_line":"        self.assertRequestBodyIs(json\u003dreq_body_without_defaults)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_fd155b49","line":106,"in_reply_to":"baada198_2ff8a848","updated":"2014-07-03 13:41:58.000000000","message":"Done","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cfd71c0ba31d4c08f0b2d0ca6a1632092856dd8a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        resp_body \u003d {"},{"line_number":124,"context_line":"            \"endpoint\": {"},{"line_number":125,"context_line":"                \"region\": \"RegionOne\","},{"line_number":126,"context_line":"                \"id\": \"1fd485b2ffd54f409a5ecd42cba11401\","},{"line_number":127,"context_line":"                \"publicurl\": \"http://host-3:8774/v1.1/$(tenant_id)s\","},{"line_number":128,"context_line":"                \"adminurl\": None,"},{"line_number":129,"context_line":"                \"internalurl\": None,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_af7118e2","line":126,"updated":"2014-07-02 14:23:09.000000000","message":"use a random uuid here -- uuid.uuid4().hex","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"da07a932e42db870f1a39130b1f2a0675ddebfe0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        resp_body \u003d {"},{"line_number":124,"context_line":"            \"endpoint\": {"},{"line_number":125,"context_line":"                \"region\": \"RegionOne\","},{"line_number":126,"context_line":"                \"id\": \"1fd485b2ffd54f409a5ecd42cba11401\","},{"line_number":127,"context_line":"                \"publicurl\": \"http://host-3:8774/v1.1/$(tenant_id)s\","},{"line_number":128,"context_line":"                \"adminurl\": None,"},{"line_number":129,"context_line":"                \"internalurl\": None,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_5d048717","line":126,"in_reply_to":"baada198_af7118e2","updated":"2014-07-03 13:41:58.000000000","message":"Done","commit_id":"0f99b60434d58c697c446ce4b58bbcea15f0c69d"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"985cee8ceb1cfc1c809d8bbc832d5e06d55ffdc3","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @httpretty.activate"},{"line_number":78,"context_line":"    def test_create_with_optional_params_as_none(self):"},{"line_number":79,"context_line":"        req_body_without_defaults \u003d {"},{"line_number":80,"context_line":"            \"endpoint\": {"},{"line_number":81,"context_line":"                \"region\": \"RegionOne\","},{"line_number":82,"context_line":"                \"service_id\": uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_f050dd0c","line":79,"updated":"2014-07-07 03:48:55.000000000","message":"isn\u0027t that the next test?","commit_id":"f22ca87e0e419c7bc129163d927e26f68e5e904d"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"3dbc8250fedccc706db3cc2cf7ed9c0039696e9c","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @httpretty.activate"},{"line_number":78,"context_line":"    def test_create_with_optional_params_as_none(self):"},{"line_number":79,"context_line":"        req_body_without_defaults \u003d {"},{"line_number":80,"context_line":"            \"endpoint\": {"},{"line_number":81,"context_line":"                \"region\": \"RegionOne\","},{"line_number":82,"context_line":"                \"service_id\": uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_13f0dfc7","line":79,"in_reply_to":"baada198_f050dd0c","updated":"2014-07-07 18:36:05.000000000","message":"Both tests use the same request. The actual \u0027None\u0027 values are sent on lines 105 and 106. In the next test they are omitted.","commit_id":"f22ca87e0e419c7bc129163d927e26f68e5e904d"}]}