)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"9aec3e27bf905cb0bc6b8b6f13ed41fa0a911dcb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Boris Pavlovic \u003cboris@pavlovic.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-02 01:32:27 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add profiling support to Keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To be able to create profiling traces in Keystone, client should be"},{"line_number":10,"context_line":"able to send special HTTP header that contains trace info."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_32abc7d9","line":7,"updated":"2014-07-01 22:30:20.000000000","message":"keystoneclient","commit_id":"4add02ba78d81b88eddb43d507d74d907bf7d779"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"27a3843e06bd8b66803e451c124d321cc9be80cf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Boris Pavlovic \u003cboris@pavlovic.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-02 01:32:27 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add profiling support to Keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To be able to create profiling traces in Keystone, client should be"},{"line_number":10,"context_line":"able to send special HTTP header that contains trace info."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_55ce09b5","line":7,"in_reply_to":"baada198_32abc7d9","updated":"2014-07-03 22:01:39.000000000","message":"nope, it\u0027s enabling profiling for keystone, keystoneclient is just used to trigger trace.","commit_id":"4add02ba78d81b88eddb43d507d74d907bf7d779"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"9aec3e27bf905cb0bc6b8b6f13ed41fa0a911dcb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add profiling support to Keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To be able to create profiling traces in Keystone, client should be"},{"line_number":10,"context_line":"able to send special HTTP header that contains trace info."},{"line_number":11,"context_line":"This patch is as well important to be able to make cross project"},{"line_number":12,"context_line":"traces. (Typical case nova calls keystone via python client, if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_d2828b51","line":9,"updated":"2014-07-01 22:30:20.000000000","message":"keystone doesn\u0027t use keystoneclient, so this will have no impact on keystone.","commit_id":"4add02ba78d81b88eddb43d507d74d907bf7d779"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"27a3843e06bd8b66803e451c124d321cc9be80cf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add profiling support to Keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To be able to create profiling traces in Keystone, client should be"},{"line_number":10,"context_line":"able to send special HTTP header that contains trace info."},{"line_number":11,"context_line":"This patch is as well important to be able to make cross project"},{"line_number":12,"context_line":"traces. (Typical case nova calls keystone via python client, if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_75df8d69","line":9,"in_reply_to":"baada198_d2828b51","updated":"2014-07-03 22:01:39.000000000","message":"it is very important. cause all other projects are using keystone. and without this patch, they won\u0027t be able to trace what is happaning inside keystone.","commit_id":"4add02ba78d81b88eddb43d507d74d907bf7d779"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"9aec3e27bf905cb0bc6b8b6f13ed41fa0a911dcb","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Don\u0027t worry no security issue here, trace information is signed by HMAC"},{"line_number":18,"context_line":"key that is setted in api-paste.ini. So only person that knows HMAC key"},{"line_number":19,"context_line":"is able to send proper header."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ide6fe268613bb0cc9d9ec6fae2957cc570e9f851"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_d2e9ab1b","line":19,"updated":"2014-07-01 22:30:20.000000000","message":"This is really a security concern for the profiling library - not for keystoneclient. We should treat this data as a blob.","commit_id":"4add02ba78d81b88eddb43d507d74d907bf7d779"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"27a3843e06bd8b66803e451c124d321cc9be80cf","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Don\u0027t worry no security issue here, trace information is signed by HMAC"},{"line_number":18,"context_line":"key that is setted in api-paste.ini. So only person that knows HMAC key"},{"line_number":19,"context_line":"is able to send proper header."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ide6fe268613bb0cc9d9ec6fae2957cc570e9f851"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_35c995ac","line":19,"in_reply_to":"baada198_d2e9ab1b","updated":"2014-07-03 22:01:39.000000000","message":"It\u0027s more about, that there is no security issue, and that we are able to use.","commit_id":"4add02ba78d81b88eddb43d507d74d907bf7d779"},{"author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"change_message_id":"06a3c0236bbdf36d6757379e0062e590571da5c5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Don\u0027t worry no security issue here, trace information is signed by HMAC"},{"line_number":18,"context_line":"key that is setted in api-paste.ini. So only person that knows HMAC key"},{"line_number":19,"context_line":"is able to send proper header."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ide6fe268613bb0cc9d9ec6fae2957cc570e9f851"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_6a738015","line":20,"updated":"2014-07-02 06:58:07.000000000","message":"I agree with Jamie on this, security is a concern here.","commit_id":"4add02ba78d81b88eddb43d507d74d907bf7d779"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"e8190eafbc6f620eef667fa3897f42c4fa7799dc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Boris Pavlovic \u003cboris@pavlovic.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-04 02:00:41 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add profiling support to Keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To be able to create profiling traces in Keystone, client should be"},{"line_number":10,"context_line":"able to send special HTTP header that contains trace info."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_18184174","line":7,"updated":"2014-07-04 04:13:58.000000000","message":"keystoneclient.","commit_id":"44b8208fae62a3d7ccf07a44824f8969c8ae6559"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"e8190eafbc6f620eef667fa3897f42c4fa7799dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add profiling support to Keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To be able to create profiling traces in Keystone, client should be"},{"line_number":10,"context_line":"able to send special HTTP header that contains trace info."},{"line_number":11,"context_line":"This patch is as well important to be able to make cross project"},{"line_number":12,"context_line":"traces. (Typical case nova calls keystone via python client, if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_582d5994","line":9,"updated":"2014-07-04 04:13:58.000000000","message":"s/in/for","commit_id":"44b8208fae62a3d7ccf07a44824f8969c8ae6559"}]}