)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cfe030d9ae1e1ecfb0b0a5f98bc246939a6b632d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Add a new interface type to the get_endpoint command of the base"},{"line_number":13,"context_line":"identity plugin such that if you ask for the \u0027auth\u0027 interface it will"},{"line_number":14,"context_line":"give you the auth_url."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If653970354b919fdd6e80c061611c3aad129c574"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_f5139db5","line":15,"updated":"2014-07-11 19:33:05.000000000","message":"This needs a bug and DocImpact flag or a blueprint since it\u0027s changing a public API.","commit_id":"04bcffac8554b7611a6f24159ff5a54dd4a0e90d"}],"keystoneclient/auth/identity/base.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c1c3f26b2ee34ce612d03fad2d9efae7426e9d58","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                    for. This plugin will return None (failure)"},{"line_number":113,"context_line":"                                    if service_type is not provided."},{"line_number":114,"context_line":"        :param string interface: The exposure of the endpoint. Should be"},{"line_number":115,"context_line":"                                 `public`, `internal`, `admin` or `auth`."},{"line_number":116,"context_line":"                                 Defaults to `public`."},{"line_number":117,"context_line":"        :param string region_name: The region the endpoint should exist in."},{"line_number":118,"context_line":"                                   (optional)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_43ae5e99","line":115,"updated":"2014-07-11 15:50:29.000000000","message":"(NIT): there should be a comma after `admin`","commit_id":"04bcffac8554b7611a6f24159ff5a54dd4a0e90d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cfe030d9ae1e1ecfb0b0a5f98bc246939a6b632d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                    for. This plugin will return None (failure)"},{"line_number":113,"context_line":"                                    if service_type is not provided."},{"line_number":114,"context_line":"        :param string interface: The exposure of the endpoint. Should be"},{"line_number":115,"context_line":"                                 `public`, `internal`, `admin` or `auth`."},{"line_number":116,"context_line":"                                 Defaults to `public`."},{"line_number":117,"context_line":"        :param string region_name: The region the endpoint should exist in."},{"line_number":118,"context_line":"                                   (optional)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_f57abdef","line":115,"in_reply_to":"baada198_43ae5e99","updated":"2014-07-11 19:33:05.000000000","message":"the docstring should say what \u0027auth\u0027 means.","commit_id":"04bcffac8554b7611a6f24159ff5a54dd4a0e90d"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"3332fee3090c8c78ffd5e4505a8d50f4eba7a516","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                    for. This plugin will return None (failure)"},{"line_number":113,"context_line":"                                    if service_type is not provided."},{"line_number":114,"context_line":"        :param string interface: The exposure of the endpoint. Should be"},{"line_number":115,"context_line":"                                 `public`, `internal`, `admin` or `auth`."},{"line_number":116,"context_line":"                                 Defaults to `public`."},{"line_number":117,"context_line":"        :param string region_name: The region the endpoint should exist in."},{"line_number":118,"context_line":"                                   (optional)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_aae44de0","line":115,"in_reply_to":"baada198_f57abdef","updated":"2014-07-13 23:37:20.000000000","message":"Done","commit_id":"04bcffac8554b7611a6f24159ff5a54dd4a0e90d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cfe030d9ae1e1ecfb0b0a5f98bc246939a6b632d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # the auth url then we can ignore the rest of the checks. Typically if"},{"line_number":130,"context_line":"        # you are asking for the auth endpoint it means that there is no"},{"line_number":131,"context_line":"        # catalog to query anyway."},{"line_number":132,"context_line":"        if interface \u003d\u003d \u0027auth\u0027:"},{"line_number":133,"context_line":"            return self.auth_url"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if not service_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_f5c8fd23","line":132,"updated":"2014-07-11 19:33:05.000000000","message":"should this even be a string? how about a special object defined in keystoneclient?\n\n  get_endpoint(interface\u003dkeystoneclient.auth.identity.ADMIN_INTERFACE)\n\n(or keystoneclient.auth.identity.interface.ADMIN)\n\nthen use if interface is ADMIN","commit_id":"04bcffac8554b7611a6f24159ff5a54dd4a0e90d"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"3332fee3090c8c78ffd5e4505a8d50f4eba7a516","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # the auth url then we can ignore the rest of the checks. Typically if"},{"line_number":130,"context_line":"        # you are asking for the auth endpoint it means that there is no"},{"line_number":131,"context_line":"        # catalog to query anyway."},{"line_number":132,"context_line":"        if interface \u003d\u003d \u0027auth\u0027:"},{"line_number":133,"context_line":"            return self.auth_url"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if not service_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_eaa3a59b","line":132,"in_reply_to":"baada198_f5c8fd23","updated":"2014-07-13 23:37:20.000000000","message":"I wasn\u0027t sure, the constant will have to be a string because that\u0027s what public and admin etc are when they are used by the service catalog, but I should probably make an enum like you suggest. \n\nGiven that it should therefore include the ADMIN, PUBLIC etc interfaces and would involve modifying __init__.py can this be a seperate commit?","commit_id":"04bcffac8554b7611a6f24159ff5a54dd4a0e90d"},{"author":{"_account_id":11717,"name":"Ryan Oshima","email":"ryan.oshima@hp.com","username":"RyanOshima"},"change_message_id":"6259fd0d73b3dfd0ed77f065d74f34e49eb39628","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        :return string or None: A valid endpoint URL or None if not available."},{"line_number":128,"context_line":"        \"\"\""},{"line_number":129,"context_line":"        # NOTE(jamielennox): if you specifically ask for requests to be sent to"},{"line_number":130,"context_line":"        # the auth url then we can ignore the rest of the checks. Typically if"},{"line_number":131,"context_line":"        # you are asking for the auth endpoint it means that there is no"},{"line_number":132,"context_line":"        # catalog to query anyway."}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_acf19f02","line":129,"updated":"2014-07-14 23:44:57.000000000","message":"\"if\"-\u003e\"If\"","commit_id":"735ea64bf82507227304f2e1ea8fc0beb151117c"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"399c2d226ff3ff450ece406ebb389c781affc7f1","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        # the auth url then we can ignore the rest of the checks. Typically if"},{"line_number":145,"context_line":"        # you are asking for the auth endpoint it means that there is no"},{"line_number":146,"context_line":"        # catalog to query anyway."},{"line_number":147,"context_line":"        if interface \u003d\u003d \u0027auth\u0027:"},{"line_number":148,"context_line":"            return self.auth_url"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if not service_type:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_ef1ec50c","line":147,"updated":"2014-07-17 01:49:22.000000000","message":"I was expecting this would be a singleton object because it\u0027s not an actual value for the interface. So for example:\n\n(in the class or module or something)\n  AUTH_INTERFACE \u003d object()\n\nthen here:\n  if interface is AUTH_INTERFACE:\n     return self.auth_url","commit_id":"a801bfcf31e2c236a65f62b3bd41c0271ea426c0"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"34c86f3fc45c06f75f9f2e646b3d9c3919b269d5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        # the auth url then we can ignore the rest of the checks. Typically if"},{"line_number":145,"context_line":"        # you are asking for the auth endpoint it means that there is no"},{"line_number":146,"context_line":"        # catalog to query anyway."},{"line_number":147,"context_line":"        if interface \u003d\u003d \u0027auth\u0027:"},{"line_number":148,"context_line":"            return self.auth_url"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if not service_type:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_35c3798b","line":147,"in_reply_to":"baada198_ef1ec50c","updated":"2014-07-18 02:07:04.000000000","message":"Yea, ok - i can see the logic in that. It makes sense given that we might have different endpoint types.","commit_id":"a801bfcf31e2c236a65f62b3bd41c0271ea426c0"}]}