)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c20dd65b8185048ba5f628a5c99e09afc002430d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"EndpointNotFound error rather than return None."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Allow passing kwargs through the base manager functions so that managers"},{"line_number":19,"context_line":"can pass parameters down to the session."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I879adcb25dd373ab4a7b77b6539974e22220aad4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_ae1481e9","line":19,"updated":"2014-07-11 17:12:54.000000000","message":"(NIT): KWARGS change could be a separate change.","commit_id":"262c035548321dd357e0e324fc859b88621afc9b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"aaa2458cdcfd54a9d5839bbef37ced7d93edd6a9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Allow passing kwargs through the base manager functions so that managers"},{"line_number":19,"context_line":"can pass parameters down to the session."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I879adcb25dd373ab4a7b77b6539974e22220aad4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_75b14d8e","line":20,"updated":"2014-07-11 19:49:56.000000000","message":"This needs a bug","commit_id":"262c035548321dd357e0e324fc859b88621afc9b"}],"keystoneclient/base.py":[{"author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"change_message_id":"0d045a48874986cdd2885792516e7b5b57f0fc5e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        :param obj_class: class for constructing the returned objects"},{"line_number":99,"context_line":"            (self.resource_class will be used by default)"},{"line_number":100,"context_line":"        :param body: data that will be encoded as JSON and passed in POST"},{"line_number":101,"context_line":"            request (GET will be sent by default)"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        if body:"},{"line_number":104,"context_line":"            resp, body \u003d self.client.post(url, body\u003dbody, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_6f6059a5","line":101,"updated":"2014-07-15 00:37:15.000000000","message":":param kwargs: ....\nit\u0027s nice to have the description of this additional argument. Same thing for the other methods too.","commit_id":"0a3a329f34ef29e3559cf0d3b8d9abc73a296600"}],"keystoneclient/httpclient.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c20dd65b8185048ba5f628a5c99e09afc002430d","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        if self.auth_token_from_user:"},{"line_number":256,"context_line":"            return self.auth_token_from_user"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def get_endpoint(self, session, interface\u003dNone, **kwargs):"},{"line_number":259,"context_line":"        if interface in (\u0027public\u0027, \u0027auth\u0027):"},{"line_number":260,"context_line":"            return self.auth_url"},{"line_number":261,"context_line":"        elif not self.management_url:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_ce38d5a2","line":258,"updated":"2014-07-11 17:12:54.000000000","message":"Please document the expected behavior of this method, and why the endpoint exception would be raised.  Without a clear documentation there is a risk future change might revert this.\n\nMinor side-question, could this impact anyone? Could this cause something unexpected and now unhandled to occur (e.g. someone was looking for is not none and now gets an exception which breaks their app)?","commit_id":"262c035548321dd357e0e324fc859b88621afc9b"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"bc283bdc030690a29400401d48431cb42b2b4772","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        if self.auth_token_from_user:"},{"line_number":256,"context_line":"            return self.auth_token_from_user"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def get_endpoint(self, session, interface\u003dNone, **kwargs):"},{"line_number":259,"context_line":"        if interface in (\u0027public\u0027, \u0027auth\u0027):"},{"line_number":260,"context_line":"            return self.auth_url"},{"line_number":261,"context_line":"        elif not self.management_url:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_ca37c14b","line":258,"in_reply_to":"baada198_ce38d5a2","updated":"2014-07-15 03:32:01.000000000","message":"Done. \n\nNot in the way it has been called. What would happen before is that the management_url would have been returned even if it was None (unscoped token) and then it would have tried to use that as part of the URL. Remember that this will be called from the session object and not directly by a user.\n\nThis obviously changes the error that will result but if anything makes it more explicit as to why you are getting failures.","commit_id":"262c035548321dd357e0e324fc859b88621afc9b"}],"keystoneclient/v2_0/tenants.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e430d5833b8c9cb4ce6f2c042dc1b4380e87e8e4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # issue it against the auth_url."},{"line_number":122,"context_line":"        try:"},{"line_number":123,"context_line":"            tenant_list \u003d self._list(\u0027/tenants%s\u0027 % query, \u0027tenants\u0027)"},{"line_number":124,"context_line":"        except exceptions.EndpointNotFound:"},{"line_number":125,"context_line":"            endpoint_filter \u003d {\u0027interface\u0027: auth.AUTH_INTERFACE}"},{"line_number":126,"context_line":"            tenant_list \u003d self._list(\u0027/tenants%s\u0027 % query, \u0027tenants\u0027,"},{"line_number":127,"context_line":"                                     endpoint_filter\u003dendpoint_filter)"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_1b0386be","line":124,"updated":"2014-08-12 15:33:49.000000000","message":"Yes Sir ugly indeed! I wonder if we can do this at the base plugin class instead. If no catalog is provided, always use the auth_url. Or try the newly minted API to fetch the catalog separately.","commit_id":"dcc2e6a61c6db3ac48287b449bb35092e4583d4b"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"a84ce8045d5d519b3b8aae6bb03a4494fd3c60bd","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # issue it against the auth_url."},{"line_number":122,"context_line":"        try:"},{"line_number":123,"context_line":"            tenant_list \u003d self._list(\u0027/tenants%s\u0027 % query, \u0027tenants\u0027)"},{"line_number":124,"context_line":"        except exceptions.EndpointNotFound:"},{"line_number":125,"context_line":"            endpoint_filter \u003d {\u0027interface\u0027: auth.AUTH_INTERFACE}"},{"line_number":126,"context_line":"            tenant_list \u003d self._list(\u0027/tenants%s\u0027 % query, \u0027tenants\u0027,"},{"line_number":127,"context_line":"                                     endpoint_filter\u003dendpoint_filter)"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_3bb5a3cf","line":124,"in_reply_to":"baada198_1b0386be","updated":"2014-08-12 18:27:09.000000000","message":"So the problems are that we can\u0027t ask the auth plugin in advance if it has a catalog for me, and that the issue here is more likely to be that it is being used with an unscoped token and so even if i were to fetch the catalog i wouldn\u0027t get anything. Unless you approve my unscoped-catalog blueprint.","commit_id":"dcc2e6a61c6db3ac48287b449bb35092e4583d4b"}],"keystoneclient/v2_0/tokens.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c20dd65b8185048ba5f628a5c99e09afc002430d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            token_ref \u003d self._create(*args, **kwargs)"},{"line_number":58,"context_line":"        except exceptions.EndpointNotFound:"},{"line_number":59,"context_line":"            kwargs[\u0027endpoint_filter\u0027] \u003d {\u0027interface\u0027: \u0027auth\u0027}"},{"line_number":60,"context_line":"            token_ref \u003d self._create(*args, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        return token_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_ee31195b","line":59,"updated":"2014-07-11 17:12:54.000000000","message":"Please comment why this is needed. This is *not* clear without documentation what is going on here and why. What is the benefit of setting the kwargs?","commit_id":"262c035548321dd357e0e324fc859b88621afc9b"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"bc283bdc030690a29400401d48431cb42b2b4772","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            token_ref \u003d self._create(*args, **kwargs)"},{"line_number":58,"context_line":"        except exceptions.EndpointNotFound:"},{"line_number":59,"context_line":"            kwargs[\u0027endpoint_filter\u0027] \u003d {\u0027interface\u0027: \u0027auth\u0027}"},{"line_number":60,"context_line":"            token_ref \u003d self._create(*args, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        return token_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2ad83d1d","line":59,"in_reply_to":"baada198_ee31195b","updated":"2014-07-15 03:32:01.000000000","message":"Done","commit_id":"262c035548321dd357e0e324fc859b88621afc9b"}]}