)]}'
{"keystoneclient/base.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"4cf4e79a7d81ff8445db9b90ba19c47f3ecf1e96","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                    self.collection_key,"},{"line_number":358,"context_line":"                    endpoint_filter\u003d{\u0027interface\u0027: auth.AUTH_INTERFACE})"},{"line_number":359,"context_line":"            else:"},{"line_number":360,"context_line":"                raise"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    @filter_kwargs"},{"line_number":363,"context_line":"    def put(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_d0e29ed4","line":360,"updated":"2014-09-22 14:54:52.000000000","message":"It appears that it is tested if you have \"fallback_to_auth\" set, but now the branch without this is untested. Could this be added? :D","commit_id":"81552a463ae0d3a2aeb715edbac31a094c261ca3"}],"keystoneclient/tests/auth/test_identity_v3.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"62272ffebe8d5b086948c474f9c8dff05778fb77","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    TEST_URL \u003d \u0027%s%s\u0027 % (TEST_ROOT_URL, \u0027v3\u0027)"},{"line_number":29,"context_line":"    TEST_ROOT_ADMIN_URL \u003d \u0027http://127.0.0.1:35357/\u0027"},{"line_number":30,"context_line":"    TEST_ADMIN_URL \u003d \u0027%s%s\u0027 % (TEST_ROOT_ADMIN_URL, \u0027v3\u0027)"},{"line_number":31,"context_line":"    TEST_PASS \u003d \u0027password\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    TEST_SERVICE_CATALOG \u003d [{"},{"line_number":34,"context_line":"        \"endpoints\": [{"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_8729c3f4","line":31,"updated":"2014-09-17 05:24:41.000000000","message":"Unrelated whitespace change on previous line, revert.","commit_id":"cea796679fb8ddce8d9155c421cfbcb72a39624a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"4cf4e79a7d81ff8445db9b90ba19c47f3ecf1e96","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                        username\u003dself.TEST_USER,"},{"line_number":213,"context_line":"                        password\u003dself.TEST_PASS)"},{"line_number":214,"context_line":"        s \u003d session.Session(auth\u003da)"},{"line_number":215,"context_line":"        cs \u003d client.Client(session\u003ds, auth_url\u003dself.TEST_URL)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # As a sanity check on the auth_ref, make sure client has the"},{"line_number":218,"context_line":"        # proper user id, that it fetches the right project response"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_50a06e90","line":215,"updated":"2014-09-22 14:54:52.000000000","message":"nit: I would appretiate if you would use complete words instead of one letter variables.","commit_id":"81552a463ae0d3a2aeb715edbac31a094c261ca3"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"ccdcf47c929fa94a4ea65e3405806bcb818e7cb9","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                        username\u003dself.TEST_USER,"},{"line_number":213,"context_line":"                        password\u003dself.TEST_PASS)"},{"line_number":214,"context_line":"        s \u003d session.Session(auth\u003da)"},{"line_number":215,"context_line":"        cs \u003d client.Client(session\u003ds, auth_url\u003dself.TEST_URL)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # As a sanity check on the auth_ref, make sure client has the"},{"line_number":218,"context_line":"        # proper user id, that it fetches the right project response"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_902c96ad","line":215,"in_reply_to":"da9df570_50a06e90","updated":"2014-09-22 15:52:16.000000000","message":"I usually do, but there are a couple mitigating factors:\n\n1. The \"good\" name is often take by a python package.  That is often the case with client and session.\n2.  Dealing with wordwrap in Python is non trivial and this mitigates  \n3.  If the distance from the declaration to use is as short as this one,  the single letter is sufficient to communicate without obfuscating.","commit_id":"81552a463ae0d3a2aeb715edbac31a094c261ca3"}],"keystoneclient/v3/client.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"e63e4b291f8a7ec7527c4dc070851036fbb19686","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            session \u003d kwargs[\u0027session\u0027]"},{"line_number":125,"context_line":"            if session.auth and session.auth.auth_ref:"},{"line_number":126,"context_line":"                self.auth_ref \u003d session.auth.auth_ref"},{"line_number":127,"context_line":"                self.process_token()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def serialize(self, entity):"},{"line_number":130,"context_line":"        return jsonutils.dumps(entity, sort_keys\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4e09da2f","line":127,"updated":"2014-07-14 23:39:02.000000000","message":"no - this will load all the auth information onto the client object. This is a large part of what i\u0027m trying to avoid. \n\nWhat do you need this for?","commit_id":"bf220ba1d6626b8137f28068f0276f435807cc0c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"89b823668b10993c26552d1f784709e5016cb517","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            session \u003d kwargs[\u0027session\u0027]"},{"line_number":188,"context_line":"            if session.auth and session.auth.auth_ref:"},{"line_number":189,"context_line":"                self.auth_ref \u003d session.auth.auth_ref"},{"line_number":190,"context_line":"                self.process_token()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def serialize(self, entity):"},{"line_number":193,"context_line":"        return jsonutils.dumps(entity, sort_keys\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_16a86876","line":190,"updated":"2014-08-26 20:37:38.000000000","message":"this is a massive part of what we are trying to avoid.\n\nCan you point me to the horizon work that needs this?","commit_id":"afb2dce4d83e4b67bd5ac762bca344e3a1fcbea6"}],"keystoneclient/v3/projects.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"62272ffebe8d5b086948c474f9c8dff05778fb77","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        attributes matching ``**kwargs``."},{"line_number":78,"context_line":"        \"\"\""},{"line_number":79,"context_line":"        kwargs[\u0027base_url\u0027] \u003d \u0027/users/%s\u0027 % base.getid(user) if user else None"},{"line_number":80,"context_line":"        url \u003d self.build_url(dict_args_in_out\u003dkwargs)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if kwargs:"},{"line_number":83,"context_line":"            query \u003d \u0027?%s\u0027 % urllib.parse.urlencode(kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_9ba4beba","line":80,"updated":"2014-09-17 05:24:41.000000000","message":"Is it intentional that you\u0027ve dropped handling of passing domain in and only now support domain_id (since it\u0027ll be part of the kwargs)?\n\nThis looks like it is not compatible with the previous functionality.","commit_id":"cea796679fb8ddce8d9155c421cfbcb72a39624a"}]}