)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"09b5fde40fabe8136f610fb25cd6fd86201d67e1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"because you end up in an infinite loop."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Allow controlling the authenticated parameter on discovery requests."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib5ab0a3a30fe79139b7b5dcaae698438281b6d36"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1abeadc6_641fe608","line":16,"updated":"2014-08-20 22:05:27.000000000","message":"This needs a bug or a blueprint.","commit_id":"64b1d351f4b6c24d05ee38bc3e615ef7f1547ed2"}],"keystoneclient/auth/identity/base.py":[{"author":{"_account_id":8340,"name":"Craig Jellick","email":"craig.jellick@gmail.com","username":"cjellick"},"change_message_id":"065311b7b7ef4b590094709e1697e8ac944660a5","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        return url"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @utils.positional()"},{"line_number":211,"context_line":"    def get_discovery(self, session, url, authenticated\u003dFalse):"},{"line_number":212,"context_line":"        \"\"\"Return the discovery object for a URL."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        Check the session and the plugin cache to see if we have already"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_9bceb659","line":211,"updated":"2014-08-12 15:38:06.000000000","message":"Can the default be None to preserve the existing behavior and allow specific calls to override it to False or would that defeat the purpose?","commit_id":"ae3e86ecf287e842a735da73effc28e35b2c457e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"22cfb5b15fde55883d69b33040dfc8c400280b0a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        return url"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @utils.positional()"},{"line_number":211,"context_line":"    def get_discovery(self, session, url, authenticated\u003dFalse):"},{"line_number":212,"context_line":"        \"\"\"Return the discovery object for a URL."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        Check the session and the plugin cache to see if we have already"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_782f16f6","line":211,"in_reply_to":"baada198_7b7b9b7a","updated":"2014-08-12 22:04:58.000000000","message":"oops, no you are right. Discovery objects are used for all version checking not just for the identity service so we should default to the session default.","commit_id":"ae3e86ecf287e842a735da73effc28e35b2c457e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"0d769b48f5a31ebe134cbf4418f67d90bd7c582a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        return url"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @utils.positional()"},{"line_number":211,"context_line":"    def get_discovery(self, session, url, authenticated\u003dFalse):"},{"line_number":212,"context_line":"        \"\"\"Return the discovery object for a URL."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        Check the session and the plugin cache to see if we have already"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_7b7b9b7a","line":211,"in_reply_to":"baada198_9bceb659","updated":"2014-08-12 18:22:14.000000000","message":"I started with that. In this function though what we are retrieving is a discovery object specifically for use with loading identity plugins, which means querying keystone. \n\nKeystone (unlike other services) will always have / /v2.0 and /v3 unauthenticated. \n\nAlso in a fairly common case, you attach a plugin that does discovery to a session, call get_discovery and the fact there is a plugin means it tries to authenticate by default and you end u in a loop.\n\nGiven those two it seemed to make sense to default it to False, i even considered not exposing the option and just hard setting it to false within the function.","commit_id":"ae3e86ecf287e842a735da73effc28e35b2c457e"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"d1ebf939e72a19ace57f4f73107c8a570cb6e72c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        :param Session session: A session object to discover with."},{"line_number":222,"context_line":"        :param str url: The url to lookup."},{"line_number":223,"context_line":"        :param bool authenticated: Include a token in the discovery call."},{"line_number":224,"context_line":"                                   (optional) Defaults to False."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        :raises: DiscoveryFailure if for some reason the lookup fails."},{"line_number":227,"context_line":"        :raises: HttpError An error from an invalid HTTP response."}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_0dd31038","line":224,"updated":"2014-08-13 17:18:36.000000000","message":"s/False/None\nor\nIf truly want to default to False, then change the default for authenticated at line 211 from None to False :)","commit_id":"2704d5307d5c86c43c1f51527733b8c76501f1d8"}],"keystoneclient/discover.py":[{"author":{"_account_id":8340,"name":"Craig Jellick","email":"craig.jellick@gmail.com","username":"cjellick"},"change_message_id":"065311b7b7ef4b590094709e1697e8ac944660a5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                 service. default: False (optional)"},{"line_number":101,"context_line":"                                 DEPRECATED: use the session object. This is"},{"line_number":102,"context_line":"                                 ignored if a session is provided."},{"line_number":103,"context_line":"        :param bool authenticated: Should a token be used to perform the"},{"line_number":104,"context_line":"                                   initial discovery operations."},{"line_number":105,"context_line":"                                   default: None (as per session default)"},{"line_number":106,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_1be70647","line":103,"updated":"2014-08-12 15:38:06.000000000","message":"Meaning of None should be explained here -use a token if an auth_token is available.","commit_id":"ae3e86ecf287e842a735da73effc28e35b2c457e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"22cfb5b15fde55883d69b33040dfc8c400280b0a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                 service. default: False (optional)"},{"line_number":101,"context_line":"                                 DEPRECATED: use the session object. This is"},{"line_number":102,"context_line":"                                 ignored if a session is provided."},{"line_number":103,"context_line":"        :param bool authenticated: Should a token be used to perform the"},{"line_number":104,"context_line":"                                   initial discovery operations."},{"line_number":105,"context_line":"                                   default: None (as per session default)"},{"line_number":106,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_f547afa2","line":103,"in_reply_to":"baada198_1be70647","updated":"2014-08-12 22:04:58.000000000","message":"Done","commit_id":"ae3e86ecf287e842a735da73effc28e35b2c457e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"149549e19e853907be3185beaf5e3d6ed24d18a2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                 service. default: False (optional)"},{"line_number":101,"context_line":"                                 DEPRECATED: use the session object. This is"},{"line_number":102,"context_line":"                                 ignored if a session is provided."},{"line_number":103,"context_line":"        :param bool authenticated: Should a token be used to perform the"},{"line_number":104,"context_line":"                                   initial discovery operations."},{"line_number":105,"context_line":"                                   default: None (attach a token if an auth"},{"line_number":106,"context_line":"                                   plugin is available)."}],"source_content_type":"text/x-python","patch_set":13,"id":"1abeadc6_1409d22b","line":103,"updated":"2014-08-21 23:42:35.000000000","message":"should use bool or boolean consistently","commit_id":"9cc2f7c73e92ae6c6b4fbf19272bb2f9209f45e7"}],"keystoneclient/tests/test_discovery.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"09b5fde40fabe8136f610fb25cd6fd86201d67e1","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                                   text\u003dV3_VERSION_LIST)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        token \u003d uuid.uuid4().hex"},{"line_number":574,"context_line":"        a \u003d token_endpoint.Token(\u0027http://testurl\u0027, token)"},{"line_number":575,"context_line":"        s \u003d session.Session(auth\u003da)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        discover.Discover(s, auth_url\u003dBASE_URL, authenticated\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1abeadc6_0425525b","line":574,"updated":"2014-08-20 22:05:27.000000000","message":"there\u0027s a lot of duplication between these 2 tests. create a function and share it.","commit_id":"64b1d351f4b6c24d05ee38bc3e615ef7f1547ed2"}]}