)]}'
{"keystoneclient/httpclient.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"109a469c9373aea945f9c706f8d12b784f3afa49","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    keyring_v \u003d pkg_resources.parse_version("},{"line_number":34,"context_line":"        pkg_resources.get_distribution(\"keyring\").version)"},{"line_number":35,"context_line":"    keyring_min \u003d pkg_resources.parse_version(\u00272.1\u0027)"},{"line_number":36,"context_line":"    keyring_bad \u003d (pkg_resources.parse_version(\u00273.3\u0027),)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if keyring_v \u003e\u003d keyring_min and keyring_v not in keyring_bad:"},{"line_number":39,"context_line":"        import keyring"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_7c5df547","line":36,"updated":"2014-07-17 14:51:28.000000000","message":"I don\u0027t like this, but it should be fine. However, if a distro only offers a _bad_ version, keyring support wont work.\n\nWe might want to find an alternative to keyring.","commit_id":"f0bea74664e7d6404eaacc8dc5257eb060d6c793"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"8b8176ccde664531ad17a41b828b36272b59ab41","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    if keyring_v \u003e\u003d keyring_min and keyring_v not in keyring_bad:"},{"line_number":39,"context_line":"        import keyring"},{"line_number":40,"context_line":"    else:"},{"line_number":41,"context_line":"        keyring \u003d None"},{"line_number":42,"context_line":"except (ImportError, pkg_resources.DistributionNotFound):"},{"line_number":43,"context_line":"    keyring \u003d None"},{"line_number":44,"context_line":"    pickle \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_e35ddded","line":41,"updated":"2014-07-17 17:13:01.000000000","message":"If keyring version is the bad version, we should inform user as oppose to keeping it silent.","commit_id":"cca1e40e50855d9d01a72c87013ef15a3c02bc0f"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"c371acca6f83a34c7821917605b35eefebd1c7df","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    if keyring_v \u003e\u003d keyring_min and keyring_v not in keyring_bad:"},{"line_number":39,"context_line":"        import keyring"},{"line_number":40,"context_line":"    else:"},{"line_number":41,"context_line":"        keyring \u003d None"},{"line_number":42,"context_line":"except (ImportError, pkg_resources.DistributionNotFound):"},{"line_number":43,"context_line":"    keyring \u003d None"},{"line_number":44,"context_line":"    pickle \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_49971c90","line":41,"in_reply_to":"baada198_d7524f34","updated":"2014-07-21 18:40:57.000000000","message":"Agreed on the subsequent patch idea.","commit_id":"cca1e40e50855d9d01a72c87013ef15a3c02bc0f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9f857ff911d1868e008cfb26ec9d948eb12f746a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    if keyring_v \u003e\u003d keyring_min and keyring_v not in keyring_bad:"},{"line_number":39,"context_line":"        import keyring"},{"line_number":40,"context_line":"    else:"},{"line_number":41,"context_line":"        keyring \u003d None"},{"line_number":42,"context_line":"except (ImportError, pkg_resources.DistributionNotFound):"},{"line_number":43,"context_line":"    keyring \u003d None"},{"line_number":44,"context_line":"    pickle \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d7524f34","line":41,"in_reply_to":"baada198_e35ddded","updated":"2014-07-17 19:05:09.000000000","message":"we established a logging ref at this point, but that\u0027d be a great subsequent patch","commit_id":"cca1e40e50855d9d01a72c87013ef15a3c02bc0f"}]}
