)]}'
{"id":"openstack%2Fpython-keystoneclient~108106","triplet_id":"openstack%2Fpython-keystoneclient~master~I010fb243a5403940127d391c3e3864cdb88aac07","project":"openstack/python-keystoneclient","branch":"master","topic":"v3_default","hashtags":[],"change_id":"I010fb243a5403940127d391c3e3864cdb88aac07","subject":"Prefer identity api V3 over v2 in auth_token","status":"ABANDONED","created":"2014-07-18 17:29:02.000000000","updated":"2014-07-21 15:22:31.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2208e36466622857d799b1ec529cdeba2aacf306","_number":108106,"virtual_id_number":108106,"owner":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-07-18 20:16:42.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"disliked":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2014-07-18 17:43:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":-1,"date":"2014-07-18 22:43:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":-1,"date":"2014-07-18 22:43:07.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-07-18 17:43:36.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2014-07-18 20:16:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a90924d95c48d32e48c2dc2f457c4eace40f243c","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2014-07-18 17:29:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6335434c11243776d789f1c5decb111c358d0bd2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-18 17:29:03.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5916285676d89392b060c8716cb55245fbe25fe8","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-07-18 17:43:36.000000000","message":"Patch Set 1: Code-Review-2\n\nHi Sam,\n\nThanks for proposing this, but the code in python-keystoneclient\u0027s middleware repository is considered frozen (security maintenance only and deprecated). You can see the details of this in the spec used for splitting out the keystonemiddleware: https://github.com/openstack/keystone-specs/blob/master/specs/keystonemiddleware/audit-middleware.rst\n\nAll future development will be based on keystonemiddleware (and all projects are in process of being converted over). The keystonemiddleware.auth_token package will remain compatible with previous release of OpenStack and therefore can be used by deployments on older releases of OpenStack (the same way we endeavor to keep the python-keystoneclient library compatible).\n\nIf you think this really is a required change, I am 100% open to discussing this and considering it for inclusion in keystoneclient, provided we have solid justification.\n\nThanks and feel free to hit me up here (in comments) or IRC if you want to discuss this change further.","accounts_in_message":[],"_revision_number":1},{"id":"da593c174a33603826df9c3a4163d965beecf125","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-18 20:16:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/06/108106/1/check/gate-python-keystoneclient-pep8/cff8a18 : SUCCESS in 2m 38s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/06/108106/1/check/gate-python-keystoneclient-docs/5ca219d/doc/build/html/ : SUCCESS in 3m 19s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/06/108106/1/check/gate-python-keystoneclient-python26/bab6246 : SUCCESS in 3m 23s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/06/108106/1/check/gate-python-keystoneclient-python27/8a58fb7 : SUCCESS in 2m 37s\n- check-tempest-dsvm-full http://logs.openstack.org/06/108106/1/check/check-tempest-dsvm-full/4cf6285 : SUCCESS in 34m 35s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/06/108106/1/check/check-tempest-dsvm-postgres-full/17ee7e1 : SUCCESS in 37m 35s\n- check-tempest-dsvm-neutron http://logs.openstack.org/06/108106/1/check/check-tempest-dsvm-neutron/a386bfc : SUCCESS in 54m 40s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/06/108106/1/check/check-tempest-dsvm-neutron-heat-slow/4cdeff7 : SUCCESS in 23m 30s\n- check-grenade-dsvm http://logs.openstack.org/06/108106/1/check/check-grenade-dsvm/8d9096f : SUCCESS in 31m 42s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/06/108106/1/check/check-tempest-dsvm-full-havana/752e6df : FAILURE in 11m 44s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/06/108106/1/check/check-tempest-dsvm-neutron-havana/6b5e564 : FAILURE in 12m 32s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/06/108106/1/check/check-tempest-dsvm-full-icehouse/7c0cd13 : SUCCESS in 51m 41s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/06/108106/1/check/check-tempest-dsvm-neutron-icehouse/c7c6f0d : SUCCESS in 57m 11s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/06/108106/1/check/gate-python-keystoneclient-python33/d7a3028 : SUCCESS in 4m 38s\n- check-devstack-dsvm-cells http://logs.openstack.org/06/108106/1/check/check-devstack-dsvm-cells/21f5f70 : SUCCESS in 18m 09s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/06/108106/1/check/gate-tempest-dsvm-large-ops/98d9455 : SUCCESS in 24m 51s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/06/108106/1/check/gate-tempest-dsvm-neutron-large-ops/4751f16 : SUCCESS in 25m 08s","accounts_in_message":[],"_revision_number":1},{"id":"402cce948b101fd6bc300e0515517732e81da97b","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-07-18 22:23:51.000000000","message":"Patch Set 1:\n\nFor anyone confused by my comment pointing to the audit-middleware spec, here is the real spec on split repos:\n\nhttps://github.com/openstack/keystone-specs/blob/master/specs/keystonemiddleware/split-middleware-repo.rst","accounts_in_message":[],"_revision_number":1},{"id":"8b12fbbfc5b93336713fd68c58c1463a90c83995","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2014-07-18 22:43:07.000000000","message":"Patch Set 1: Code-Review-1 Workflow-1\n\nAppreciate for Morgan\u0027s comments and that totally makes sense.\n\nIn fact, we just found out the services like, nova/neutron/glance have all been updated to use keystonemiddleware, and few others are pending review. So seems like we got what we need so far.","accounts_in_message":[],"_revision_number":1},{"id":"87b62fca0f065b3bb12869e8f9328a310296d21b","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-07-21 15:22:27.000000000","message":"Patch Set 1:\n\nBased upon my conversation w/ Sam and the information in this review, I\u0027ll mark this as abandoned.\n\nIt can be restored if we need to restore it (Sam or any Keystone Core can restore the patch).","accounts_in_message":[],"_revision_number":1},{"id":"6ea5d0b2746a66810fc0e1388de6e04d143954c8","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-07-21 15:22:31.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"478095b02e4e2abc7e8bc81a33e5225ed07fbc80","revisions":{"478095b02e4e2abc7e8bc81a33e5225ed07fbc80":{"kind":"REWORK","_number":1,"created":"2014-07-18 17:29:02.000000000","uploader":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"ref":"refs/changes/06/108106/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/06/108106/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/06/108106/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/06/108106/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/06/108106/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/06/108106/1"}}},"commit":{"parents":[{"commit":"679689f70748b1b28a14ecd29161f98881d80662","subject":"Merge \"Sync with oslo-incubator fd90c34a9\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/679689f70748b1b28a14ecd29161f98881d80662"}]}],"author":{"name":"chioleong","email":"chio-fai-sam.leong@hp.com","date":"2014-07-18 17:08:36.000000000","tz":-420},"committer":{"name":"chioleong","email":"chio-fai-sam.leong@hp.com","date":"2014-07-18 17:26:48.000000000","tz":-420},"subject":"Prefer identity api V3 over v2 in auth_token","message":"Prefer identity api V3 over v2 in auth_token\n\nThis reverses the default order of preference between v2 and v3 to use\nv3 by default if both are available.\n\nThis is basically making the same change as the recent merge in the\nmiddleware package. As the openstack services are still using this\nkeystone client middleware, making the corresponding change may need.\n\nChange-Id: I010fb243a5403940127d391c3e3864cdb88aac07\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/478095b02e4e2abc7e8bc81a33e5225ed07fbc80"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/478095b02e4e2abc7e8bc81a33e5225ed07fbc80"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}