)]}'
{"keystoneclient/contrib/auth/v3/saml2.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"5751366eed1fafb0454b1fcd1fab96bf19afbf78","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_endpoint(self, session, service_type\u003dNone, interface\u003dNone,"},{"line_number":305,"context_line":"                     region_name\u003dNone, service_name\u003dNone, version\u003dNone,"},{"line_number":306,"context_line":"                     **kwargs):"},{"line_number":307,"context_line":"        interface \u003d auth_base.AUTH_INTERFACE"},{"line_number":308,"context_line":"        return super(Saml2UnscopedToken, self).get_endpoint("},{"line_number":309,"context_line":"            session, service_type\u003dservice_type, interface\u003dinterface,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_0a2a877d","line":306,"updated":"2014-07-26 08:16:19.000000000","message":"from keystoneclient import auth\n\n    get_endpoint(self, *args, **kwargs):\n        kwargs.setdefault(\u0027interface\u0027, auth.AUTH_INTERFACE)  # or should it just override?\n        return super(Saml2UnscopedToken, self).get_endpoint(*args, **kwargs)","commit_id":"16e1c8cbe7cdb7cd6af60be63f40a44263e77f63"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"50d40f8ccbe5ed3f409525d7547ff7fd1d8dac14","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_endpoint(self, session, service_type\u003dNone, interface\u003dNone,"},{"line_number":305,"context_line":"                     region_name\u003dNone, service_name\u003dNone, version\u003dNone,"},{"line_number":306,"context_line":"                     **kwargs):"},{"line_number":307,"context_line":"        interface \u003d auth_base.AUTH_INTERFACE"},{"line_number":308,"context_line":"        return super(Saml2UnscopedToken, self).get_endpoint("},{"line_number":309,"context_line":"            session, service_type\u003dservice_type, interface\u003dinterface,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c5dec069","line":306,"in_reply_to":"baada198_0a2a877d","updated":"2014-07-26 12:45:53.000000000","message":"nice, changing now!","commit_id":"16e1c8cbe7cdb7cd6af60be63f40a44263e77f63"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"0cd1fd529f552e3d9bd1afd8056525481ffad7ac","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_endpoint(self, session, service_type\u003dNone, interface\u003dNone,"},{"line_number":305,"context_line":"                     region_name\u003dNone, service_name\u003dNone, version\u003dNone,"},{"line_number":306,"context_line":"                     **kwargs):"},{"line_number":307,"context_line":"        interface \u003d auth_base.AUTH_INTERFACE"},{"line_number":308,"context_line":"        return super(Saml2UnscopedToken, self).get_endpoint("},{"line_number":309,"context_line":"            session, service_type\u003dservice_type, interface\u003dinterface,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a5baac08","line":306,"in_reply_to":"baada198_c5dec069","updated":"2014-07-26 12:53:40.000000000","message":"i can risk this implementation, but I am fearing somebody, one day may want to pass default get_endpoint() values, which means interface\u003dNone, which will cause undesired behaviour (namely exception raised)","commit_id":"16e1c8cbe7cdb7cd6af60be63f40a44263e77f63"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d5ecd051e1856a5d16bc8d40072cf0e5c939a5b1","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    def get_endpoint(self, *args, **kwargs):"},{"line_number":305,"context_line":"        kwargs.setdefault(\u0027interface\u0027, base.AUTH_INTERFACE)"},{"line_number":306,"context_line":"        return super(Saml2UnscopedToken, self).get_endpoint(*args, **kwargs)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @property"},{"line_number":309,"context_line":"    def token_url(self):"},{"line_number":310,"context_line":"        \"\"\"Return full URL where authorization data is sent.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_2cb67689","line":307,"updated":"2014-07-28 08:38:29.000000000","message":"Nah, this will pass default interface value which is None so setdefault() will not work in here.\nI suggest reverting the change to the previous version. I would also keep arguments so we exactly know what is passed.","commit_id":"403bff96449b7e189e40706ad79a81888cd569bd"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"944c06c2e8e200896afcc89741d5b506895a2626","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    def get_endpoint(self, session, service_type\u003dNone, interface\u003dNone,"},{"line_number":305,"context_line":"                     region_name\u003dNone, service_name\u003dNone, version\u003dNone,"},{"line_number":306,"context_line":"                     **kwargs):"},{"line_number":307,"context_line":"        interface \u003d auth_base.AUTH_INTERFACE"},{"line_number":308,"context_line":"        return super(Saml2UnscopedToken, self).get_endpoint("},{"line_number":309,"context_line":"            session, service_type\u003dservice_type, interface\u003dinterface,"},{"line_number":310,"context_line":"            region_name\u003dregion_name, service_name\u003dservice_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_5b3070e9","line":307,"updated":"2014-07-29 21:22:35.000000000","message":"you could have used\n\nkwargs[\u0027interface\u0027] \u003d auth_base.AUTH_INTERFACE\n\nwhich was what i meant by you might need to override interface.\n\nThe problem here is that you are creating values for those named kwargs and so setdefault won\u0027t work further down. I don\u0027t think that in this case it matters.","commit_id":"298e1b062a15e9fe2fb8d2ec332a9100dbd6dcb6"}]}