)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"edfae53a508df4cd73e6d722a3593b83a6d6f8d0","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"SecurityImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1004114"},{"line_number":19,"context_line":"Closes-Bug: #1327019"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I1edc3821ed028471102cc9b95eb9f3b54c9e2778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_20ac6336","line":18,"updated":"2014-07-30 00:50:39.000000000","message":"partial-bug? Doesn\u0027t seem like we\u0027ve address all the issues in that bug.","commit_id":"bc0962167248a7c5a50ae19a530f54b558f611bf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"176950830daf0bbabfeffa73ee2a900b703fa48b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"SecurityImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1004114"},{"line_number":19,"context_line":"Closes-Bug: #1327019"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I1edc3821ed028471102cc9b95eb9f3b54c9e2778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_b836c7e6","line":18,"in_reply_to":"baada198_20ac6336","updated":"2014-07-30 20:12:55.000000000","message":"This should take care of it for keystoneclient.","commit_id":"bc0962167248a7c5a50ae19a530f54b558f611bf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"edfae53a508df4cd73e6d722a3593b83a6d6f8d0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"SecurityImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1004114"},{"line_number":19,"context_line":"Closes-Bug: #1327019"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I1edc3821ed028471102cc9b95eb9f3b54c9e2778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_40a95724","line":19,"updated":"2014-07-30 00:50:39.000000000","message":"same as above","commit_id":"bc0962167248a7c5a50ae19a530f54b558f611bf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"176950830daf0bbabfeffa73ee2a900b703fa48b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"SecurityImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1004114"},{"line_number":19,"context_line":"Closes-Bug: #1327019"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I1edc3821ed028471102cc9b95eb9f3b54c9e2778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_584dab70","line":19,"in_reply_to":"baada198_40a95724","updated":"2014-07-30 20:12:55.000000000","message":"This should take care of it for keystoneclient.","commit_id":"bc0962167248a7c5a50ae19a530f54b558f611bf"}],"keystoneclient/session.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"edfae53a508df4cd73e6d722a3593b83a6d6f8d0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        def process_header(header):"},{"line_number":143,"context_line":"            if header[0].lower() in (\u0027x-auth-token\u0027, \u0027x-subject-token\u0027):"},{"line_number":144,"context_line":"                return (header[0], \u0027TOKEN_REDACTED\u0027)"},{"line_number":145,"context_line":"            return header"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        string_parts \u003d [\u0027REQ: curl -i\u0027]"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_407077da","line":145,"updated":"2014-07-30 00:50:39.000000000","message":"We only care about these these two headers? What about others? i.e. \"Authorizaton\" header for basic auth.","commit_id":"bc0962167248a7c5a50ae19a530f54b558f611bf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"176950830daf0bbabfeffa73ee2a900b703fa48b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        def process_header(header):"},{"line_number":143,"context_line":"            if header[0].lower() in (\u0027x-auth-token\u0027, \u0027x-subject-token\u0027):"},{"line_number":144,"context_line":"                return (header[0], \u0027TOKEN_REDACTED\u0027)"},{"line_number":145,"context_line":"            return header"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        string_parts \u003d [\u0027REQ: curl -i\u0027]"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b8ab27d6","line":145,"in_reply_to":"baada198_407077da","updated":"2014-07-30 20:12:55.000000000","message":"I\u0027ll also add authorization. Done.","commit_id":"bc0962167248a7c5a50ae19a530f54b558f611bf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"edfae53a508df4cd73e6d722a3593b83a6d6f8d0","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        if json:"},{"line_number":163,"context_line":"            data \u003d jsonutils.dumps(json)"},{"line_number":164,"context_line":"        if data:"},{"line_number":165,"context_line":"            string_parts.append(\"-d \u0027%s\u0027\" % data)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        _logger.debug(\u0027 \u0027.join(string_parts))"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a02dd3b0","line":165,"updated":"2014-07-30 00:50:39.000000000","message":"There\u0027s all kinds of stuff in the request body. Like username, password, access key, etc. Are we doing anything to scrub them?","commit_id":"bc0962167248a7c5a50ae19a530f54b558f611bf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"176950830daf0bbabfeffa73ee2a900b703fa48b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        if json:"},{"line_number":163,"context_line":"            data \u003d jsonutils.dumps(json)"},{"line_number":164,"context_line":"        if data:"},{"line_number":165,"context_line":"            string_parts.append(\"-d \u0027%s\u0027\" % data)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        _logger.debug(\u0027 \u0027.join(string_parts))"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_bbc6c148","line":165,"in_reply_to":"baada198_a02dd3b0","updated":"2014-07-30 20:12:55.000000000","message":"The change to handle fields in the request body is https://review.openstack.org/#/c/101792/ .","commit_id":"bc0962167248a7c5a50ae19a530f54b558f611bf"}]}