)]}'
{"id":"openstack%2Fpython-keystoneclient~112752","triplet_id":"openstack%2Fpython-keystoneclient~master~I0422b11bb4a9d28baa4c3ef8c81b43972c1766d0","project":"openstack/python-keystoneclient","branch":"master","topic":"isolate-then-hack","hashtags":[],"change_id":"I0422b11bb4a9d28baa4c3ef8c81b43972c1766d0","subject":"[WIP] Add template hacks to identity plugins","status":"ABANDONED","created":"2014-08-08 03:07:21.000000000","updated":"2014-12-15 22:03:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c13036750959fb0445b2a18931ba31e2b81b295c","_number":112752,"virtual_id_number":112752,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2014-09-11 04:47:26.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2014-09-03 23:31:01.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-11 04:47:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"921c43a96314ad1ecc4664d4bcee737db69c73fb","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-08-08 03:07:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"49c8291fb582472eea54e6a764b7d8c5a8fd8ba3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-08 03:07:22.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"fcbc5f29b210423dfc34295d4af08c102c6b9be1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-08 04:05:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/52/112752/1/check/gate-python-keystoneclient-pep8/cbf3823 : SUCCESS in 2m 41s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/52/112752/1/check/gate-python-keystoneclient-docs/c02bc51/doc/build/html/ : SUCCESS in 3m 41s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/52/112752/1/check/gate-python-keystoneclient-python26/01b7077 : SUCCESS in 2m 04s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/52/112752/1/check/gate-python-keystoneclient-python27/1176dac : SUCCESS in 2m 42s\n- check-tempest-dsvm-full http://logs.openstack.org/52/112752/1/check/check-tempest-dsvm-full/23a8bc5 : SUCCESS in 43m 54s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/52/112752/1/check/check-tempest-dsvm-postgres-full/93d1392 : SUCCESS in 54m 40s\n- check-tempest-dsvm-neutron http://logs.openstack.org/52/112752/1/check/check-tempest-dsvm-neutron/c9854ef : SUCCESS in 58m 20s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/52/112752/1/check/check-tempest-dsvm-neutron-heat-slow/1c36df9 : SUCCESS in 26m 00s\n- check-grenade-dsvm http://logs.openstack.org/52/112752/1/check/check-grenade-dsvm/ae15eea : SUCCESS in 40m 56s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/52/112752/1/check/gate-tempest-dsvm-large-ops/1f8c6a1 : SUCCESS in 23m 57s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/52/112752/1/check/gate-tempest-dsvm-neutron-large-ops/b156713 : SUCCESS in 24m 45s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/52/112752/1/check/check-tempest-dsvm-full-havana/cfc4cdb : SUCCESS in 32m 29s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/52/112752/1/check/check-tempest-dsvm-neutron-havana/00c2780 : SUCCESS in 33m 32s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/52/112752/1/check/check-tempest-dsvm-full-icehouse/ebdee36 : SUCCESS in 52m 00s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/52/112752/1/check/check-tempest-dsvm-neutron-icehouse/6f0aebb : SUCCESS in 55m 01s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/52/112752/1/check/gate-python-keystoneclient-python33/efe1b23 : SUCCESS in 8m 33s\n- check-devstack-dsvm-cells http://logs.openstack.org/52/112752/1/check/check-devstack-dsvm-cells/91878d1 : SUCCESS in 12m 50s","accounts_in_message":[],"_revision_number":1},{"id":"1d8d7e36f4e91f60bf4946cb4d9983753eefd8fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-22 07:19:51.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"b8b82195a0d20590dd7d1ee44bf153a6657042cb","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-08-26 04:07:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bc0a9bb16da27e04506d7b1c58fbedab2a67b3ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-26 06:07:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/52/112752/2/check/gate-python-keystoneclient-pep8/89d19b5 : SUCCESS in 3m 15s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/52/112752/2/check/gate-python-keystoneclient-docs/d9e4882/doc/build/html/ : SUCCESS in 3m 48s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/52/112752/2/check/gate-python-keystoneclient-python26/35c4f3d : SUCCESS in 3m 30s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/52/112752/2/check/gate-python-keystoneclient-python27/ddba996 : SUCCESS in 3m 11s\n- check-tempest-dsvm-full http://logs.openstack.org/52/112752/2/check/check-tempest-dsvm-full/977c4b5 : SUCCESS in 45m 26s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/52/112752/2/check/check-tempest-dsvm-postgres-full/c6102e0 : SUCCESS in 54m 46s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/52/112752/2/check/check-tempest-dsvm-neutron-full/645185c : SUCCESS in 53m 23s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/52/112752/2/check/check-tempest-dsvm-neutron-heat-slow/ab84fec : SUCCESS in 21m 03s\n- check-grenade-dsvm http://logs.openstack.org/52/112752/2/check/check-grenade-dsvm/b0044bb : SUCCESS in 40m 14s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/52/112752/2/check/gate-tempest-dsvm-large-ops/6390406 : SUCCESS in 27m 44s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/52/112752/2/check/gate-tempest-dsvm-neutron-large-ops/dddf051 : SUCCESS in 18m 12s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/52/112752/2/check/check-tempest-dsvm-full-havana/3eaa156 : SUCCESS in 40m 28s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/52/112752/2/check/check-tempest-dsvm-neutron-havana/2a6bfa9 : SUCCESS in 32m 15s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/52/112752/2/check/check-tempest-dsvm-full-icehouse/42fd398 : SUCCESS in 50m 45s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/52/112752/2/check/check-tempest-dsvm-neutron-icehouse/e1b0536 : SUCCESS in 56m 11s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/52/112752/2/check/gate-python-keystoneclient-python33/6eca8e8 : SUCCESS in 5m 56s\n- check-devstack-dsvm-cells http://logs.openstack.org/52/112752/2/check/check-devstack-dsvm-cells/909c727 : SUCCESS in 17m 51s","accounts_in_message":[],"_revision_number":2},{"id":"5104eeada36bf1c4062e9d10748ed589f91cf40f","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-09-03 23:31:01.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"0d7f483cd48bdb64dab2c6ab227a70d53e490159","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-11 04:47:26.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"03aa98d111fda5650c9029bb85e89c5238000a8c","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-12-15 22:03:49.000000000","message":"Abandoned\n\nThis change is being abandoned because it has a negative score and has not seen an update in \u003e 60 days. Feel free to re-instate this patch (as the author) by using the \"restore\" button or any member of the core team can re-instate the patch.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1b436651e61f08d5c380854debf8d2485403eddd","revisions":{"83458088cbe4a1307a4ac2dd98a6d914f05cece4":{"kind":"REWORK","_number":1,"created":"2014-08-08 03:07:21.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/52/112752/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/52/112752/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/112752/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/112752/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/112752/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/112752/1"}}},"commit":{"parents":[{"commit":"14300430e98c7a10524b2326b7df63d617749348","subject":"Versioned Endpoint hack for Sessions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/14300430e98c7a10524b2326b7df63d617749348"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-08 03:02:53.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-08 03:02:53.000000000","tz":600},"subject":"[WIP] Add template hacks to identity plugins","message":"[WIP] Add template hacks to identity plugins\n\nSo the dependant patch is able to replace any part of a URL to make it\nsuitable for discovery. That is the teardown phase.\n\nThis is the reverse. For some URLs eg compute, swift etc there is a\ntenant_id as part of the URL. Therefore after we\u0027ve done discovery and\ngotten the base versioned URL we need to be able to add back some\ninformation to the URL.\n\nI can\u0027t quite put my finger on it but something smells off here. It\nfeels like there should be more connection between the removal and\naddition back process, but i can\u0027t see why.\n\nChange-Id: I0422b11bb4a9d28baa4c3ef8c81b43972c1766d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/83458088cbe4a1307a4ac2dd98a6d914f05cece4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/83458088cbe4a1307a4ac2dd98a6d914f05cece4"}]},"branch":"refs/heads/master"},"1b436651e61f08d5c380854debf8d2485403eddd":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2014-08-26 04:07:20.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/52/112752/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/52/112752/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/112752/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/112752/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/112752/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/112752/2"}}},"commit":{"parents":[{"commit":"b88e3e066e7994f17961916afc9bec8a7b9b6230","subject":"Versioned Endpoint hack for Sessions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b88e3e066e7994f17961916afc9bec8a7b9b6230"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-08 03:02:53.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-26 04:06:48.000000000","tz":600},"subject":"[WIP] Add template hacks to identity plugins","message":"[WIP] Add template hacks to identity plugins\n\nSo the dependant patch is able to replace any part of a URL to make it\nsuitable for discovery. That is the teardown phase.\n\nThis is the reverse. For some URLs eg compute, swift etc there is a\ntenant_id as part of the URL. Therefore after we\u0027ve done discovery and\ngotten the base versioned URL we need to be able to add back some\ninformation to the URL.\n\nI can\u0027t quite put my finger on it but something smells off here. It\nfeels like there should be more connection between the removal and\naddition back process, but i can\u0027t see why.\n\nChange-Id: I0422b11bb4a9d28baa4c3ef8c81b43972c1766d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1b436651e61f08d5c380854debf8d2485403eddd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1b436651e61f08d5c380854debf8d2485403eddd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}