)]}'
{"keystoneclient/access.py":[{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"0a387869086101aafc08868e746ea3d5655163a9","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                # NOTE(jamielennox): already installed auth_token don\u0027t need"},{"line_number":57,"context_line":"                # to do it again below so reset to None."},{"line_number":58,"context_line":"                auth_token \u003d None"},{"line_number":59,"context_line":"            elif AccessInfoV2.is_valid(body, **kwargs):"},{"line_number":60,"context_line":"                if body:"},{"line_number":61,"context_line":"                    if region_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_81865c14","line":58,"updated":"2014-08-12 07:51:31.000000000","message":"I think we can directly return for V3 case like before. If so this line can be deleted.","commit_id":"25141defd30163188c946d1128e6361eac689732"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"73d5ea04ae8102f017aafd43b2bd80b19baba281","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                # NOTE(jamielennox): already installed auth_token don\u0027t need"},{"line_number":57,"context_line":"                # to do it again below so reset to None."},{"line_number":58,"context_line":"                auth_token \u003d None"},{"line_number":59,"context_line":"            elif AccessInfoV2.is_valid(body, **kwargs):"},{"line_number":60,"context_line":"                if body:"},{"line_number":61,"context_line":"                    if region_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_9f676524","line":58,"in_reply_to":"baada198_81865c14","updated":"2014-08-13 03:44:35.000000000","message":"Done","commit_id":"25141defd30163188c946d1128e6361eac689732"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"3379771dbb9d1341b898cbc87d71b1f04da87052","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        auth_ref \u003d None"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if body is not None or len(kwargs):"},{"line_number":46,"context_line":"            if AccessInfoV3.is_valid(body, **kwargs):"},{"line_number":47,"context_line":"                if resp and not auth_token:"},{"line_number":48,"context_line":"                    auth_token \u003d resp.headers[\u0027X-Subject-Token\u0027]"},{"line_number":49,"context_line":"                # NOTE(jamielennox): these return AccessInfo because they"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_31045349","line":46,"updated":"2014-08-20 19:24:32.000000000","message":"this code would be much simpler if is_valid returned false for both body \u003d\u003d None and len(kwargs)  \u003d\u003d 0","commit_id":"0a0373142c9227457251c852ede94998f3797a42"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"19e5b56e9e7c46c1b4153795f271647e7b732c31","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        auth_ref \u003d None"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if body is not None or len(kwargs):"},{"line_number":46,"context_line":"            if AccessInfoV3.is_valid(body, **kwargs):"},{"line_number":47,"context_line":"                if resp and not auth_token:"},{"line_number":48,"context_line":"                    auth_token \u003d resp.headers[\u0027X-Subject-Token\u0027]"},{"line_number":49,"context_line":"                # NOTE(jamielennox): these return AccessInfo because they"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_4143b76b","line":46,"in_reply_to":"1abeadc6_31045349","updated":"2014-08-21 01:01:06.000000000","message":"it will. I think the initial purpose here was that if you submit something and it\u0027s not a v2 or v3 then you get a NotImplementedError\n\nIf you submit nothing then it will essentially return an empty dict which is dumb but it\u0027s how it works.","commit_id":"0a0373142c9227457251c852ede94998f3797a42"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"3379771dbb9d1341b898cbc87d71b1f04da87052","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            else:"},{"line_number":65,"context_line":"                raise NotImplementedError(\u0027Unrecognized auth response\u0027)"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            auth_ref \u003d AccessInfoV2(**kwargs)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if auth_token:"},{"line_number":70,"context_line":"            auth_ref.auth_token \u003d auth_token"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_f1b49b83","line":67,"updated":"2014-08-20 19:24:32.000000000","message":"does this make sense?  len(kwargs)  is False from line 45.","commit_id":"0a0373142c9227457251c852ede94998f3797a42"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"19e5b56e9e7c46c1b4153795f271647e7b732c31","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            else:"},{"line_number":65,"context_line":"                raise NotImplementedError(\u0027Unrecognized auth response\u0027)"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            auth_ref \u003d AccessInfoV2(**kwargs)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if auth_token:"},{"line_number":70,"context_line":"            auth_ref.auth_token \u003d auth_token"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_81b22f92","line":67,"in_reply_to":"1abeadc6_f1b49b83","updated":"2014-08-21 01:01:06.000000000","message":"umm, probably not. There is a lot about this function that doesn\u0027t make sense. \n\nIf anything it\u0027s slightly better now because at least we can add an auth_token to it.","commit_id":"0a0373142c9227457251c852ede94998f3797a42"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"779b8e688c1d96bdaaf7b3143e58c2769a992822","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        try:"},{"line_number":420,"context_line":"            return super(AccessInfoV2, self).auth_token"},{"line_number":421,"context_line":"        except KeyError:"},{"line_number":422,"context_line":"            return self[\u0027token\u0027][\u0027id\u0027]"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    @property"},{"line_number":425,"context_line":"    def expires(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_7beeaaee","line":422,"updated":"2014-08-28 00:21:53.000000000","message":"ain\u0027t that kinda dangerous, and confusing? That does it mean if auth_token and self[\u0027token\u0027][\u0027id\u0027] are both present but not equal? Is there a way to enforce consistency?","commit_id":"0a0373142c9227457251c852ede94998f3797a42"}]}