)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"3ebb50635fb60f07bd3c0370a7a75fbd82707080","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Boris Pavlovic \u003cboris@pavlovic.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-24 01:03:29 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add shell --profile option to tirgger osprofiler from CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently only way to trigger osprofiler (tracing) is to use"},{"line_number":10,"context_line":"python-keystoneclient as and python lib. This patch add new option"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da9df570_5cba1c0b","line":7,"updated":"2014-09-23 18:18:27.000000000","message":"trigger","commit_id":"8de86ee4408ec2adc01b7acc8c9f9f4f5d3d47cb"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"3ebb50635fb60f07bd3c0370a7a75fbd82707080","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add shell --profile option to tirgger osprofiler from CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently only way to trigger osprofiler (tracing) is to use"},{"line_number":10,"context_line":"python-keystoneclient as and python lib. This patch add new option"},{"line_number":11,"context_line":"--profile that will do this from CLI."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"So if you have installed osprofiler lib. And you type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da9df570_dc452c18","line":10,"updated":"2014-09-23 18:18:27.000000000","message":"Python","commit_id":"8de86ee4408ec2adc01b7acc8c9f9f4f5d3d47cb"},{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"88d225aa1e4c0928e3d4a7d7b3972d3ca4fe7421","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"So if you have installed osprofiler lib. And you type"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"keystone --profile SECRET_KEY user-lsit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"At the end of output there will be message with \u003ctrace_id\u003e"},{"line_number":18,"context_line":"to plot nice HTML graphs use command:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_f55d407a","line":15,"updated":"2014-09-04 03:44:02.000000000","message":"lsit -\u003e list :)","commit_id":"8de86ee4408ec2adc01b7acc8c9f9f4f5d3d47cb"}],"keystoneclient/shell.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"78bb01759696acf835b4f291a9f7d95f1f37d922","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                                \u0027data for performance profiling of operation. \u0027"},{"line_number":209,"context_line":"                                \u0027This key should be the value of HMAC key \u0027"},{"line_number":210,"context_line":"                                \u0027configured in osprofiler middleware in \u0027"},{"line_number":211,"context_line":"                                \u0027cinder, it specified in paste configuration \u0027"},{"line_number":212,"context_line":"                                \u0027file at /etc/cinder/api-paste.ini. \u0027"},{"line_number":213,"context_line":"                                \u0027Without key the profiling will not be \u0027"},{"line_number":214,"context_line":"                                \u0027triggered even if osprofiler is enabled \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_a2912454","line":211,"updated":"2014-08-19 19:01:08.000000000","message":"cinder?","commit_id":"d5935dd674a05009ac88510033deedf740b0e7ff"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d3bf1c1c50050b8545a7c2df3568db1eeed3a32b","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                                \u0027data for performance profiling of operation. \u0027"},{"line_number":209,"context_line":"                                \u0027This key should be the value of HMAC key \u0027"},{"line_number":210,"context_line":"                                \u0027configured in osprofiler middleware in \u0027"},{"line_number":211,"context_line":"                                \u0027cinder, it specified in paste configuration \u0027"},{"line_number":212,"context_line":"                                \u0027file at /etc/cinder/api-paste.ini. \u0027"},{"line_number":213,"context_line":"                                \u0027Without key the profiling will not be \u0027"},{"line_number":214,"context_line":"                                \u0027triggered even if osprofiler is enabled \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_0db8b20f","line":211,"in_reply_to":"1abeadc6_a2912454","updated":"2014-08-23 20:29:48.000000000","message":"ya, sorry copy paste bug","commit_id":"d5935dd674a05009ac88510033deedf740b0e7ff"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"78bb01759696acf835b4f291a9f7d95f1f37d922","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                                \u0027This key should be the value of HMAC key \u0027"},{"line_number":210,"context_line":"                                \u0027configured in osprofiler middleware in \u0027"},{"line_number":211,"context_line":"                                \u0027cinder, it specified in paste configuration \u0027"},{"line_number":212,"context_line":"                                \u0027file at /etc/cinder/api-paste.ini. \u0027"},{"line_number":213,"context_line":"                                \u0027Without key the profiling will not be \u0027"},{"line_number":214,"context_line":"                                \u0027triggered even if osprofiler is enabled \u0027"},{"line_number":215,"context_line":"                                \u0027on server side.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_e29b1c70","line":212,"updated":"2014-08-19 19:01:08.000000000","message":"?","commit_id":"d5935dd674a05009ac88510033deedf740b0e7ff"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d3bf1c1c50050b8545a7c2df3568db1eeed3a32b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                                \u0027This key should be the value of HMAC key \u0027"},{"line_number":210,"context_line":"                                \u0027configured in osprofiler middleware in \u0027"},{"line_number":211,"context_line":"                                \u0027cinder, it specified in paste configuration \u0027"},{"line_number":212,"context_line":"                                \u0027file at /etc/cinder/api-paste.ini. \u0027"},{"line_number":213,"context_line":"                                \u0027Without key the profiling will not be \u0027"},{"line_number":214,"context_line":"                                \u0027triggered even if osprofiler is enabled \u0027"},{"line_number":215,"context_line":"                                \u0027on server side.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_ad4dfe3f","line":212,"in_reply_to":"1abeadc6_e29b1c70","updated":"2014-08-23 20:29:48.000000000","message":"same here.. sry","commit_id":"d5935dd674a05009ac88510033deedf740b0e7ff"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"3ebb50635fb60f07bd3c0370a7a75fbd82707080","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from keystoneclient import session"},{"line_number":43,"context_line":"from keystoneclient import utils"},{"line_number":44,"context_line":"from keystoneclient.v2_0 import shell as shell_v2_0"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"osprofiler_profiler \u003d importutils.try_import(\"osprofiler.profiler\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_3c1b981c","line":45,"updated":"2014-09-23 18:18:27.000000000","message":"Should be an extra newline here.","commit_id":"8de86ee4408ec2adc01b7acc8c9f9f4f5d3d47cb"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"3ebb50635fb60f07bd3c0370a7a75fbd82707080","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                                \u0027data for performance profiling of operation. \u0027"},{"line_number":209,"context_line":"                                \u0027This key should be the value of HMAC key \u0027"},{"line_number":210,"context_line":"                                \u0027configured in osprofiler middleware in \u0027"},{"line_number":211,"context_line":"                                \u0027keystone, it specified in paste config \u0027"},{"line_number":212,"context_line":"                                \u0027file at /etc/keystone-paste.ini. \u0027"},{"line_number":213,"context_line":"                                \u0027Without key the profiling will not be \u0027"},{"line_number":214,"context_line":"                                \u0027triggered even if osprofiler is enabled \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_1cca546e","line":211,"updated":"2014-09-23 18:18:27.000000000","message":"Keystone","commit_id":"8de86ee4408ec2adc01b7acc8c9f9f4f5d3d47cb"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c11df85f651659d9204520b7b74d8dc9548c9bfa","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                                \u0027This key should be the value of HMAC key \u0027"},{"line_number":210,"context_line":"                                \u0027configured in osprofiler middleware in \u0027"},{"line_number":211,"context_line":"                                \u0027keystone, it specified in paste config \u0027"},{"line_number":212,"context_line":"                                \u0027file at /etc/keystone-paste.ini. \u0027"},{"line_number":213,"context_line":"                                \u0027Without key the profiling will not be \u0027"},{"line_number":214,"context_line":"                                \u0027triggered even if osprofiler is enabled \u0027"},{"line_number":215,"context_line":"                                \u0027on server side.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_4275c996","line":212,"updated":"2014-09-02 06:47:56.000000000","message":"that\u0027s not the default location for the paste file. \n\nI think you should just omit that. Also i\u0027m pretty sure we would prefer people to set values via CONF that in the paste file.","commit_id":"8de86ee4408ec2adc01b7acc8c9f9f4f5d3d47cb"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c11df85f651659d9204520b7b74d8dc9548c9bfa","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                                \u0027file at /etc/keystone-paste.ini. \u0027"},{"line_number":213,"context_line":"                                \u0027Without key the profiling will not be \u0027"},{"line_number":214,"context_line":"                                \u0027triggered even if osprofiler is enabled \u0027"},{"line_number":215,"context_line":"                                \u0027on server side.\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        session.Session.register_cli_options(parser)"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_225e0513","line":215,"updated":"2014-09-02 06:47:56.000000000","message":"--profile sounds like a boolean to me. Turn profiling on. Should be called --profile-hmac or --profile-key or something. \n\nYou sure you don\u0027t want to have an env variable available? \n\nAlso I\u0027m not sure of why we have some --os- parameters and some without - but i\u0027d have gone with the --os-  prefix","commit_id":"8de86ee4408ec2adc01b7acc8c9f9f4f5d3d47cb"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c11df85f651659d9204520b7b74d8dc9548c9bfa","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        try:"},{"line_number":407,"context_line":"            profile \u003d osprofiler_profiler and options.profile"},{"line_number":408,"context_line":"            if profile:"},{"line_number":409,"context_line":"                osprofiler_profiler.init(options.profile)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"            args.func(self.cs, args)"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_02910199","line":409,"updated":"2014-09-02 06:47:56.000000000","message":"I would think that if someone has elected to have --profile enabled you should probably fail if osprofiler is not available. It will be confusing otherwise.\n\nIs the global state here going to work when we have multiple client libraries all imported?","commit_id":"8de86ee4408ec2adc01b7acc8c9f9f4f5d3d47cb"}]}