)]}'
{"id":"openstack%2Fpython-keystoneclient~118008","triplet_id":"openstack%2Fpython-keystoneclient~master~I136f78f22a01a48496cd32a385ab2aea0c5a31bf","project":"openstack/python-keystoneclient","branch":"master","topic":"allow_no_token","hashtags":[],"change_id":"I136f78f22a01a48496cd32a385ab2aea0c5a31bf","subject":"Allow returning None from an auth plugin","status":"ABANDONED","created":"2014-08-31 05:02:53.000000000","updated":"2014-11-27 04:52:25.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0d5c17c80446639bdffc1c6d3ed007357af0e71b","_number":118008,"virtual_id_number":118008,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2014-08-31 06:23:51.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-09-25 22:39:50.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":-1,"date":"2014-08-31 05:12:10.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-31 06:23:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-09-25 22:39:50.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"}],"messages":[{"id":"ea212a9b2b5ec59f0d4db84237f02df73ece84f7","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-08-31 05:02:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6bd55034229329671e5385978b6ad28011af6cd3","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-08-31 05:12:10.000000000","message":"Patch Set 1: Workflow-1\n\nToo simplistic, need to thing of something better","accounts_in_message":[],"_revision_number":1},{"id":"b9b5d832aa08728831cd4996ca24657a523800b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-31 06:23:51.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/08/118008/1/check/gate-python-keystoneclient-pep8/b10bcae : SUCCESS in 2m 37s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/08/118008/1/check/gate-python-keystoneclient-docs/2ed05c7/doc/build/html/ : SUCCESS in 3m 18s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/08/118008/1/check/gate-python-keystoneclient-python26/3ab8a03 : FAILURE in 2m 16s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/08/118008/1/check/gate-python-keystoneclient-python27/eb1565c : FAILURE in 2m 39s\n- check-tempest-dsvm-full http://logs.openstack.org/08/118008/1/check/check-tempest-dsvm-full/214c266 : SUCCESS in 1h 08m 09s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/08/118008/1/check/check-tempest-dsvm-postgres-full/f204777 : SUCCESS in 1h 14m 44s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/08/118008/1/check/check-tempest-dsvm-neutron-full/9e2e96b : SUCCESS in 59m 17s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/08/118008/1/check/check-tempest-dsvm-neutron-heat-slow/9a91a4f : SUCCESS in 22m 49s\n- check-grenade-dsvm http://logs.openstack.org/08/118008/1/check/check-grenade-dsvm/5a13a17 : SUCCESS in 36m 41s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/118008/1/check/gate-tempest-dsvm-large-ops/cf61544 : SUCCESS in 24m 57s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/118008/1/check/gate-tempest-dsvm-neutron-large-ops/2973018 : SUCCESS in 23m 04s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/08/118008/1/check/check-tempest-dsvm-full-havana/c54da85 : SUCCESS in 35m 04s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/08/118008/1/check/check-tempest-dsvm-neutron-havana/330a768 : SUCCESS in 40m 31s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/08/118008/1/check/check-tempest-dsvm-full-icehouse/f615636 : SUCCESS in 44m 00s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/08/118008/1/check/check-tempest-dsvm-neutron-icehouse/d14f680 : SUCCESS in 57m 43s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/08/118008/1/check/gate-python-keystoneclient-python33/226864e : FAILURE in 3m 46s\n- check-devstack-dsvm-cells http://logs.openstack.org/08/118008/1/check/check-devstack-dsvm-cells/2dc5e8d : SUCCESS in 15m 56s","accounts_in_message":[],"_revision_number":1},{"id":"6f5b175cd215dccaaaa9e5d7690c0a0d40c82d70","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2014-09-25 22:39:50.000000000","message":"Patch Set 1:\n\nto be fair, simple is better :)","accounts_in_message":[],"_revision_number":1},{"id":"db9e257ed3c6185ff0d7673e93e65cd4293b449a","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-11-27 04:52:25.000000000","message":"Abandoned\n\nNeeds to be part of something bigger. \n\nWe need to allow the case when you either don\u0027t want to set X-Auth-Token or we want to set something else, for example X-Service-Token.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ac474032d791194aa0148aaaddbcbc99e28408c6","revisions":{"ac474032d791194aa0148aaaddbcbc99e28408c6":{"kind":"REWORK","_number":1,"created":"2014-08-31 05:02:53.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/08/118008/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/08/118008/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/08/118008/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/08/118008/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/08/118008/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/08/118008/1"}}},"commit":{"parents":[{"commit":"46695565d3bcc5cf9bce23711ec6eca458191898","subject":"Merge \"Standardize AccessInfo token setting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46695565d3bcc5cf9bce23711ec6eca458191898"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-31 04:39:14.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-31 05:00:42.000000000","tz":600},"subject":"Allow returning None from an auth plugin","message":"Allow returning None from an auth plugin\n\nWe need to allow returning None from an auth plugin to indicate that\nthere is no token to insert in the X-Auth-Token case. This will allow us\nto handle the noauth case and work towards the client cert or such a\nstyle of plugin that doesn\u0027t rely on the token value.\n\nThis won\u0027t affect the actual authentication request case where an\nexception is raised when the request failed.\n\nIn the case of any existing third party plugins that rely on this\nbehaviour the situation is not ideal however it means that the request\nwill go ahead and will still receive an Unauthorized exception when the\nrequest then fails.\n\nCloses-Bug: #1363569\nChange-Id: I136f78f22a01a48496cd32a385ab2aea0c5a31bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ac474032d791194aa0148aaaddbcbc99e28408c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ac474032d791194aa0148aaaddbcbc99e28408c6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}