)]}'
{"id":"openstack%2Fpython-keystoneclient~118031","triplet_id":"openstack%2Fpython-keystoneclient~master~Ia8ec9294e054e2231aa4a5e2633e2b7d5d15066a","project":"openstack/python-keystoneclient","branch":"master","topic":"requests-mock-fix","hashtags":[],"change_id":"Ia8ec9294e054e2231aa4a5e2633e2b7d5d15066a","subject":"Fix test mistake with requests-mock","status":"MERGED","created":"2014-08-31 10:50:14.000000000","updated":"2014-08-31 22:37:44.000000000","submitted":"2014-08-31 22:37:44.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5827fbd8e23c35cf31434227d0c71a44965fe055","_number":118031,"virtual_id_number":118031,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":2,"date":"2014-08-31 22:37:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12950,"name":"Yukinori Sagara","email":"yukinori.sagara@gmail.com","username":"sagara"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"date":"2014-08-31 15:36:37.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"recommended":{"_account_id":12950,"name":"Yukinori Sagara","email":"yukinori.sagara@gmail.com","username":"sagara"},"all":[{"value":1,"date":"2014-08-31 17:40:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-08-31 14:54:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12950,"name":"Yukinori Sagara","email":"yukinori.sagara@gmail.com","username":"sagara"},{"value":2,"date":"2014-08-31 21:31:22.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2014-08-31 15:40:25.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12950,"name":"Yukinori Sagara","email":"yukinori.sagara@gmail.com","username":"sagara"},{"value":1,"date":"2014-08-31 21:31:41.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":12950,"name":"Yukinori Sagara","email":"yukinori.sagara@gmail.com","username":"sagara"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-31 14:54:11.000000000","updated_by":{"_account_id":12950,"name":"Yukinori Sagara","email":"yukinori.sagara@gmail.com","username":"sagara"},"reviewer":{"_account_id":12950,"name":"Yukinori Sagara","email":"yukinori.sagara@gmail.com","username":"sagara"},"state":"REVIEWER"},{"updated":"2014-08-31 15:36:37.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2014-08-31 17:40:26.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2014-08-31 21:31:41.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-08-31 22:37:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8adaa9d04f06d0cf71a43c787679200878cd5d7d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-08-31 10:50:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5704d60585e24a263e79ea3ad207bd8747e1e1e7","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-08-31 11:39:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"21ab4ab6b25f885bbe45285e18d6f5da4b1497c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-31 12:55:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/31/118031/2/check/gate-python-keystoneclient-pep8/d8d17b1 : SUCCESS in 2m 54s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/31/118031/2/check/gate-python-keystoneclient-docs/c1746b7/doc/build/html/ : SUCCESS in 3m 40s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/31/118031/2/check/gate-python-keystoneclient-python26/8739fc3 : SUCCESS in 1m 54s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/31/118031/2/check/gate-python-keystoneclient-python27/8a141f4 : SUCCESS in 2m 49s\n- check-tempest-dsvm-full http://logs.openstack.org/31/118031/2/check/check-tempest-dsvm-full/9e2c461 : SUCCESS in 48m 50s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/31/118031/2/check/check-tempest-dsvm-postgres-full/885f3a0 : SUCCESS in 1h 16m 32s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/31/118031/2/check/check-tempest-dsvm-neutron-full/50e84a5 : SUCCESS in 1h 07m 14s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/31/118031/2/check/check-tempest-dsvm-neutron-heat-slow/45730ce : SUCCESS in 20m 02s\n- check-grenade-dsvm http://logs.openstack.org/31/118031/2/check/check-grenade-dsvm/1b544ec : SUCCESS in 43m 30s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/31/118031/2/check/gate-tempest-dsvm-large-ops/9b0d9f9 : SUCCESS in 25m 12s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/31/118031/2/check/gate-tempest-dsvm-neutron-large-ops/0de559d : SUCCESS in 23m 57s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/31/118031/2/check/check-tempest-dsvm-full-havana/c002efc : SUCCESS in 36m 23s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/31/118031/2/check/check-tempest-dsvm-neutron-havana/c5e4e7a : SUCCESS in 34m 24s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/31/118031/2/check/check-tempest-dsvm-full-icehouse/599bfff : SUCCESS in 46m 21s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/31/118031/2/check/check-tempest-dsvm-neutron-icehouse/61b5e80 : SUCCESS in 56m 10s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/31/118031/2/check/gate-python-keystoneclient-python33/4c971ef : SUCCESS in 3m 44s\n- check-devstack-dsvm-cells http://logs.openstack.org/31/118031/2/check/check-devstack-dsvm-cells/f4959c0 : SUCCESS in 16m 49s","accounts_in_message":[],"_revision_number":2},{"id":"104a3e6affe6cfd869bf33ba46069d5f35dca740","author":{"_account_id":12950,"name":"Yukinori Sagara","email":"yukinori.sagara@gmail.com","username":"sagara"},"date":"2014-08-31 14:54:11.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks good to me.","accounts_in_message":[],"_revision_number":2},{"id":"88eaeb01a33517190478a32f1346b905ec831831","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-08-31 15:36:37.000000000","message":"Patch Set 2:\n\nI think the whole \u0027text\u003dbody\u0027 bit is very intuitive, where just setting the value to body\u003d and the mock library helps you out seems a lot more intuitive.","accounts_in_message":[],"_revision_number":2},{"id":"05e9d88c171ff09732ba3bb160596ad468ab5559","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-08-31 15:37:03.000000000","message":"Patch Set 2:\n\nerm text\u003dbody is non-intuitive","accounts_in_message":[],"_revision_number":2},{"id":"f8722e7d5e1c43484d23c604af0b36cae9dec1d1","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-08-31 15:40:25.000000000","message":"Patch Set 2: Code-Review+2\n\nBut this solves the issue.  There are a number of other clients/projects that are also affected and need this fix.","accounts_in_message":[],"_revision_number":2},{"id":"52e08ec30852d6bc2cc0dd3ecb6e80542bab892c","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2014-08-31 17:40:26.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nJust one suggestion for the commit message, otherwise this looks fine.","accounts_in_message":[],"_revision_number":2},{"id":"18736f7bf8bf40eee4fa67db19ad37d333182f3e","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-08-31 21:31:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0ca1f46236c7c5b519c677925d556f1734dbcb04","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-31 21:31:41.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"501359752871f33c35d18b7e8c9162f54b0b75f2","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-08-31 21:31:41.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"898d75a70b737e4f999784758882b769c77cf15a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-31 22:37:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/31/118031/2/gate/gate-python-keystoneclient-docs/50ebada/doc/build/html/ : SUCCESS in 3m 30s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/31/118031/2/gate/gate-python-keystoneclient-pep8/3ddc0a7 : SUCCESS in 3m 01s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/31/118031/2/gate/gate-python-keystoneclient-python26/284821e : SUCCESS in 2m 02s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/31/118031/2/gate/gate-python-keystoneclient-python27/c791c44 : SUCCESS in 2m 49s\n- gate-tempest-dsvm-full http://logs.openstack.org/31/118031/2/gate/gate-tempest-dsvm-full/aeaeb78 : SUCCESS in 57m 47s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/31/118031/2/gate/gate-tempest-dsvm-postgres-full/0875b14 : SUCCESS in 1h 06m 00s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/31/118031/2/gate/gate-tempest-dsvm-neutron-full/9ba4bd9 : SUCCESS in 1h 05m 03s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/31/118031/2/gate/gate-tempest-dsvm-neutron-heat-slow/7a5e418 : SUCCESS in 22m 34s\n- gate-grenade-dsvm http://logs.openstack.org/31/118031/2/gate/gate-grenade-dsvm/cdee38f : SUCCESS in 36m 08s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/31/118031/2/gate/gate-tempest-dsvm-large-ops/1c7c9f1 : SUCCESS in 25m 07s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/31/118031/2/gate/gate-tempest-dsvm-neutron-large-ops/2099bbd : SUCCESS in 17m 56s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/31/118031/2/gate/gate-python-keystoneclient-python33/87ff2cf : SUCCESS in 3m 51s\n- gate-devstack-dsvm-cells http://logs.openstack.org/31/118031/2/gate/gate-devstack-dsvm-cells/34c014d : SUCCESS in 14m 52s","accounts_in_message":[],"_revision_number":2},{"id":"ffff9c169b408b0222b22fb530adf9a1a763ea0b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-31 22:37:44.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1643f7da32b1f729f12d042565d8c67f10f91b8c","revisions":{"11e0af119bba81fbe1b0e2afa1800033b8dc3cff":{"kind":"REWORK","_number":1,"created":"2014-08-31 10:50:14.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/31/118031/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/118031/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/118031/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/118031/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/118031/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/118031/1"}}},"commit":{"parents":[{"commit":"46695565d3bcc5cf9bce23711ec6eca458191898","subject":"Merge \"Standardize AccessInfo token setting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46695565d3bcc5cf9bce23711ec6eca458191898"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-31 10:48:46.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-31 10:48:46.000000000","tz":600},"subject":"Fix test mistake with requests-mock","message":"Fix test mistake with requests-mock\n\nbody\u003d parameters are supposed to be io objects. This is obviously missed\nfrom using HTTPretty.\n\nChange-Id: Ia8ec9294e054e2231aa4a5e2633e2b7d5d15066a\nCloses-Bug: #1363632\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/11e0af119bba81fbe1b0e2afa1800033b8dc3cff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/11e0af119bba81fbe1b0e2afa1800033b8dc3cff"}]},"branch":"refs/heads/master"},"1643f7da32b1f729f12d042565d8c67f10f91b8c":{"kind":"REWORK","_number":2,"created":"2014-08-31 11:39:06.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/31/118031/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/118031/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/118031/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/118031/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/118031/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/118031/2"}}},"commit":{"parents":[{"commit":"46695565d3bcc5cf9bce23711ec6eca458191898","subject":"Merge \"Standardize AccessInfo token setting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46695565d3bcc5cf9bce23711ec6eca458191898"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-31 10:48:46.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-08-31 11:38:05.000000000","tz":600},"subject":"Fix test mistake with requests-mock","message":"Fix test mistake with requests-mock\n\nbody\u003d parameters are supposed to be io objects. This is obviously during\nthe conversion from HTTPretty.\n\nChange-Id: Ia8ec9294e054e2231aa4a5e2633e2b7d5d15066a\nCloses-Bug: #1363632\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1643f7da32b1f729f12d042565d8c67f10f91b8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1643f7da32b1f729f12d042565d8c67f10f91b8c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}