)]}'
{"keystoneclient/auth/base.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"31a78c88c374806f2a0199c46ca316f0598b8000","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # is currently not.  Options are handled in as similar a way as"},{"line_number":140,"context_line":"        # possible to oslo.config such that when available we should be able to"},{"line_number":141,"context_line":"        # transition."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        for opt in cls.get_options():"},{"line_number":144,"context_line":"            args \u003d []"},{"line_number":145,"context_line":"            envs \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_d6c56d8e","side":"PARENT","line":142,"updated":"2014-09-15 16:51:05.000000000","message":"Why this whitespace change? Doesn\u0027t seem to belong in this patch.","commit_id":"98b0bf0eb995c6575b1f2c12cb0e4144d4528c8b"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"40f676d8ac985fe156bacf88fa3d3a90856afeb5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # is currently not.  Options are handled in as similar a way as"},{"line_number":140,"context_line":"        # possible to oslo.config such that when available we should be able to"},{"line_number":141,"context_line":"        # transition."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        for opt in cls.get_options():"},{"line_number":144,"context_line":"            args \u003d []"},{"line_number":145,"context_line":"            envs \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_2c53c8e2","side":"PARENT","line":142,"in_reply_to":"fa98f980_d6c56d8e","updated":"2014-09-15 17:49:14.000000000","message":"Done","commit_id":"98b0bf0eb995c6575b1f2c12cb0e4144d4528c8b"}],"keystoneclient/auth/cli.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"31a78c88c374806f2a0199c46ca316f0598b8000","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    else:"},{"line_number":53,"context_line":"        msg \u003d \u0027Options specific to the %s plugin.\u0027 % options.os_auth_plugin"},{"line_number":54,"context_line":"        plugin \u003d base.get_plugin_class(options.os_auth_plugin)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    group \u003d parser.add_argument_group(\u0027Authentication Options\u0027, msg)"},{"line_number":57,"context_line":"    plugin.register_argparse_arguments(group)"},{"line_number":58,"context_line":"    return plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_165375e2","side":"PARENT","line":55,"updated":"2014-09-15 16:51:05.000000000","message":"Another unrelated change.","commit_id":"98b0bf0eb995c6575b1f2c12cb0e4144d4528c8b"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"40f676d8ac985fe156bacf88fa3d3a90856afeb5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    else:"},{"line_number":53,"context_line":"        msg \u003d \u0027Options specific to the %s plugin.\u0027 % options.os_auth_plugin"},{"line_number":54,"context_line":"        plugin \u003d base.get_plugin_class(options.os_auth_plugin)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    group \u003d parser.add_argument_group(\u0027Authentication Options\u0027, msg)"},{"line_number":57,"context_line":"    plugin.register_argparse_arguments(group)"},{"line_number":58,"context_line":"    return plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_ac56d8cb","side":"PARENT","line":55,"in_reply_to":"fa98f980_165375e2","updated":"2014-09-15 17:49:14.000000000","message":"Done","commit_id":"98b0bf0eb995c6575b1f2c12cb0e4144d4528c8b"}],"keystoneclient/auth/identity/cli.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"31a78c88c374806f2a0199c46ca316f0598b8000","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"from keystoneclient.auth import base as auth_base"},{"line_number":17,"context_line":"from keystoneclient.auth.identity.generic import base as generic_base"},{"line_number":18,"context_line":"from keystoneclient.auth.identity.generic import password"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_364eb938","line":15,"updated":"2014-09-15 16:51:05.000000000","message":"There should be a newline before the imports.","commit_id":"b8f244e1c6425bdb301160ba680241d572f76a5f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"40f676d8ac985fe156bacf88fa3d3a90856afeb5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"from keystoneclient.auth import base as auth_base"},{"line_number":17,"context_line":"from keystoneclient.auth.identity.generic import base as generic_base"},{"line_number":18,"context_line":"from keystoneclient.auth.identity.generic import password"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_2c6ae880","line":15,"in_reply_to":"fa98f980_364eb938","updated":"2014-09-15 17:49:14.000000000","message":"Done","commit_id":"b8f244e1c6425bdb301160ba680241d572f76a5f"}],"keystoneclient/httpclient.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"31a78c88c374806f2a0199c46ca316f0598b8000","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        * if force_new_token is true"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        \"\"\""},{"line_number":452,"context_line":"        print(\"LEG AUTH\")"},{"line_number":453,"context_line":"        auth_url \u003d auth_url or self.auth_url"},{"line_number":454,"context_line":"        user_id \u003d user_id or self.user_id"},{"line_number":455,"context_line":"        username \u003d username or self.username"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_d6cf2d7d","line":452,"updated":"2014-09-15 16:51:05.000000000","message":"?","commit_id":"b8f244e1c6425bdb301160ba680241d572f76a5f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"40f676d8ac985fe156bacf88fa3d3a90856afeb5","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        * if force_new_token is true"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        \"\"\""},{"line_number":452,"context_line":"        print(\"LEG AUTH\")"},{"line_number":453,"context_line":"        auth_url \u003d auth_url or self.auth_url"},{"line_number":454,"context_line":"        user_id \u003d user_id or self.user_id"},{"line_number":455,"context_line":"        username \u003d username or self.username"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_2c0108af","line":452,"in_reply_to":"fa98f980_d6cf2d7d","updated":"2014-09-15 17:49:14.000000000","message":"Done","commit_id":"b8f244e1c6425bdb301160ba680241d572f76a5f"}],"keystoneclient/tests/auth/test_cli.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"31a78c88c374806f2a0199c46ca316f0598b8000","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_creating_with_no_args(self):"},{"line_number":48,"context_line":"        ret \u003d cli.register_argparse_arguments(self.p, [])"},{"line_number":49,"context_line":"        self.assertEqual(ret, cli_plugin.CliPlugin)"},{"line_number":50,"context_line":"        self.assertIn(\u0027--os-auth-plugin\u0027, self.p.format_usage())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_load_with_nothing(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_f61c3115","line":49,"updated":"2014-09-15 16:51:05.000000000","message":"I think the order needs to be reversed here. The order should be (expected, observed).","commit_id":"b8f244e1c6425bdb301160ba680241d572f76a5f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"40f676d8ac985fe156bacf88fa3d3a90856afeb5","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_creating_with_no_args(self):"},{"line_number":48,"context_line":"        ret \u003d cli.register_argparse_arguments(self.p, [])"},{"line_number":49,"context_line":"        self.assertEqual(ret, cli_plugin.CliPlugin)"},{"line_number":50,"context_line":"        self.assertIn(\u0027--os-auth-plugin\u0027, self.p.format_usage())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_load_with_nothing(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_ece8e0e3","line":49,"in_reply_to":"fa98f980_f61c3115","updated":"2014-09-15 17:49:14.000000000","message":"Done","commit_id":"b8f244e1c6425bdb301160ba680241d572f76a5f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"31a78c88c374806f2a0199c46ca316f0598b8000","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        cli.register_argparse_arguments(self.p, [])"},{"line_number":54,"context_line":"        opts \u003d self.p.parse_args([])"},{"line_number":55,"context_line":"        ret \u003d cli.load_from_argparse_arguments(opts)"},{"line_number":56,"context_line":"        self.assertEqual(True, isinstance(ret, cli_plugin.CliPlugin))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @utils.mock_plugin"},{"line_number":59,"context_line":"    def test_basic_params_added(self, m):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_36ea39d8","line":56,"updated":"2014-09-15 16:51:05.000000000","message":"assertIsInstance?","commit_id":"b8f244e1c6425bdb301160ba680241d572f76a5f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"40f676d8ac985fe156bacf88fa3d3a90856afeb5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        cli.register_argparse_arguments(self.p, [])"},{"line_number":54,"context_line":"        opts \u003d self.p.parse_args([])"},{"line_number":55,"context_line":"        ret \u003d cli.load_from_argparse_arguments(opts)"},{"line_number":56,"context_line":"        self.assertEqual(True, isinstance(ret, cli_plugin.CliPlugin))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @utils.mock_plugin"},{"line_number":59,"context_line":"    def test_basic_params_added(self, m):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_ccb5dced","line":56,"in_reply_to":"fa98f980_36ea39d8","updated":"2014-09-15 17:49:14.000000000","message":"Done","commit_id":"b8f244e1c6425bdb301160ba680241d572f76a5f"}],"keystoneclient/tests/test_shell.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"31a78c88c374806f2a0199c46ca316f0598b8000","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                      DEFAULT_TENANT_NAME, DEFAULT_USERNAME, \u0027\u0027)"},{"line_number":167,"context_line":"            self.assertTrue(all([x \u003d\u003d y for x, y in zip(actual, expect)]))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"            # Old_style options"},{"line_number":170,"context_line":"            shell(\u0027--os_auth_url http://0.0.0.0:5000/ --os_password xyzpdq \u0027"},{"line_number":171,"context_line":"                  \u0027--os_tenant_id 1234 --os_tenant_name fred \u0027"},{"line_number":172,"context_line":"                  \u0027--os_username barney \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_b636294f","side":"PARENT","line":169,"updated":"2014-09-15 16:51:05.000000000","message":"Why are you removing all of the old style tests? Is this style no longer supported?","commit_id":"98b0bf0eb995c6575b1f2c12cb0e4144d4528c8b"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"40f676d8ac985fe156bacf88fa3d3a90856afeb5","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                      DEFAULT_TENANT_NAME, DEFAULT_USERNAME, \u0027\u0027)"},{"line_number":167,"context_line":"            self.assertTrue(all([x \u003d\u003d y for x, y in zip(actual, expect)]))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"            # Old_style options"},{"line_number":170,"context_line":"            shell(\u0027--os_auth_url http://0.0.0.0:5000/ --os_password xyzpdq \u0027"},{"line_number":171,"context_line":"                  \u0027--os_tenant_id 1234 --os_tenant_name fred \u0027"},{"line_number":172,"context_line":"                  \u0027--os_username barney \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_cc831c01","side":"PARENT","line":169,"in_reply_to":"fa98f980_b636294f","updated":"2014-09-15 17:49:14.000000000","message":"After talking with jamielennox he said it was ok to remove the old style opts since the plugins uses --os-\u003copt\u003e etc vs --os_\u003copt\u003e hence why removing the tests for it.","commit_id":"98b0bf0eb995c6575b1f2c12cb0e4144d4528c8b"}]}