)]}'
{"id":"openstack%2Fpython-keystoneclient~122569","triplet_id":"openstack%2Fpython-keystoneclient~master~Ia6fd754245799b792537ec10d6c2964f8d84fe30","project":"openstack/python-keystoneclient","branch":"master","topic":"tox-docs","hashtags":[],"change_id":"Ia6fd754245799b792537ec10d6c2964f8d84fe30","subject":"Add session helper functions","status":"ABANDONED","created":"2014-09-18 23:49:50.000000000","updated":"2014-12-15 22:04:31.000000000","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"57170459f9c85ab479eae4f821d97cda46b3a683","_number":122569,"virtual_id_number":122569,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2014-09-19 02:55:26.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-09-19 00:43:08.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"date":"2014-09-19 15:43:06.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2014-09-19 01:05:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":-1,"date":"2014-10-03 17:56:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":-1,"date":"2014-09-19 02:07:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-19 00:43:08.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-09-19 02:07:33.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2014-09-19 02:55:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-09-19 15:43:06.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2014-10-03 17:56:25.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"}],"messages":[{"id":"7351a087e0e035da03e4af9e64141ebcc19e25af","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2014-09-18 23:49:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5e270dcadde6e777d215cf1f022f04922136c689","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-09-19 00:43:08.000000000","message":"Patch Set 1:\n\nHaven\u0027t looked into this a whole lot, but I think Jamie\u0027s already implemented essentially this functionality... I think https://review.openstack.org/#/c/118006/ (from neutronclient) is the vision for how clients should be using the session and auth plugins.","accounts_in_message":[],"_revision_number":1},{"id":"7cab3def32231757c905dba40d724b9ccc517dff","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-09-19 01:05:37.000000000","message":"Patch Set 1: Code-Review-1\n\n(8 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0bcba71354356b6cac4f48a1d6f25e50a3e5b561","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2014-09-19 02:07:33.000000000","message":"Patch Set 1: Code-Review-1\n\nPretty sure that this code does not belong in the session.  It might be appropriate in httpclient.  I don\u0027t like the auth shorthand, as it is tying us tighter to passwords, and we really need to treat other auth tools as equals  (Kerberos and X509 in particular)","accounts_in_message":[],"_revision_number":1},{"id":"e99414fa3dc3610fb61f223cece8ec96639bd012","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-19 02:55:26.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/69/122569/1/check/gate-python-keystoneclient-pep8/b9b8e48 : FAILURE in 1m 59s\n- gate-python-keystoneclient-docs http://logs.openstack.org/69/122569/1/check/gate-python-keystoneclient-docs/4a8c000 : FAILURE in 1m 54s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/69/122569/1/check/gate-python-keystoneclient-python26/7e0662f : FAILURE in 3m 47s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/69/122569/1/check/gate-python-keystoneclient-python27/3649a02 : FAILURE in 2m 15s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/69/122569/1/check/gate-python-keystoneclient-python33/9f7b8e2 : FAILURE in 3m 28s\n- check-tempest-dsvm-full http://logs.openstack.org/69/122569/1/check/check-tempest-dsvm-full/4b0e741 : FAILURE in 11m 13s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/69/122569/1/check/check-tempest-dsvm-postgres-full/a6aa187 : FAILURE in 11m 15s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/69/122569/1/check/check-tempest-dsvm-neutron-full/202eb8d : FAILURE in 8m 34s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/69/122569/1/check/check-tempest-dsvm-neutron-heat-slow/b511f48 : FAILURE in 11m 33s\n- check-grenade-dsvm http://logs.openstack.org/69/122569/1/check/check-grenade-dsvm/cc3c3e9 : FAILURE in 14m 47s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/69/122569/1/check/gate-tempest-dsvm-large-ops/13b936c : FAILURE in 9m 10s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/69/122569/1/check/gate-tempest-dsvm-neutron-large-ops/23cf6ef : FAILURE in 10m 29s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/69/122569/1/check/check-tempest-dsvm-full-havana/01ae9ec : FAILURE in 10m 52s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/69/122569/1/check/check-tempest-dsvm-neutron-havana/73f2784 : FAILURE in 12m 53s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/69/122569/1/check/check-tempest-dsvm-full-icehouse/d6192c8 : FAILURE in 11m 40s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/69/122569/1/check/check-tempest-dsvm-neutron-icehouse/9694794 : FAILURE in 12m 15s\n- check-devstack-dsvm-cells http://logs.openstack.org/69/122569/1/check/check-devstack-dsvm-cells/83901a2 : FAILURE in 8m 01s","accounts_in_message":[],"_revision_number":1},{"id":"2c7c72de98d405c3cf8f8da563309b018e1f5d9c","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-09-19 15:43:06.000000000","message":"Patch Set 1:\n\n@Brant, Thanks for the link, I was actually looking for that.","accounts_in_message":[],"_revision_number":1},{"id":"98d570ac549b1c703f291c9cc73353da9cedd57c","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-10-03 17:56:25.000000000","message":"Patch Set 1: Code-Review-1\n\nI\u0027ve seen this code in a few places and consider it a hack to not have to fix the clis. \n\nWhat is there can be divided into the the existing pieces.\n\n1. Session construction can be done with Session() or Session.construct to deal with passing individual cert parameters.\n\n2. The adapter should be to completely replace the existing httpclients except for backwards compatibility. Pass everything from client.__init__ to adapter.__init__ \n\n3. The version password bit looks exactly like auth.generic.Password\n\nThe problem is generally that there is no consensus between the clients on the params they take. Particularly for the CLI. If we can get a consensus there then we can simply make a CLI auth plugin they can all use.\n\nThe issue is always compatibility. My solution was that by passing the session object you are option ng for new behaviour and old functions might not be available. However the push for v3 meant a lot of this for adopted quickly and in a way that required the least change to existing code.","accounts_in_message":[],"_revision_number":1},{"id":"3b216a463e96d4122b62d1a61f331a1a90699d3c","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-12-15 22:04:31.000000000","message":"Abandoned\n\nThis change is being abandoned because it has a negative score and has not seen an update in \u003e 60 days. Feel free to re-instate this patch (as the author) by using the \"restore\" button or any member of the core team can re-instate the patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6c8f78cb3b100baebc6ea6e6b5a94e52df46ad65","revisions":{"6c8f78cb3b100baebc6ea6e6b5a94e52df46ad65":{"kind":"REWORK","_number":1,"created":"2014-09-18 23:49:50.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/69/122569/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/69/122569/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/69/122569/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/69/122569/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/69/122569/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/69/122569/1"}}},"commit":{"parents":[{"commit":"118763cbe00e00e7b78b926e21e69ec479212b1b","subject":"Merge \"Handle federated tokens\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/118763cbe00e00e7b78b926e21e69ec479212b1b"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2014-09-18 23:49:16.000000000","tz":-420},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2014-09-18 23:49:16.000000000","tz":-420},"subject":"Add session helper functions","message":"Add session helper functions\n\nThese came from cinderclient, but they seem pretty general purpose\nand like anyone using keystone.session would want them.\n\nChange-Id: Ia6fd754245799b792537ec10d6c2964f8d84fe30\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6c8f78cb3b100baebc6ea6e6b5a94e52df46ad65"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6c8f78cb3b100baebc6ea6e6b5a94e52df46ad65"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}