)]}'
{"keystoneclient/middleware/auth_token.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"c79af47702f7509e0a0fea54d853a10ca52af00f","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    if not conf:"},{"line_number":429,"context_line":"        return {}"},{"line_number":430,"context_line":"    _opts \u003d {}"},{"line_number":431,"context_line":"    opt_types \u003d dict((o.dest, getattr(o, \u0027type\u0027, str)) for o in opts)"},{"line_number":432,"context_line":"    for k, v in six.iteritems(conf):"},{"line_number":433,"context_line":"        try:"},{"line_number":434,"context_line":"            if v is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_a274e8fd","line":431,"updated":"2014-09-22 18:16:39.000000000","message":"for \u0027str\u0027, do we need use six to consider py3 env?","commit_id":"dee8bc62d641f633342cfdc37a246916a40b2f33"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"042fd4805f97a964432fb3c0a5ae2d22ec602478","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    if not conf:"},{"line_number":429,"context_line":"        return {}"},{"line_number":430,"context_line":"    _opts \u003d {}"},{"line_number":431,"context_line":"    opt_types \u003d dict((o.dest, getattr(o, \u0027type\u0027, str)) for o in opts)"},{"line_number":432,"context_line":"    for k, v in six.iteritems(conf):"},{"line_number":433,"context_line":"        try:"},{"line_number":434,"context_line":"            if v is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_2ab0ca8a","line":431,"in_reply_to":"da9df570_0fb0788a","updated":"2014-09-22 21:06:33.000000000","message":"This was exactly the view I was going to type. Old Oslo.config can maintain old behavior.","commit_id":"dee8bc62d641f633342cfdc37a246916a40b2f33"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"e2a050f6885bae7dc14f382fa0f8b647c56311e2","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    if not conf:"},{"line_number":429,"context_line":"        return {}"},{"line_number":430,"context_line":"    _opts \u003d {}"},{"line_number":431,"context_line":"    opt_types \u003d dict((o.dest, getattr(o, \u0027type\u0027, str)) for o in opts)"},{"line_number":432,"context_line":"    for k, v in six.iteritems(conf):"},{"line_number":433,"context_line":"        try:"},{"line_number":434,"context_line":"            if v is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_79aab671","line":431,"in_reply_to":"da9df570_4277bcd4","updated":"2014-09-22 19:18:14.000000000","message":"Ok, good enough for this fix, thanks. I\u0027m thinking a dedicated \u0027str\u0027 encoding issue for oslo.config now..IMO, we\u0027d better to use six in there.","commit_id":"dee8bc62d641f633342cfdc37a246916a40b2f33"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5bf33efad763c799c98eac03e83453b3a2084718","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    if not conf:"},{"line_number":429,"context_line":"        return {}"},{"line_number":430,"context_line":"    _opts \u003d {}"},{"line_number":431,"context_line":"    opt_types \u003d dict((o.dest, getattr(o, \u0027type\u0027, str)) for o in opts)"},{"line_number":432,"context_line":"    for k, v in six.iteritems(conf):"},{"line_number":433,"context_line":"        try:"},{"line_number":434,"context_line":"            if v is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_0fb0788a","line":431,"in_reply_to":"da9df570_4fbe0001","updated":"2014-09-22 20:41:20.000000000","message":"Doug - There are non-string options, but the goal here isn\u0027t to actually work as far as converting the values to the type, it\u0027s to not crash glance-api. Using str here (where the values are strings already) means this works the way it did before the conversion code was added, which nobody ever complained about until recently. In summary:\n\n- old oslo.config that we don\u0027t even really support: works like it did before\n- new oslo.config: converts using the type.","commit_id":"dee8bc62d641f633342cfdc37a246916a40b2f33"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9839af5fe808dabfda61c3d362b16a63297a6d87","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    if not conf:"},{"line_number":429,"context_line":"        return {}"},{"line_number":430,"context_line":"    _opts \u003d {}"},{"line_number":431,"context_line":"    opt_types \u003d dict((o.dest, getattr(o, \u0027type\u0027, str)) for o in opts)"},{"line_number":432,"context_line":"    for k, v in six.iteritems(conf):"},{"line_number":433,"context_line":"        try:"},{"line_number":434,"context_line":"            if v is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_4fbe0001","line":431,"in_reply_to":"da9df570_79aab671","updated":"2014-09-22 20:16:22.000000000","message":"Do you expect to have any non-string options defined in the paste config? There are several IntOpt and BoolOpt options defined above.","commit_id":"dee8bc62d641f633342cfdc37a246916a40b2f33"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"82520ceaabe2b618fd8fd68df44899ff3f85ac9f","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    if not conf:"},{"line_number":429,"context_line":"        return {}"},{"line_number":430,"context_line":"    _opts \u003d {}"},{"line_number":431,"context_line":"    opt_types \u003d dict((o.dest, getattr(o, \u0027type\u0027, str)) for o in opts)"},{"line_number":432,"context_line":"    for k, v in six.iteritems(conf):"},{"line_number":433,"context_line":"        try:"},{"line_number":434,"context_line":"            if v is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_4277bcd4","line":431,"in_reply_to":"da9df570_a274e8fd","updated":"2014-09-22 18:21:44.000000000","message":"Good question. Based on the oslo.config code I think str is correct, since oslo.config uses str and not six.text_type in several places: http://git.openstack.org/cgit/openstack/oslo.config/tree/oslo/config/types.py#n44","commit_id":"dee8bc62d641f633342cfdc37a246916a40b2f33"}]}