)]}'
{"keystoneclient/tests/test_cms.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"01b25a9e6972e3fa90556bc89de9da70b4544772","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    resources \u003d [(\u0027examples\u0027, client_fixtures.EXAMPLES_RESOURCE)]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":34,"context_line":"        super(CMSTest, self).__init__(*args, **kwargs)"},{"line_number":35,"context_line":"        process \u003d subprocess.Popen([\u0027openssl\u0027, \u0027version\u0027],"},{"line_number":36,"context_line":"                                   stdout\u003dsubprocess.PIPE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_c5be0ad4","line":33,"updated":"2014-10-03 01:03:58.000000000","message":"override setUp rather than init","commit_id":"0ed320a8e4222c6c1f3101c62295aafc118637c0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"931941146c65481f960c7397c7f84741cefbdfaa","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    resources \u003d [(\u0027examples\u0027, client_fixtures.EXAMPLES_RESOURCE)]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":34,"context_line":"        super(CMSTest, self).__init__(*args, **kwargs)"},{"line_number":35,"context_line":"        process \u003d subprocess.Popen([\u0027openssl\u0027, \u0027version\u0027],"},{"line_number":36,"context_line":"                                   stdout\u003dsubprocess.PIPE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_c0334312","line":33,"in_reply_to":"baa201ad_03b800e4","updated":"2014-10-03 20:27:17.000000000","message":"We tried using setUpClass but for some reason it\u0027s not called. Not sure what the deal is.","commit_id":"0ed320a8e4222c6c1f3101c62295aafc118637c0"},{"author":{"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"},"change_message_id":"29c2e1e31bad09dc97dbe04efbc7c359d2542e1a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    resources \u003d [(\u0027examples\u0027, client_fixtures.EXAMPLES_RESOURCE)]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":34,"context_line":"        super(CMSTest, self).__init__(*args, **kwargs)"},{"line_number":35,"context_line":"        process \u003d subprocess.Popen([\u0027openssl\u0027, \u0027version\u0027],"},{"line_number":36,"context_line":"                                   stdout\u003dsubprocess.PIPE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_fdf722f3","line":33,"in_reply_to":"baa201ad_c5be0ad4","updated":"2014-10-03 05:25:40.000000000","message":"I deliberately chose init over setUp in order to avoid running this check before every single test but rather only run it once. Is setUp really the preferred choice here?","commit_id":"0ed320a8e4222c6c1f3101c62295aafc118637c0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3f48f4364cdbb88041be5727bd6e240946a57263","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    resources \u003d [(\u0027examples\u0027, client_fixtures.EXAMPLES_RESOURCE)]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":34,"context_line":"        super(CMSTest, self).__init__(*args, **kwargs)"},{"line_number":35,"context_line":"        process \u003d subprocess.Popen([\u0027openssl\u0027, \u0027version\u0027],"},{"line_number":36,"context_line":"                                   stdout\u003dsubprocess.PIPE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_03b800e4","line":33,"in_reply_to":"baa201ad_fdf722f3","updated":"2014-10-03 13:06:17.000000000","message":"Use a skip decorator on the class. https://docs.python.org/2/library/unittest.html#skipping-tests-and-expected-failures","commit_id":"0ed320a8e4222c6c1f3101c62295aafc118637c0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"01b25a9e6972e3fa90556bc89de9da70b4544772","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        process \u003d subprocess.Popen([\u0027openssl\u0027, \u0027version\u0027],"},{"line_number":36,"context_line":"                                   stdout\u003dsubprocess.PIPE)"},{"line_number":37,"context_line":"        out, err \u003d process.communicate()"},{"line_number":38,"context_line":"        #Example output: \u0027OpenSSL 0.9.8za 5 Jun 2014\u0027"},{"line_number":39,"context_line":"        openssl_version \u003d out.split()[1]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if err or not openssl_version.startswith(b\u00271\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_e5deae3e","line":38,"updated":"2014-10-03 01:03:58.000000000","message":"add a space after the # ... I thought we had a pep8 check for this.","commit_id":"0ed320a8e4222c6c1f3101c62295aafc118637c0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"8d5769dbfd377c68c3a4d4e54290ac41cc09c735","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        out, err \u003d process.communicate()"},{"line_number":38,"context_line":"        #Example output: \u0027OpenSSL 0.9.8za 5 Jun 2014\u0027"},{"line_number":39,"context_line":"        openssl_version \u003d out.split()[1]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if err or not openssl_version.startswith(b\u00271\u0027):"},{"line_number":42,"context_line":"            raise Exception(\"Your version of OpenSSL is not supported. You\u0027ll\""},{"line_number":43,"context_line":"                            \" need to update it to 1.0 or later.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_b03936a6","line":40,"updated":"2014-09-25 12:08:45.000000000","message":"I think that a comment here, with a reference to the bug would be nice.","commit_id":"0ed320a8e4222c6c1f3101c62295aafc118637c0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"01b25a9e6972e3fa90556bc89de9da70b4544772","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        out, err \u003d process.communicate()"},{"line_number":38,"context_line":"        #Example output: \u0027OpenSSL 0.9.8za 5 Jun 2014\u0027"},{"line_number":39,"context_line":"        openssl_version \u003d out.split()[1]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if err or not openssl_version.startswith(b\u00271\u0027):"},{"line_number":42,"context_line":"            raise Exception(\"Your version of OpenSSL is not supported. You\u0027ll\""},{"line_number":43,"context_line":"                            \" need to update it to 1.0 or later.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_a5d4a620","line":40,"in_reply_to":"da9df570_b03936a6","updated":"2014-10-03 01:03:58.000000000","message":"please don\u0027t put references to bugs in the code.","commit_id":"0ed320a8e4222c6c1f3101c62295aafc118637c0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"1f33eca6ae4a6c654bcfdc864b1b114a7fadda6e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Example output: \u0027OpenSSL 0.9.8za 5 Jun 2014\u0027"},{"line_number":39,"context_line":"        openssl_version \u003d out.split()[1]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if err or not openssl_version.startswith(b\u00271\u0027):"},{"line_number":42,"context_line":"            raise Exception(\u0027Your version of OpenSSL is not supported. \u0027"},{"line_number":43,"context_line":"                            \u0027You will need to update it to 1.0 or later.\u0027)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_b2f04e92","line":41,"updated":"2014-10-04 04:33:17.000000000","message":"this isn\u0027t really future proof, as all we know is that broken versions start with a \"0\" and the current version starts with a \"1.\"\n\nif openssl stopped reporting its own name in the version flag in 1.4, this check would unnecessarily fail. if version 2.0 was released and it still worked with our tests, this check would still fail.\n\ncheck for the known-broken version instead, startswith(b\u00270\u0027)","commit_id":"58f8407ef2c11efac31a6569195b9dc8cbbfb755"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"925ff474c88bbab99920831fb42f3d8b77f3dab3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Example output: \u0027OpenSSL 0.9.8za 5 Jun 2014\u0027"},{"line_number":39,"context_line":"        openssl_version \u003d out.split()[1]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if err or not openssl_version.startswith(b\u00271\u0027):"},{"line_number":42,"context_line":"            raise Exception(\u0027Your version of OpenSSL is not supported. \u0027"},{"line_number":43,"context_line":"                            \u0027You will need to update it to 1.0 or later.\u0027)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_66c6289c","line":41,"in_reply_to":"baa201ad_b2f04e92","updated":"2014-10-04 17:51:23.000000000","message":"++ @Dolph, will fix it","commit_id":"58f8407ef2c11efac31a6569195b9dc8cbbfb755"}]}