)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"609dd6ee11b5a572e762e778217b785c74b53eef","unresolved":false,"context_lines":[{"line_number":10,"context_line":"parameter and signing to PEM.  This increased token sizes"},{"line_number":11,"context_line":"by 300 to 600 bytes"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Bug: 1379782"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I576f21e34484cf410661c5865eb1e87ba7dde3dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_8256635a","line":13,"updated":"2014-10-16 22:48:49.000000000","message":"Closes-Bug: #1379782\n\nif you have to upload a new patch","commit_id":"26ac277cc04fc6ea8b30ecb3e4e9cc5baf728e62"}],"keystoneclient/common/cms.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"609dd6ee11b5a572e762e778217b785c74b53eef","unresolved":false,"context_lines":[{"line_number":38,"context_line":"PKI_ASN1_FORM \u003d \u0027PEM\u0027"},{"line_number":39,"context_line":"CMS_PREFIX \u003d \u0027-----BEGIN CMS-----\u0027"},{"line_number":40,"context_line":"CMS_SUFFIX \u003d \u0027-----END CMS-----\u0027"},{"line_number":41,"context_line":"CMS_PREFIX_BYTES \u003d bytearray(CMS_PREFIX, \u0027UTF-8\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def _ensure_subprocess():"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_e2472fa1","line":41,"updated":"2014-10-16 22:48:49.000000000","message":"I think the need for this is unfortunate and due to the fact that the interface for this library used both binary and text types.","commit_id":"26ac277cc04fc6ea8b30ecb3e4e9cc5baf728e62"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d2f91d58f2a8f0b15aec9de022e9a9d3914165d3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    else:"},{"line_number":147,"context_line":"        if formatted.startswith(CMS_PREFIX_BYTES):"},{"line_number":148,"context_line":"            inform \u003d PKI_ASN1_FORM"},{"line_number":149,"context_line":"        data \u003d formatted"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    process \u003d subprocess.Popen([\u0027openssl\u0027, \u0027cms\u0027, \u0027-verify\u0027,"},{"line_number":152,"context_line":"                                \u0027-certfile\u0027, signing_cert_file_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_144e2d97","line":149,"updated":"2014-10-27 13:34:02.000000000","message":"i don\u0027t understand this.\n\nWhy are you checking the inputted data to override an optional parameter - with the default value? \n\nIf someone knows what they are doing they would expect there inform\u003d parameter to be respected - and if they don\u0027t they would use the default.","commit_id":"28cdfb9712290a99b80aaf2e136d7d33f5636a63"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"8e867932d7420ccf3bdf744f5e82da30ee488c0e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    else:"},{"line_number":147,"context_line":"        if formatted.startswith(CMS_PREFIX_BYTES):"},{"line_number":148,"context_line":"            inform \u003d PKI_ASN1_FORM"},{"line_number":149,"context_line":"        data \u003d formatted"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    process \u003d subprocess.Popen([\u0027openssl\u0027, \u0027cms\u0027, \u0027-verify\u0027,"},{"line_number":152,"context_line":"                                \u0027-certfile\u0027, signing_cert_file_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_6912d7b2","line":149,"in_reply_to":"9aa7fdbe_144e2d97","updated":"2014-10-31 20:20:48.000000000","message":"Because there we currently have broken implementation:  we might be expecting Der, but get PEM here.","commit_id":"28cdfb9712290a99b80aaf2e136d7d33f5636a63"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d2f91d58f2a8f0b15aec9de022e9a9d3914165d3","unresolved":false,"context_lines":[{"line_number":229,"context_line":"def token_to_cms(signed_text):"},{"line_number":230,"context_line":"    copy_of_text \u003d signed_text.replace(\u0027-\u0027, \u0027/\u0027)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    formatted \u003d \u0027%s\\n\u0027 % CMS_PREFIX"},{"line_number":233,"context_line":"    line_length \u003d 64"},{"line_number":234,"context_line":"    while len(copy_of_text) \u003e 0:"},{"line_number":235,"context_line":"        if (len(copy_of_text) \u003e line_length):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_743e99db","line":232,"updated":"2014-10-27 13:34:02.000000000","message":"not relevant to patch/bug","commit_id":"28cdfb9712290a99b80aaf2e136d7d33f5636a63"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"8e867932d7420ccf3bdf744f5e82da30ee488c0e","unresolved":false,"context_lines":[{"line_number":229,"context_line":"def token_to_cms(signed_text):"},{"line_number":230,"context_line":"    copy_of_text \u003d signed_text.replace(\u0027-\u0027, \u0027/\u0027)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    formatted \u003d \u0027%s\\n\u0027 % CMS_PREFIX"},{"line_number":233,"context_line":"    line_length \u003d 64"},{"line_number":234,"context_line":"    while len(copy_of_text) \u003e 0:"},{"line_number":235,"context_line":"        if (len(copy_of_text) \u003e line_length):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_a93cbf30","line":232,"in_reply_to":"9aa7fdbe_743e99db","updated":"2014-10-31 20:20:48.000000000","message":"Yes it is, see line 147","commit_id":"28cdfb9712290a99b80aaf2e136d7d33f5636a63"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"25b6b954e763fa9a9d8916bdb4a327d2b69ce140","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        data \u003d bytearray(formatted, _encoding_for_form(inform))"},{"line_number":152,"context_line":"    else:"},{"line_number":153,"context_line":"        if formatted.startswith(CMS_PREFIX_BYTES):"},{"line_number":154,"context_line":"            inform \u003d PKI_ASN1_FORM"},{"line_number":155,"context_line":"        data \u003d formatted"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    process \u003d subprocess.Popen([\u0027openssl\u0027, \u0027cms\u0027, \u0027-verify\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_e47370e6","line":154,"updated":"2015-01-10 05:47:54.000000000","message":"isn\u0027t \"inform\" always receiving the same value? (PKI_ASN1_FORM)","commit_id":"87aede08cc72e14b274e12aa492594cf412d9fb1"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"25b6b954e763fa9a9d8916bdb4a327d2b69ce140","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    process \u003d subprocess.Popen([\u0027openssl\u0027, \u0027cms\u0027, \u0027-sign\u0027,"},{"line_number":336,"context_line":"                                \u0027-signer\u0027, signing_cert_file_name,"},{"line_number":337,"context_line":"                                \u0027-inkey\u0027, signing_key_file_name,"},{"line_number":338,"context_line":"                                \u0027-outform\u0027, outform,"},{"line_number":339,"context_line":"                                \u0027-nosmimecap\u0027, \u0027-nodetach\u0027,"},{"line_number":340,"context_line":"                                \u0027-nocerts\u0027, \u0027-noattr\u0027,"},{"line_number":341,"context_line":"                                \u0027-md\u0027, \u0027sha256\u0027, ],"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_04715cde","line":338,"updated":"2015-01-10 05:47:54.000000000","message":"is outform being updated somewhere?","commit_id":"87aede08cc72e14b274e12aa492594cf412d9fb1"}]}