)]}'
{"id":"openstack%2Fpython-keystoneclient~128455","triplet_id":"openstack%2Fpython-keystoneclient~master~I1cf846ec56865a9979f628f5c77d2bb689e10ffe","project":"openstack/python-keystoneclient","branch":"master","topic":"venv","hashtags":[],"change_id":"I1cf846ec56865a9979f628f5c77d2bb689e10ffe","subject":"Set install_venv_common as a script, not a module","status":"ABANDONED","created":"2014-10-14 21:55:29.000000000","updated":"2014-10-20 05:24:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"24aab3de390b9cc2ac3b0d8e3c2af53d64979304","_number":128455,"virtual_id_number":128455,"owner":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2014-10-16 20:04:15.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2014-10-15 05:58:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-10-16 20:08:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":-1,"date":"2014-10-20 00:20:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2014-10-15 12:57:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"},{"date":"2014-10-16 20:03:15.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-15 05:58:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-10-15 12:57:53.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2014-10-16 20:03:15.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-10-16 20:08:58.000000000","updated_by":{"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"},"reviewer":{"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"},"state":"REVIEWER"},{"updated":"2014-10-20 00:20:49.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"}],"messages":[{"id":"e008041f52ecfe2de8bb19e510bbfee80aa2eb02","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-14 21:55:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"48cbce2144c1b381b58f05acfde032a0490f5d21","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 23:03:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/55/128455/1/check/gate-python-keystoneclient-pep8/39eae89 : SUCCESS in 2m 00s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/55/128455/1/check/gate-python-keystoneclient-docs/3e0f804/doc/build/html/ : SUCCESS in 2m 53s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/55/128455/1/check/gate-python-keystoneclient-python26/ea4e140 : SUCCESS in 1m 45s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/55/128455/1/check/gate-python-keystoneclient-python27/3380789 : SUCCESS in 1m 41s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/55/128455/1/check/gate-python-keystoneclient-python33/af62fc2 : SUCCESS in 3m 46s\n- check-tempest-dsvm-full http://logs.openstack.org/55/128455/1/check/check-tempest-dsvm-full/362e336 : SUCCESS in 50m 11s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/55/128455/1/check/check-tempest-dsvm-postgres-full/3eb9f86 : SUCCESS in 54m 52s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/55/128455/1/check/check-tempest-dsvm-neutron-full/6fa2f4e : SUCCESS in 55m 38s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/55/128455/1/check/check-tempest-dsvm-neutron-heat-slow/4d72751 : SUCCESS in 17m 47s\n- check-grenade-dsvm http://logs.openstack.org/55/128455/1/check/check-grenade-dsvm/2dccf67 : SUCCESS in 50m 03s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/55/128455/1/check/gate-tempest-dsvm-large-ops/b4eef8a : SUCCESS in 18m 28s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/55/128455/1/check/gate-tempest-dsvm-neutron-large-ops/ffaf7ac : SUCCESS in 24m 17s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/55/128455/1/check/check-tempest-dsvm-full-icehouse/fbac434 : SUCCESS in 49m 53s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/55/128455/1/check/check-tempest-dsvm-neutron-icehouse/2d73ee1 : SUCCESS in 55m 39s\n- check-devstack-dsvm-cells http://logs.openstack.org/55/128455/1/check/check-devstack-dsvm-cells/c05cbec : SUCCESS in 14m 02s","accounts_in_message":[],"_revision_number":1},{"id":"8bb6c9110d8d6aa5404e39ab9056ec1b97b6cb36","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-15 04:28:22.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"dff87d4ed7b8bb2b66bead1c07cdd0f69a10760c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-15 05:58:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/55/128455/2/check/gate-python-keystoneclient-pep8/f9b9002 : SUCCESS in 1m 35s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/55/128455/2/check/gate-python-keystoneclient-docs/167297b/doc/build/html/ : SUCCESS in 2m 17s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/55/128455/2/check/gate-python-keystoneclient-python26/7ad5510 : SUCCESS in 2m 24s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/55/128455/2/check/gate-python-keystoneclient-python27/69be6db : SUCCESS in 1m 42s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/55/128455/2/check/gate-python-keystoneclient-python33/243a1e7 : SUCCESS in 4m 01s\n- check-tempest-dsvm-full http://logs.openstack.org/55/128455/2/check/check-tempest-dsvm-full/fdc475c : SUCCESS in 48m 27s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/55/128455/2/check/check-tempest-dsvm-postgres-full/feefea6 : SUCCESS in 52m 49s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/55/128455/2/check/check-tempest-dsvm-neutron-full/7e85dd6 : SUCCESS in 53m 22s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/55/128455/2/check/check-tempest-dsvm-neutron-heat-slow/2718684 : SUCCESS in 22m 31s\n- check-grenade-dsvm http://logs.openstack.org/55/128455/2/check/check-grenade-dsvm/2dd40bb : SUCCESS in 46m 27s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/55/128455/2/check/gate-tempest-dsvm-large-ops/31fa6ee : SUCCESS in 20m 48s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/55/128455/2/check/gate-tempest-dsvm-neutron-large-ops/edd7ced : SUCCESS in 19m 33s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/55/128455/2/check/check-tempest-dsvm-full-icehouse/d30959f : SUCCESS in 49m 58s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/55/128455/2/check/check-tempest-dsvm-neutron-icehouse/7f404a8 : SUCCESS in 57m 15s\n- check-devstack-dsvm-cells http://logs.openstack.org/55/128455/2/check/check-devstack-dsvm-cells/bd7127f : SUCCESS in 14m 13s","accounts_in_message":[],"_revision_number":2},{"id":"c3d75ba221cdb353f917e2dc41195a6f6c858425","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2014-10-15 12:57:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c0060ca04a08470c5758acca6fe57d3e277cb507","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-16 20:04:15.000000000","message":"Patch Set 2:\n\nSome background on the change, it seems harmless to not do.\n\n\u003cdhellmann\u003e stevemar: hrm, what you have now is what I expected but the old form did work at one point. I\u0027m not sure we broke that on purpose, but it\u0027s possible we did break it. :-/\n\n\u003cstevemar\u003e dhellmann, well it is still working, so I\u0027m wondering if the change is needed (i didn\u0027t know which is correct, I did suspect the current syntax in the \u0027old\u0027 form).\n\n\u003cdhellmann\u003e stevemar: the script form is useful for things that aren\u0027t python modules, but we have some hacks to \"do the right thing\" for scripts that are python modules","accounts_in_message":[],"_revision_number":2},{"id":"07b0af06669301f5b80ed549b67b0aacb2089f68","author":{"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"},"date":"2014-10-16 20:08:58.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f40a82e4b5abe7c82d0d47837e41d26712188765","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-10-20 00:20:49.000000000","message":"Patch Set 2: Code-Review-1\n\nBoth work and both are used. I don\u0027t see the need to change this.","accounts_in_message":[],"_revision_number":2},{"id":"5c756844e66a9d83aabc950432576dfd775083e1","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-20 05:24:00.000000000","message":"Abandoned\n\nfair enough, if it ever breaks or needs to be changed, we can do so.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7eb01b86798631ea31244f689679c3d8c3c50083","revisions":{"168254645dfc5761ac3a05e82f1c519e741a0748":{"kind":"REWORK","_number":1,"created":"2014-10-14 21:55:29.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/55/128455/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/55/128455/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/128455/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/128455/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/128455/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/128455/1"}}},"commit":{"parents":[{"commit":"34d00c2f3d2ac395b71d97c2e3e44d83ff4c769f","subject":"Use oslo.utils and oslo.serialization","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/34d00c2f3d2ac395b71d97c2e3e44d83ff4c769f"}]}],"author":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2014-10-14 21:52:38.000000000","tz":-240},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2014-10-14 21:54:51.000000000","tz":-240},"subject":"Set install_venv_common as a script, not a module","message":"Set install_venv_common as a script, not a module\n\ninstall_venv_common is not a module in oslo-incubator, but it\u0027s a\nscript, so let\u0027s call it that.\n\nChange-Id: I1cf846ec56865a9979f628f5c77d2bb689e10ffe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/168254645dfc5761ac3a05e82f1c519e741a0748"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/168254645dfc5761ac3a05e82f1c519e741a0748"}]},"branch":"refs/heads/master"},"7eb01b86798631ea31244f689679c3d8c3c50083":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2014-10-15 04:28:22.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/55/128455/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/55/128455/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/128455/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/128455/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/128455/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/128455/2"}}},"commit":{"parents":[{"commit":"802301ca1763043bf699a52043504ab71a4dbb3b","subject":"Use oslo.utils and oslo.serialization","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/802301ca1763043bf699a52043504ab71a4dbb3b"}]}],"author":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2014-10-14 21:52:38.000000000","tz":-240},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2014-10-15 04:28:22.000000000","tz":0},"subject":"Set install_venv_common as a script, not a module","message":"Set install_venv_common as a script, not a module\n\ninstall_venv_common is not a module in oslo-incubator, but it\u0027s a\nscript, so let\u0027s call it that.\n\nChange-Id: I1cf846ec56865a9979f628f5c77d2bb689e10ffe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7eb01b86798631ea31244f689679c3d8c3c50083"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7eb01b86798631ea31244f689679c3d8c3c50083"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
