)]}'
{"keystoneclient/v3/contrib/federation/mappings.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"8530ac7bda9a9a3f0675601a962af2d56071ef35","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        Utilize Identity API operation:"},{"line_number":47,"context_line":"        PUT /OS-FEDERATION/mappings/$mapping_id"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param mapping_id: user defined string identifier of the federation"},{"line_number":50,"context_line":"            mapping."},{"line_number":51,"context_line":"        :param rules: a JSON dictionary with list of mapping rules."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_fc30ddea","line":49,"updated":"2014-10-15 17:04:09.000000000","message":"what happens if the user doesn\u0027t provide a mapping_id? An id is generated?","commit_id":"28d518f937ea59747b71fed24bc3f93c16a79c99"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"be486e9359b65e614df2af685c189f2c22e247e6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        Utilize Identity API operation:"},{"line_number":47,"context_line":"        PUT /OS-FEDERATION/mappings/$mapping_id"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param mapping_id: user defined string identifier of the federation"},{"line_number":50,"context_line":"            mapping."},{"line_number":51,"context_line":"        :param rules: a JSON dictionary with list of mapping rules."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_68809cbf","line":49,"in_reply_to":"baa201ad_fc30ddea","updated":"2014-10-16 06:43:56.000000000","message":"it\u0027s written \u0027user defined string\u0027 so user must provide it. No, no id is generated. id is name, no uuid (or anything else).","commit_id":"28d518f937ea59747b71fed24bc3f93c16a79c99"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"f93592128974bd30b57b25d493f59e9215c056b4","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param mapping_id: user defined string identifier of the federation"},{"line_number":50,"context_line":"            mapping."},{"line_number":51,"context_line":"        :param rules: a JSON dictionary with list of mapping rules."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Example of the ``rules`` parameter::"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_afdb807a","line":51,"updated":"2014-10-15 14:16:06.000000000","message":"This seems incorrect now. It\u0027s no longer a dictionary containing a list of rules. Its a list or dictionaries.","commit_id":"28d518f937ea59747b71fed24bc3f93c16a79c99"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"be486e9359b65e614df2af685c189f2c22e247e6","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param mapping_id: user defined string identifier of the federation"},{"line_number":50,"context_line":"            mapping."},{"line_number":51,"context_line":"        :param rules: a JSON dictionary with list of mapping rules."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Example of the ``rules`` parameter::"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_feeff484","line":51,"in_reply_to":"baa201ad_1262ef3d","updated":"2014-10-16 06:43:56.000000000","message":"*) yes, example is valid, whereas it should be a list. I will fix that. Good eye, David.\n*) Rodrigo: It\u0027s in the kwargs because the keystoneclient logic is that everything that should be requests body should be put in kwargs. Now, imagine I wouldn\u0027t put anything about rules parameter in the docstring. How would you guess that rules should be passed here, and what would be its format?\n*) yes, your example is correct","commit_id":"28d518f937ea59747b71fed24bc3f93c16a79c99"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"8530ac7bda9a9a3f0675601a962af2d56071ef35","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param mapping_id: user defined string identifier of the federation"},{"line_number":50,"context_line":"            mapping."},{"line_number":51,"context_line":"        :param rules: a JSON dictionary with list of mapping rules."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Example of the ``rules`` parameter::"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_9c70b1a5","line":51,"in_reply_to":"baa201ad_1262ef3d","updated":"2014-10-15 17:04:09.000000000","message":"actually I don\u0027t understand why the param is **kwargs and here is stated there is \"rules\".\n\nHow can I call this method?\n\nmappings.create(\u0027an_id\u0027, rules\u003d[...])\n\n?","commit_id":"28d518f937ea59747b71fed24bc3f93c16a79c99"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"87b80f6760c2f601c8530d12312ecf9ce3dd331c","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param mapping_id: user defined string identifier of the federation"},{"line_number":50,"context_line":"            mapping."},{"line_number":51,"context_line":"        :param rules: a JSON dictionary with list of mapping rules."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Example of the ``rules`` parameter::"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_1262ef3d","line":51,"in_reply_to":"baa201ad_afdb807a","updated":"2014-10-15 15:00:12.000000000","message":"it should be a list","commit_id":"28d518f937ea59747b71fed24bc3f93c16a79c99"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cc103903f9cef201eaa843e0afa3a78995d0b06f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        :param rules: a list of mapping rules."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        Example of the ``rules`` parameter::"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"             ["},{"line_number":116,"context_line":"                 {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_cccdbe88","line":113,"updated":"2014-10-19 23:58:10.000000000","message":"there\u0027s an extra blank line here.","commit_id":"d5ec4f725030538d44ecf914e48e12e1ee7bfa78"}]}