)]}'
{"id":"openstack%2Fpython-keystoneclient~12909","triplet_id":"openstack%2Fpython-keystoneclient~master~Ie22e8e5288573268165ed06049978195955f8ca6","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1050091","hashtags":[],"change_id":"Ie22e8e5288573268165ed06049978195955f8ca6","subject":"Fixed httplib2 mocking (bug 1050091, bug 1050097)","status":"MERGED","created":"2012-09-12 22:35:43.000000000","updated":"2012-09-29 19:13:29.000000000","submitted":"2012-09-29 19:13:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8a3531f73fb016f747e37b9999c5f343fe5bf4da","_number":12909,"virtual_id_number":12909,"owner":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-09-29 19:13:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-09-12 22:39:34.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2012-09-13 02:39:24.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-09-12 22:36:33.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2012-09-29 18:39:26.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-09-29 18:39:26.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2012-09-29 19:13:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c15b710541a7b07e944936d60ca828eeeebfe6b3","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-09-12 22:36:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"348eb4d2afa2b73f854c98db577e877b9958f73d","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2012-09-12 22:36:39.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"e5bcf4c23647238c28bd37ae9d266a4c50ba5027","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-09-12 22:39:34.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"31137a2b4e3206ff7179bddc30f40f6399eba3fe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 23:11:51.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12909/2/check/gate-python-keystoneclient-merge/208 : SUCCESS\n- http://logs.openstack.org/12909/2/check/gate-python-keystoneclient-docs/60 : SUCCESS\n- http://logs.openstack.org/12909/2/check/gate-python-keystoneclient-pep8/204 : SUCCESS\n- http://logs.openstack.org/12909/2/check/gate-python-keystoneclient-python26/136 : SUCCESS\n- http://logs.openstack.org/12909/2/check/gate-python-keystoneclient-python27/138 : SUCCESS\n- http://logs.openstack.org/12909/2/check/gate-tempest-devstack-vm/11403 : SUCCESS\n- http://logs.openstack.org/12909/2/check/gate-tempest-devstack-vm-cinder/1384 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"2a3d6798889ca6a0aa91755af04adf8f7b1df7a4","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-09-13 02:39:24.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"28ef89add6a333bd9da62855afc4cdc0ff808451","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-09-27 06:03:01.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"6ba447f82debb95d51a5586a0e5f0f326e41be8a","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-09-27 06:03:01.000000000","message":"Patch Set 2:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"385d9c8efca681b20db3a613972512b8a446ae4a","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-09-27 06:38:15.000000000","message":"Patch Set 2: Restored","accounts_in_message":[],"_revision_number":2},{"id":"ec2e0de29b3a7b113a12f00ac14ae34495589240","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-29 18:39:26.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1be553e0db566c5d8fa23f8471252d994e22f523","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-09-29 18:39:26.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"65841f0c05b3f44b695da711008036bb2a4d1bda","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-29 19:13:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"9aa2068512e481937a170f977b292e6138ece2e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-29 19:13:29.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12909/2/gate/gate-python-keystoneclient-merge/272 : SUCCESS\n- http://logs.openstack.org/12909/2/gate/gate-python-keystoneclient-docs/124 : SUCCESS\n- http://logs.openstack.org/12909/2/gate/gate-python-keystoneclient-pep8/268 : SUCCESS\n- http://logs.openstack.org/12909/2/gate/gate-python-keystoneclient-python26/200 : SUCCESS\n- http://logs.openstack.org/12909/2/gate/gate-python-keystoneclient-python27/202 : SUCCESS\n- http://logs.openstack.org/12909/2/gate/gate-tempest-devstack-vm/13311 : SUCCESS\n- http://logs.openstack.org/12909/2/gate/gate-tempest-devstack-vm-cinder/3290 : SUCCESS\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"59917278d7a2e3760d6229f874b2a953bf2b28cc","revisions":{"72665057f76a533d65392aef31468b14fc97dbcc":{"kind":"REWORK","_number":1,"created":"2012-09-12 22:35:43.000000000","uploader":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"ref":"refs/changes/09/12909/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/09/12909/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/12909/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/12909/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/12909/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/12909/1"}}},"commit":{"parents":[{"commit":"0a8c96073c3dd76df346c262898303f6fb7435d6","subject":"Merge \"fixing pep8 formatting for 1.0.1+ pep8\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0a8c96073c3dd76df346c262898303f6fb7435d6"}]}],"author":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2012-09-12 22:34:09.000000000","tz":-300},"committer":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2012-09-12 22:35:25.000000000","tz":-300},"subject":"Fixed httplib2 mocking (bug 105009, bug 1050097)","message":"Fixed httplib2 mocking (bug 105009, bug 1050097)\n\n- 204 No Content should be mocked with empty response bodies\n- Content-Type headers should not be mocked with empty response bodies\n- httplib2 would never return None as a response body\n- The Identity API never expects a req/resp body with a string value of \"null\"\n\nChange-Id: Ie22e8e5288573268165ed06049978195955f8ca6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/72665057f76a533d65392aef31468b14fc97dbcc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/72665057f76a533d65392aef31468b14fc97dbcc"}]},"branch":"refs/heads/master"},"59917278d7a2e3760d6229f874b2a953bf2b28cc":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2012-09-12 22:36:33.000000000","uploader":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"ref":"refs/changes/09/12909/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/09/12909/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/12909/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/12909/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/12909/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/12909/2"}}},"commit":{"parents":[{"commit":"0a8c96073c3dd76df346c262898303f6fb7435d6","subject":"Merge \"fixing pep8 formatting for 1.0.1+ pep8\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0a8c96073c3dd76df346c262898303f6fb7435d6"}]}],"author":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2012-09-12 22:34:09.000000000","tz":-300},"committer":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2012-09-12 22:36:08.000000000","tz":-300},"subject":"Fixed httplib2 mocking (bug 1050091, bug 1050097)","message":"Fixed httplib2 mocking (bug 1050091, bug 1050097)\n\n- 204 No Content should be mocked with empty response bodies\n- Content-Type headers should not be mocked with empty response bodies\n- httplib2 would never return None as a response body\n- The Identity API never expects a req/resp body with a string value of \"null\"\n\nChange-Id: Ie22e8e5288573268165ed06049978195955f8ca6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/59917278d7a2e3760d6229f874b2a953bf2b28cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/59917278d7a2e3760d6229f874b2a953bf2b28cc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}