)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d3ea1b1a67009e1c7c14839ad991570aa6eb72df","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xu (Simon) Chen \u003cxchenum@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-19 00:22:09 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"close pipes of popen"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current way of using popen does not close pipes properly,"},{"line_number":10,"context_line":"and therefore keystone process hits open file limit eventually."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_eec35a36","line":7,"updated":"2014-10-19 15:25:04.000000000","message":"nit: s/popen/Popen","commit_id":"e1688a3e4ba8927a9e480f2ee9a9b3f5d69b1fd5"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d3ea1b1a67009e1c7c14839ad991570aa6eb72df","unresolved":false,"context_lines":[{"line_number":7,"context_line":"close pipes of popen"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current way of using popen does not close pipes properly,"},{"line_number":10,"context_line":"and therefore keystone process hits open file limit eventually."},{"line_number":11,"context_line":"Passing close_fds\u003dTrue seems to have solved the problem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ife452ab6843c1af5eb39debb8db453e45f78cba9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_cec69649","line":10,"updated":"2014-10-19 15:25:04.000000000","message":"keystoneclient?","commit_id":"e1688a3e4ba8927a9e480f2ee9a9b3f5d69b1fd5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3de3825e9491bb9ebbf93c552a3ab8a9dfd3d758","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current way of using popen does not close pipes properly,"},{"line_number":10,"context_line":"and therefore keystone process hits open file limit eventually."},{"line_number":11,"context_line":"Passing close_fds\u003dTrue seems to have solved the problem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ife452ab6843c1af5eb39debb8db453e45f78cba9"},{"line_number":14,"context_line":"Closes-Bug: 1382906"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_f1e6db43","line":11,"updated":"2014-10-19 19:20:15.000000000","message":"close_fds doesn\u0027t close pipes either: https://docs.python.org/2/library/subprocess.html#subprocess.Popen","commit_id":"e1688a3e4ba8927a9e480f2ee9a9b3f5d69b1fd5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2a238cd290e8042b2e24561e3a327e7931ccfebe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set close_fds\u003dTrue in Popen"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current way of using Popen does not close pipes properly,"},{"line_number":10,"context_line":"and therefore long-running keystone processes, which depends on"},{"line_number":11,"context_line":"keystoneclient.common.cms for data sigining, eventually hit"},{"line_number":12,"context_line":"open file limit and stop working. Passing close_fds\u003dTrue seems"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa7fdbe_c178bb91","line":9,"updated":"2014-10-23 01:08:42.000000000","message":"Can you point to some documentation that says that the way we\u0027re using Popen is incorrect?","commit_id":"f00755f04ac5298c86620592af1c65acb0f021ae"},{"author":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"change_message_id":"06284e67a7857057fb3e5f37415c4ed1ce129efa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set close_fds\u003dTrue in Popen"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current way of using Popen does not close pipes properly,"},{"line_number":10,"context_line":"and therefore long-running keystone processes, which depends on"},{"line_number":11,"context_line":"keystoneclient.common.cms for data sigining, eventually hit"},{"line_number":12,"context_line":"open file limit and stop working. Passing close_fds\u003dTrue seems"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa7fdbe_e145bf70","line":9,"in_reply_to":"9aa7fdbe_c178bb91","updated":"2014-10-23 01:52:43.000000000","message":"Here is some discussion regarding whether close_fds should be set to True: http://bugs.python.org/issue7213\n\nEmpirically, I built keystone from recent trunk, which depends on keystoneclient 0.11.1. My keystone process froze very quickly, and \"lsof -p\" reveals a ton of open pipes. After toggling close_fds to True, I haven\u0027t seen this problem any more.","commit_id":"f00755f04ac5298c86620592af1c65acb0f021ae"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d4ba457b1346309ceaaac399bf948c9b5f729780","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set close_fds\u003dTrue in Popen"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current way of using Popen does not close pipes properly,"},{"line_number":10,"context_line":"and therefore long-running keystone processes, which depends on"},{"line_number":11,"context_line":"keystoneclient.common.cms for data sigining, eventually hit"},{"line_number":12,"context_line":"open file limit and stop working. Passing close_fds\u003dTrue seems"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa7fdbe_526ac5b3","line":9,"in_reply_to":"9aa7fdbe_e145bf70","updated":"2014-10-23 16:06:13.000000000","message":"this resulted in jaypipes seeing a bunch of hanging openssl -sign processes as well. this patch fixed it","commit_id":"f00755f04ac5298c86620592af1c65acb0f021ae"}],"keystoneclient/common/cms.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3de3825e9491bb9ebbf93c552a3ab8a9dfd3d758","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                                \u0027-nocerts\u0027, \u0027-noattr\u0027,"},{"line_number":337,"context_line":"                                \u0027-md\u0027, \u0027sha256\u0027, ],"},{"line_number":338,"context_line":"                               stdin\u003dsubprocess.PIPE,"},{"line_number":339,"context_line":"                               stdout\u003dsubprocess.PIPE,"},{"line_number":340,"context_line":"                               stderr\u003dsubprocess.PIPE)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    output, err, retcode \u003d _process_communicate_handle_oserror("}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_b1dc5376","line":339,"updated":"2014-10-19 19:20:15.000000000","message":"also use close_fds here?","commit_id":"e1688a3e4ba8927a9e480f2ee9a9b3f5d69b1fd5"}]}