)]}'
{"id":"openstack%2Fpython-keystoneclient~129456","triplet_id":"openstack%2Fpython-keystoneclient~master~Ife452ab6843c1af5eb39debb8db453e45f78cba9","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1382906","hashtags":[],"change_id":"Ife452ab6843c1af5eb39debb8db453e45f78cba9","subject":"set close_fds\u003dTrue in Popen","status":"MERGED","created":"2014-10-19 03:04:30.000000000","updated":"2014-10-24 10:57:44.000000000","submitted":"2014-10-23 17:12:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"46499cd7bc3a3f916ddfc15d522a2c273c4411d3","_number":129456,"virtual_id_number":129456,"owner":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},{"value":0,"_account_id":161,"name":"Kevin Bringard","email":"kevinbri@cisco.com","username":"kbringard"},{"value":0,"date":"2014-10-23 01:52:43.000000000","_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},{"value":2,"date":"2014-10-23 17:12:00.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-10-24 10:39:05.000000000","post_submit":true,"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"recommended":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"all":[{"value":1,"date":"2014-10-21 06:53:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},{"value":0,"_account_id":161,"name":"Kevin Bringard","email":"kevinbri@cisco.com","username":"kbringard"},{"value":0,"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":2,"date":"2014-10-23 16:06:13.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2014-10-23 16:06:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":2,"date":"2014-10-21 01:26:28.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":1,"date":"2014-10-21 01:52:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},{"value":1,"date":"2014-10-21 07:22:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2014-10-21 01:56:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":-1,"date":"2014-10-23 01:08:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},{"value":0,"date":"2014-10-21 00:55:14.000000000","_account_id":161,"name":"Kevin Bringard","email":"kevinbri@cisco.com","username":"kbringard"},{"value":0,"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":1,"date":"2014-10-23 16:06:13.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"date":"2014-10-21 00:55:03.000000000","_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":161,"name":"Kevin Bringard","email":"kevinbri@cisco.com","username":"kbringard"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-19 15:25:04.000000000","updated_by":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"reviewer":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"state":"REVIEWER"},{"updated":"2014-10-21 00:55:03.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2014-10-21 00:55:14.000000000","updated_by":{"_account_id":161,"name":"Kevin Bringard","email":"kevinbri@cisco.com","username":"kbringard"},"reviewer":{"_account_id":161,"name":"Kevin Bringard","email":"kevinbri@cisco.com","username":"kbringard"},"state":"REVIEWER"},{"updated":"2014-10-21 01:26:28.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2014-10-21 01:52:19.000000000","updated_by":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"reviewer":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"state":"REVIEWER"},{"updated":"2014-10-21 01:56:15.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2014-10-21 06:53:43.000000000","updated_by":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"reviewer":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"state":"REVIEWER"},{"updated":"2014-10-21 07:22:17.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2014-10-23 01:08:42.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-10-23 16:06:13.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-10-23 17:12:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-10-24 10:39:05.000000000","updated_by":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"reviewer":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"state":"REVIEWER"}],"messages":[{"id":"49f691ea1ec9a9ec3bfea22ffeba2060f3aa1c63","author":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"date":"2014-10-19 03:04:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3308026ef560b74508bb8d0c9d2d470206f7d476","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-19 04:05:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/56/129456/1/check/gate-python-keystoneclient-pep8/55738c3 : SUCCESS in 1m 51s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/56/129456/1/check/gate-python-keystoneclient-docs/574cff3/doc/build/html/ : SUCCESS in 2m 10s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/56/129456/1/check/gate-python-keystoneclient-python26/f59437a : SUCCESS in 1m 51s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/56/129456/1/check/gate-python-keystoneclient-python27/520fbdc : SUCCESS in 1m 54s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/56/129456/1/check/gate-python-keystoneclient-python33/739e123 : SUCCESS in 3m 52s\n- check-tempest-dsvm-full http://logs.openstack.org/56/129456/1/check/check-tempest-dsvm-full/3f57bc3 : SUCCESS in 57m 28s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/129456/1/check/check-tempest-dsvm-postgres-full/edb7681 : SUCCESS in 43m 58s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/129456/1/check/check-tempest-dsvm-neutron-full/75131f4 : SUCCESS in 53m 27s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/129456/1/check/check-tempest-dsvm-neutron-heat-slow/c0859a0 : SUCCESS in 21m 25s\n- check-grenade-dsvm http://logs.openstack.org/56/129456/1/check/check-grenade-dsvm/5a30014 : SUCCESS in 49m 33s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/129456/1/check/gate-tempest-dsvm-large-ops/0ad626f : SUCCESS in 22m 10s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/129456/1/check/gate-tempest-dsvm-neutron-large-ops/3de10ed : SUCCESS in 18m 55s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/56/129456/1/check/check-tempest-dsvm-full-icehouse/7500e20 : SUCCESS in 47m 29s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/56/129456/1/check/check-tempest-dsvm-neutron-icehouse/874d9e2 : SUCCESS in 55m 38s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/129456/1/check/check-devstack-dsvm-cells/b49f17c : SUCCESS in 13m 22s","accounts_in_message":[],"_revision_number":1},{"id":"dff15dc866e2d70b6f2c3e0e8675802a45e16020","author":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"date":"2014-10-19 04:22:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"29be4e6fa6783afe2dc5ca360cb76b0b88e751ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-19 05:21:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/56/129456/2/check/gate-python-keystoneclient-pep8/08516a1 : SUCCESS in 1m 41s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/56/129456/2/check/gate-python-keystoneclient-docs/d7dd4c9/doc/build/html/ : SUCCESS in 2m 22s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/56/129456/2/check/gate-python-keystoneclient-python26/e102dde : SUCCESS in 1m 50s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/56/129456/2/check/gate-python-keystoneclient-python27/4381948 : SUCCESS in 1m 54s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/56/129456/2/check/gate-python-keystoneclient-python33/fd82e7b : SUCCESS in 3m 47s\n- check-tempest-dsvm-full http://logs.openstack.org/56/129456/2/check/check-tempest-dsvm-full/a465a1a : SUCCESS in 51m 09s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/129456/2/check/check-tempest-dsvm-postgres-full/edf08cc : SUCCESS in 58m 10s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/129456/2/check/check-tempest-dsvm-neutron-full/0c43b65 : SUCCESS in 56m 22s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/129456/2/check/check-tempest-dsvm-neutron-heat-slow/ce43c71 : SUCCESS in 18m 43s\n- check-grenade-dsvm http://logs.openstack.org/56/129456/2/check/check-grenade-dsvm/29f2945 : SUCCESS in 49m 24s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/129456/2/check/gate-tempest-dsvm-large-ops/12cdaa4 : SUCCESS in 18m 32s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/129456/2/check/gate-tempest-dsvm-neutron-large-ops/5f468ca : SUCCESS in 18m 01s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/56/129456/2/check/check-tempest-dsvm-full-icehouse/31c1b5b : SUCCESS in 47m 57s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/56/129456/2/check/check-tempest-dsvm-neutron-icehouse/81501f4 : SUCCESS in 55m 05s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/129456/2/check/check-devstack-dsvm-cells/2b463a5 : SUCCESS in 14m 13s","accounts_in_message":[],"_revision_number":2},{"id":"d3ea1b1a67009e1c7c14839ad991570aa6eb72df","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2014-10-19 15:25:04.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3de3825e9491bb9ebbf93c552a3ab8a9dfd3d758","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-10-19 19:20:15.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"0986af0dc4400c8c792abd01b37bbb3014528453","author":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"date":"2014-10-20 12:49:51.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"acd06124b71402fd1e5614f1b26d504cb2330c6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-20 14:28:48.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/56/129456/3/check/gate-python-keystoneclient-pep8/261bc4f : SUCCESS in 2m 23s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/56/129456/3/check/gate-python-keystoneclient-docs/8b11e06/doc/build/html/ : SUCCESS in 2m 29s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/56/129456/3/check/gate-python-keystoneclient-python26/1b29540 : SUCCESS in 2m 34s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/56/129456/3/check/gate-python-keystoneclient-python27/ca78988 : SUCCESS in 1m 47s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/56/129456/3/check/gate-python-keystoneclient-python33/dae35e5 : SUCCESS in 3m 59s\n- check-tempest-dsvm-full http://logs.openstack.org/56/129456/3/check/check-tempest-dsvm-full/918d757 : SUCCESS in 51m 16s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/129456/3/check/check-tempest-dsvm-postgres-full/dbc57be : SUCCESS in 54m 37s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/129456/3/check/check-tempest-dsvm-neutron-full/9ae3afe : SUCCESS in 1h 10m 05s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/129456/3/check/check-tempest-dsvm-neutron-heat-slow/e4342f0 : SUCCESS in 18m 37s\n- check-grenade-dsvm http://logs.openstack.org/56/129456/3/check/check-grenade-dsvm/555acd4 : SUCCESS in 52m 26s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/129456/3/check/gate-tempest-dsvm-large-ops/3c3d29b : SUCCESS in 23m 10s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/129456/3/check/gate-tempest-dsvm-neutron-large-ops/a4e5fac : SUCCESS in 20m 21s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/56/129456/3/check/check-tempest-dsvm-full-icehouse/5d55a7d : SUCCESS in 51m 35s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/56/129456/3/check/check-tempest-dsvm-neutron-icehouse/9f33f09 : SUCCESS in 54m 43s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/129456/3/check/check-devstack-dsvm-cells/eb2dfaa : SUCCESS in 15m 55s","accounts_in_message":[],"_revision_number":3},{"id":"927d6fa3db2354951f15d16851106ff33265769b","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2014-10-21 01:26:28.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"147a01abefaabc3d7d58687bcd5c5144af5388d7","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-21 01:52:19.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"7465211a09bac63071d6976d81ce179032f79537","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2014-10-21 01:56:15.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"ce51569b00a77ad2c85327aa614ff911ad649f92","author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"date":"2014-10-21 06:53:43.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"fb8cb1148461b02d01bf02c5fbd9fb64633308fc","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2014-10-21 07:22:17.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"2a238cd290e8042b2e24561e3a327e7931ccfebe","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-10-23 01:08:42.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"06284e67a7857057fb3e5f37415c4ed1ce129efa","author":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"date":"2014-10-23 01:52:43.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nComments inline.","accounts_in_message":[],"_revision_number":3},{"id":"33a2fd6fabe805e759a407f441e6ac2f377b9109","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-23 16:06:13.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"d4ba457b1346309ceaaac399bf948c9b5f729780","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2014-10-23 16:06:13.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7360623551c7869bf54d064dcb831507ff0874a4","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2014-10-23 16:06:51.000000000","message":"Patch Set 3: Code-Review+1\n\nI have just verified that this does indeed fix a problem with openssl cms -sign processes being left open. After applying this patch (modified) to the stable/icehouse keystoneclient in our benchmark environment, we saw all 250+ openssl cms -sign processes disappear when running the benchmark with rally.\n\n-jay","accounts_in_message":[],"_revision_number":3},{"id":"f4bc38bb9555cf13b9be7f88591154a35407e6a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-23 17:12:00.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"31291ff7158c63f8eddb3aaebb3901761523bd32","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-23 17:12:00.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/56/129456/3/gate/gate-python-keystoneclient-docs/dd63079/doc/build/html/ : SUCCESS in 3m 03s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/56/129456/3/gate/gate-python-keystoneclient-pep8/a58ce87 : SUCCESS in 2m 22s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/56/129456/3/gate/gate-python-keystoneclient-python27/29ba0d6 : SUCCESS in 1m 41s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/56/129456/3/gate/gate-python-keystoneclient-python33/dedfd6a : SUCCESS in 4m 08s\n- gate-tempest-dsvm-full http://logs.openstack.org/56/129456/3/gate/gate-tempest-dsvm-full/f57b8da : SUCCESS in 50m 37s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/56/129456/3/gate/gate-tempest-dsvm-postgres-full/a53b722 : SUCCESS in 52m 30s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/56/129456/3/gate/gate-tempest-dsvm-neutron-full/50cf07d : SUCCESS in 1h 05m 34s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/129456/3/gate/gate-tempest-dsvm-neutron-heat-slow/56ef33f : SUCCESS in 21m 16s\n- gate-grenade-dsvm http://logs.openstack.org/56/129456/3/gate/gate-grenade-dsvm/5007341 : SUCCESS in 44m 16s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/129456/3/gate/gate-tempest-dsvm-large-ops/e9c06a9 : SUCCESS in 19m 18s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/129456/3/gate/gate-tempest-dsvm-neutron-large-ops/fe269de : SUCCESS in 20m 23s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/56/129456/3/gate/gate-python-keystoneclient-python26/34b06b6 : SUCCESS in 1m 49s\n- gate-devstack-dsvm-cells http://logs.openstack.org/56/129456/3/gate/gate-devstack-dsvm-cells/687b5a6 : SUCCESS in 14m 59s","accounts_in_message":[],"_revision_number":3},{"id":"f7ccec3636f3896bb3f267ac036274484cef69bd","author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"date":"2014-10-24 10:39:05.000000000","message":"Patch Set 3:\n\n@Jay what is stable/icehouse keystoneclient  ?","accounts_in_message":[],"_revision_number":3},{"id":"ad10af5d2c312c2067bbb49c28a000f856a9ac0d","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2014-10-24 10:57:44.000000000","message":"Patch Set 3:\n\nAlan, I goofed and thought keystone middleware was in keystone package, not keystoneclient, for Icehouse... :) Sorry!\n\n-jay","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f00755f04ac5298c86620592af1c65acb0f021ae","revisions":{"683e94427565ba2a86b46032c6b2e8d64ccca3cb":{"kind":"REWORK","_number":1,"created":"2014-10-19 03:04:30.000000000","uploader":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"ref":"refs/changes/56/129456/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/56/129456/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/1"}}},"commit":{"parents":[{"commit":"88cc4b6b91c3481040cb30c5e26fc911e4a52c88","subject":"Merge \"Explicit complaint about old OpenSSL when testing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/88cc4b6b91c3481040cb30c5e26fc911e4a52c88"}]}],"author":{"name":"Xu (Simon) Chen","email":"xchenum@gmail.com","date":"2014-10-19 03:00:01.000000000","tz":-240},"committer":{"name":"Xu (Simon) Chen","email":"xchenum@gmail.com","date":"2014-10-19 03:04:28.000000000","tz":-240},"subject":"close pipes of popen","message":"close pipes of popen\n\nThe current way of using popen does not close pipes properly,\nand therefore keystone process hits open file limit eventually.\nPassing close_fds\u003dTrue seems to have solved the problem.\n\nChange-Id: Ife452ab6843c1af5eb39debb8db453e45f78cba9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/683e94427565ba2a86b46032c6b2e8d64ccca3cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/683e94427565ba2a86b46032c6b2e8d64ccca3cb"}]},"branch":"refs/heads/master"},"e1688a3e4ba8927a9e480f2ee9a9b3f5d69b1fd5":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2014-10-19 04:22:37.000000000","uploader":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"ref":"refs/changes/56/129456/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/56/129456/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/2"}}},"commit":{"parents":[{"commit":"88cc4b6b91c3481040cb30c5e26fc911e4a52c88","subject":"Merge \"Explicit complaint about old OpenSSL when testing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/88cc4b6b91c3481040cb30c5e26fc911e4a52c88"}]}],"author":{"name":"Xu (Simon) Chen","email":"xchenum@gmail.com","date":"2014-10-19 03:00:01.000000000","tz":-240},"committer":{"name":"Xu (Simon) Chen","email":"xchenum@gmail.com","date":"2014-10-19 04:22:09.000000000","tz":-240},"subject":"close pipes of popen","message":"close pipes of popen\n\nThe current way of using popen does not close pipes properly,\nand therefore keystone process hits open file limit eventually.\nPassing close_fds\u003dTrue seems to have solved the problem.\n\nChange-Id: Ife452ab6843c1af5eb39debb8db453e45f78cba9\nCloses-Bug: 1382906\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e1688a3e4ba8927a9e480f2ee9a9b3f5d69b1fd5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e1688a3e4ba8927a9e480f2ee9a9b3f5d69b1fd5"}]},"branch":"refs/heads/master"},"f00755f04ac5298c86620592af1c65acb0f021ae":{"kind":"REWORK","_number":3,"created":"2014-10-20 12:49:51.000000000","uploader":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"ref":"refs/changes/56/129456/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/56/129456/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/129456/3"}}},"commit":{"parents":[{"commit":"88cc4b6b91c3481040cb30c5e26fc911e4a52c88","subject":"Merge \"Explicit complaint about old OpenSSL when testing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/88cc4b6b91c3481040cb30c5e26fc911e4a52c88"}]}],"author":{"name":"Xu (Simon) Chen","email":"xchenum@gmail.com","date":"2014-10-19 03:00:01.000000000","tz":-240},"committer":{"name":"Xu (Simon) Chen","email":"xchenum@gmail.com","date":"2014-10-20 12:48:00.000000000","tz":-240},"subject":"set close_fds\u003dTrue in Popen","message":"set close_fds\u003dTrue in Popen\n\nThe current way of using Popen does not close pipes properly,\nand therefore long-running keystone processes, which depends on\nkeystoneclient.common.cms for data sigining, eventually hit\nopen file limit and stop working. Passing close_fds\u003dTrue seems\nto have solved the problem.\n\nChange-Id: Ife452ab6843c1af5eb39debb8db453e45f78cba9\nCloses-Bug: 1382906\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f00755f04ac5298c86620592af1c65acb0f021ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f00755f04ac5298c86620592af1c65acb0f021ae"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}