)]}'
{"id":"openstack%2Fpython-keystoneclient~12946","triplet_id":"openstack%2Fpython-keystoneclient~master~Ic22c565e92010afd89c8573c375919215b70d73d","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1046837","hashtags":[],"change_id":"Ic22c565e92010afd89c8573c375919215b70d73d","subject":"add a new HTTPClient attr for setting the original IP","status":"MERGED","created":"2012-09-13 13:49:22.000000000","updated":"2012-10-24 02:36:13.000000000","submitted":"2012-10-24 02:36:13.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"01748cf23f783e64e82cf47f4067ad1650c29131","_number":12946,"virtual_id_number":12946,"owner":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-10-24 02:36:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-10-22 15:47:58.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":2,"date":"2012-10-24 00:11:39.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":1,"date":"2012-10-24 00:11:39.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-10-16 16:48:05.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2012-10-19 19:34:53.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2012-10-24 00:11:39.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2012-10-24 02:36:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6e563a7d36c4a9e6718a7d766ee4b2e463120e30","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 14:06:31.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12946/1/check/gate-python-keystoneclient-merge/210 : SUCCESS\n- http://logs.openstack.org/12946/1/check/gate-python-keystoneclient-docs/62 : SUCCESS\n- http://logs.openstack.org/12946/1/check/gate-python-keystoneclient-pep8/206 : SUCCESS\n- http://logs.openstack.org/12946/1/check/gate-python-keystoneclient-python26/138 : SUCCESS\n- http://logs.openstack.org/12946/1/check/gate-python-keystoneclient-python27/140 : SUCCESS\n- http://logs.openstack.org/12946/1/check/gate-tempest-devstack-vm/11500 : SUCCESS\n- http://logs.openstack.org/12946/1/check/gate-tempest-devstack-vm-cinder/1480 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"13e5eed1f9d864bae91774affc1b14dc86d4b586","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-09-24 16:11:10.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nIonut, Thanks for submitting through gerrit!\n\n(sorry for the mispelling of your name, don\u0027t know how to get the proper glyphs)","accounts_in_message":[],"_revision_number":1},{"id":"015f3fca01c4536226e89cc6def170825af198af","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-09-27 21:33:26.000000000","message":"Patch Set 1:\n\nI don\u0027t want to approve without at least asking two questions:\n\n1) Would X-Forwarded-For be more appropriate?\n\n2) On the keystone side, I assume you\u0027re only using this header if the request is actually coming from dashboard? Otherwise, users could falsify the X-Forwarded-For header on direct requests. I don\u0027t think it\u0027s a security issue as long as it\u0027s clear when you can/can\u0027t trust the header.","accounts_in_message":[],"_revision_number":1},{"id":"1dae7a48c9e81cf6d5b8756e4cbf067238b345db","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-09-29 18:40:06.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\npending answers to Dolph\u0027s questions","accounts_in_message":[],"_revision_number":1},{"id":"5d56db2ce040f623ba67be4aa227abc639364cb3","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-01 12:16:53.000000000","message":"Patch Set 1:\n\nThanks, Dolph, those are good points.\n\n1. I\u0027m not sure about this. It would mean we\u0027d have to do more processing. When setting the header we\u0027d have to be careful not to overwrite an existing header, but append to HTTP list instead. Then we\u0027d have to do the same processing on the receiving end to extract the original IP from the HTTP list in X-Forwarded-For.\n\n2. Sure. I think the easiest way to accomplish this is to check that the REMOTE_ADDR is not 127.0.0.1. If it is, then ignore it and use the other header instead. I guess I should add some documentation in keystone-client itself about this.","accounts_in_message":[],"_revision_number":1},{"id":"4732032243eb964fca21cfafa6c24c635de7a4e2","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-10-01 19:22:17.000000000","message":"Patch Set 1:\n\n1. regardless of what the code looks like, is XFF more appropriate for the behavior you\u0027re looking for?","accounts_in_message":[],"_revision_number":1},{"id":"ad74e998b318cf9a3195fbef8b89ea7584f144cf","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-10-01 19:23:15.000000000","message":"Patch Set 1:\n\n2. I don\u0027t want to make hard coded assumptions about deployment, but 127.0.0.1 is a logical default value, as long as it can be overridden.","accounts_in_message":[],"_revision_number":1},{"id":"1c6b53413320a7fbf7be6185d20e9998df37bb75","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-10-09 06:03:01.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"01f936dc6651b4316a5b6a8b279983008b87fc72","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-10-09 06:03:01.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"664b8f21d7cdc2d15152ef41837bf5c74dab9fd5","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-16 15:21:49.000000000","message":"Patch Set 1: Restored\n\ni have a new commit","accounts_in_message":[],"_revision_number":1},{"id":"5c45542ba9e59ea7c64b965c5ce61cc17f2e2e11","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-16 15:22:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d2547a685781d01841512c90163e65e42b1dda56","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-16 15:24:03.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"fc85aaf19d743ce49d256c96a800e3a16147418b","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-16 15:28:01.000000000","message":"Patch Set 3:\n\nSo it seems there\u0027s a new draft ietf proposal for a Forwarded header [1]. I think we should use that. I\u0027ve added a unit test, too.\n\nThe other security issues that were raised will need to be solved on keystone\u0027s side. i.e. figuring out where the request came from (dashboard or not) and which remote_ip to consider as belonging to the user.\n\n[1] http://tools.ietf.org/html/draft-ietf-appsawg-http-forwarded-10","accounts_in_message":[],"_revision_number":3},{"id":"6d6fc34bb6dcab4cf0d83daef0c0e90fba5d8992","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-16 15:36:37.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"aceffef63ce28585b0328c1e367d3785c43dfdfa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-16 15:54:55.000000000","message":"Patch Set 4: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12946/4/check/gate-python-keystoneclient-merge/355 : SUCCESS\n- http://logs.openstack.org/12946/4/check/gate-python-keystoneclient-docs/207 : SUCCESS\n- http://logs.openstack.org/12946/4/check/gate-python-keystoneclient-pep8/351 : SUCCESS\n- http://logs.openstack.org/12946/4/check/gate-python-keystoneclient-python26/283 : SUCCESS\n- http://logs.openstack.org/12946/4/check/gate-python-keystoneclient-python27/285 : SUCCESS\n- http://logs.openstack.org/12946/4/check/gate-tempest-devstack-vm/14648 : SUCCESS\n- http://logs.openstack.org/12946/4/check/gate-tempest-devstack-vm-cinder/4627 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"9bbc571d975e0cab0e025148176ae9adc4bc80e9","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-10-16 16:48:05.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\nCool; I like the new header as well","accounts_in_message":[],"_revision_number":4},{"id":"f8c3a6ec8c8c1b05af75988a918cd170b46093c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-19 19:34:53.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":4},{"id":"bfebde84c40d0ebfbdfe8e5b6cb26918c753c545","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-10-19 19:34:53.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"6d30ae3bc5489b49c70edf51bd4d8e194944949b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-19 19:54:30.000000000","message":"Patch Set 4: Fails\n\nBuild failed\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"e7d56e2cea0a32429b5a8c278fd9db4c41b5449f","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-22 15:30:58.000000000","message":"Patch Set 4:\n\nseems to fail because of: https://bugs.launchpad.net/keystone/+bug/1068851","accounts_in_message":[],"_revision_number":4},{"id":"22194a8c447daf1120938b9ba7df523b712f4deb","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-22 15:31:56.000000000","message":"Patch Set 4:\n\nurgh, ignore my previous comment. I was talking about a different review request.","accounts_in_message":[],"_revision_number":4},{"id":"f5a1c3e516088d15a8bf421487b4e8e2e09f3c9b","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-22 15:45:18.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"2dbf637360bc18baddd10811bfb67a083962f143","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-22 15:47:35.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"af059c60768182d309d8256507440ee2fd5907cd","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-22 15:47:58.000000000","message":"Patch Set 6:\n\nrebased on top of the current master","accounts_in_message":[],"_revision_number":6},{"id":"8f710fd7ed5c6dd85a3eee3602aae3de0c6b81e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-22 16:26:54.000000000","message":"Patch Set 6: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12946/6/check/gate-python-keystoneclient-merge/366 : SUCCESS\n- http://logs.openstack.org/12946/6/check/gate-python-keystoneclient-docs/217 : SUCCESS\n- http://logs.openstack.org/12946/6/check/gate-python-keystoneclient-pep8/361 : SUCCESS\n- http://logs.openstack.org/12946/6/check/gate-python-keystoneclient-python26/293 : SUCCESS\n- http://logs.openstack.org/12946/6/check/gate-python-keystoneclient-python27/295 : SUCCESS\n- http://logs.openstack.org/12946/6/check/gate-tempest-devstack-vm/14893 : SUCCESS\n- http://logs.openstack.org/12946/6/check/gate-tempest-devstack-vm-cinder/4887 : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"7a374c69a6f15855e74b77d11fd7de7be8e1484d","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2012-10-24 00:11:39.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"c6f1a74e18ef66cf08daf2fcb8e2247759fd7628","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-24 00:11:54.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":6},{"id":"bca73340f08dfe0e710abbeee1070f7c2fd01593","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-24 02:36:13.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6},{"id":"7010f49fe5d5f6cc30447230a2266b6369a5ceaa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-24 02:36:13.000000000","message":"Patch Set 6: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12946/6/gate/gate-python-keystoneclient-merge/372 : SUCCESS\n- http://logs.openstack.org/12946/6/gate/gate-python-keystoneclient-docs/223 : SUCCESS\n- http://logs.openstack.org/12946/6/gate/gate-python-keystoneclient-pep8/367 : SUCCESS\n- http://logs.openstack.org/12946/6/gate/gate-python-keystoneclient-python26/299 : SUCCESS\n- http://logs.openstack.org/12946/6/gate/gate-python-keystoneclient-python27/301 : SUCCESS\n- http://logs.openstack.org/12946/6/gate/gate-tempest-devstack-vm/15239 : SUCCESS\n- http://logs.openstack.org/12946/6/gate/gate-tempest-devstack-vm-cinder/5233 : SUCCESS\n","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"56a4e4bd7da1353684d34e5a9817b88501e41d8c","revisions":{"d2aee41fa94257a4299ffcd3da7791a05085e98f":{"kind":"REWORK","_number":1,"created":"2012-09-13 13:49:22.000000000","uploader":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"ref":"refs/changes/46/12946/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/12946/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/1"}}},"commit":{"parents":[{"commit":"0a8c96073c3dd76df346c262898303f6fb7435d6","subject":"Merge \"fixing pep8 formatting for 1.0.1+ pep8\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0a8c96073c3dd76df346c262898303f6fb7435d6"}]}],"author":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-09-13 13:45:40.000000000","tz":120},"committer":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-09-13 13:49:09.000000000","tz":120},"subject":"add a new HTTPClient attr for setting the original IP","message":"add a new HTTPClient attr for setting the original IP\n\nThe original IP is useful in cases where keystoneclient is used by a\ndifferent openstack component and we need to know who made the original\nrequest. Otherwise it gets overwritten by e.g. Dashboard\u0027s host\u0027s IP.\n\nbug 1046837\n\nChange-Id: Ic22c565e92010afd89c8573c375919215b70d73d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d2aee41fa94257a4299ffcd3da7791a05085e98f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d2aee41fa94257a4299ffcd3da7791a05085e98f"}]},"branch":"refs/heads/master"},"0dc2c8e45d779a313af40dad31ae80c9e96ec8b8":{"kind":"REWORK","_number":2,"created":"2012-10-16 15:22:00.000000000","uploader":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"ref":"refs/changes/46/12946/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/12946/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/2"}}},"commit":{"parents":[{"commit":"fc4cbcae39ee094cef2c3cce4c96813eb9affcff","subject":"Merge \"Added \u0027service_id\u0027 column to endpoint-list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fc4cbcae39ee094cef2c3cce4c96813eb9affcff"}]}],"author":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-09-13 13:45:40.000000000","tz":120},"committer":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-10-16 15:21:11.000000000","tz":120},"subject":"add a new HTTPClient attr for setting the original IP","message":"add a new HTTPClient attr for setting the original IP\n\nThe original IP is useful in cases where keystoneclient is used by a\ndifferent openstack component and we need to know who made the original\nrequest. Otherwise it gets overwritten by e.g. Dashboard\u0027s host\u0027s IP.\n\nbug 1046837\n\nChange-Id: Ic22c565e92010afd89c8573c375919215b70d73d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0dc2c8e45d779a313af40dad31ae80c9e96ec8b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0dc2c8e45d779a313af40dad31ae80c9e96ec8b8"}]},"branch":"refs/heads/master"},"74355f640ea224a621cdbccb2c8fe44d6e7ba02c":{"kind":"REWORK","_number":3,"created":"2012-10-16 15:24:03.000000000","uploader":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"ref":"refs/changes/46/12946/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/12946/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/3"}}},"commit":{"parents":[{"commit":"fc4cbcae39ee094cef2c3cce4c96813eb9affcff","subject":"Merge \"Added \u0027service_id\u0027 column to endpoint-list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fc4cbcae39ee094cef2c3cce4c96813eb9affcff"}]}],"author":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-09-13 13:45:40.000000000","tz":120},"committer":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-10-16 15:23:50.000000000","tz":120},"subject":"add a new HTTPClient attr for setting the original IP","message":"add a new HTTPClient attr for setting the original IP\n\nThe original IP is useful in cases where keystoneclient is used by a\ndifferent openstack component and we need to know who made the original\nrequest. Otherwise it gets overwritten by e.g. Dashboard\u0027s host\u0027s IP.\n\nbug 1046837\n\nChange-Id: Ic22c565e92010afd89c8573c375919215b70d73d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/74355f640ea224a621cdbccb2c8fe44d6e7ba02c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/74355f640ea224a621cdbccb2c8fe44d6e7ba02c"}]},"branch":"refs/heads/master"},"d1b01c1d04b34396e34e353c66ad1b6e0356889f":{"kind":"REWORK","_number":4,"created":"2012-10-16 15:36:37.000000000","uploader":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"ref":"refs/changes/46/12946/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/12946/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/4"}}},"commit":{"parents":[{"commit":"fc4cbcae39ee094cef2c3cce4c96813eb9affcff","subject":"Merge \"Added \u0027service_id\u0027 column to endpoint-list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fc4cbcae39ee094cef2c3cce4c96813eb9affcff"}]}],"author":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-09-13 13:45:40.000000000","tz":120},"committer":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-10-16 15:36:18.000000000","tz":120},"subject":"add a new HTTPClient attr for setting the original IP","message":"add a new HTTPClient attr for setting the original IP\n\nThe original IP is useful in cases where keystoneclient is used by a\ndifferent openstack component and we need to know who made the original\nrequest. Otherwise it gets overwritten by e.g. Dashboard\u0027s host\u0027s IP.\n\nbug 1046837\n\nChange-Id: Ic22c565e92010afd89c8573c375919215b70d73d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d1b01c1d04b34396e34e353c66ad1b6e0356889f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d1b01c1d04b34396e34e353c66ad1b6e0356889f"}]},"branch":"refs/heads/master"},"dc29da00ab3986fde5fce0910171c660f80e9c10":{"kind":"REWORK","_number":5,"created":"2012-10-22 15:45:18.000000000","uploader":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"ref":"refs/changes/46/12946/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/12946/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/5"}}},"commit":{"parents":[{"commit":"e04b0e16ae4ef3c63cedf05979cca93595f34f28","subject":"Merge \"use mock context managers instead of decorators+functions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e04b0e16ae4ef3c63cedf05979cca93595f34f28"}]}],"author":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-09-13 13:45:40.000000000","tz":120},"committer":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-10-22 15:45:08.000000000","tz":120},"subject":"add a new HTTPClient attr for setting the original IP","message":"add a new HTTPClient attr for setting the original IP\n\nThe original IP is useful in cases where keystoneclient is used by a\ndifferent openstack component and we need to know who made the original\nrequest. Otherwise it gets overwritten by e.g. Dashboard\u0027s host\u0027s IP.\n\nbug 1046837\n\nChange-Id: Ic22c565e92010afd89c8573c375919215b70d73d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/dc29da00ab3986fde5fce0910171c660f80e9c10"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/dc29da00ab3986fde5fce0910171c660f80e9c10"}]},"branch":"refs/heads/master"},"56a4e4bd7da1353684d34e5a9817b88501e41d8c":{"kind":"REWORK","_number":6,"created":"2012-10-22 15:47:35.000000000","uploader":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"ref":"refs/changes/46/12946/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/12946/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/12946/6"}}},"commit":{"parents":[{"commit":"e04b0e16ae4ef3c63cedf05979cca93595f34f28","subject":"Merge \"use mock context managers instead of decorators+functions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e04b0e16ae4ef3c63cedf05979cca93595f34f28"}]}],"author":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-09-13 13:45:40.000000000","tz":120},"committer":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-10-22 15:47:26.000000000","tz":120},"subject":"add a new HTTPClient attr for setting the original IP","message":"add a new HTTPClient attr for setting the original IP\n\nThe original IP is useful in cases where keystoneclient is used by a\ndifferent openstack component and we need to know who made the original\nrequest. Otherwise it gets overwritten by e.g. Dashboard\u0027s host\u0027s IP.\n\nbug 1046837\n\nChange-Id: Ic22c565e92010afd89c8573c375919215b70d73d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/56a4e4bd7da1353684d34e5a9817b88501e41d8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/56a4e4bd7da1353684d34e5a9817b88501e41d8c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}