)]}'
{"keystoneclient/session.py":[{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"4295fb6921271f538715a658c389ed49464bf5a8","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":375,"context_line":"                msg \u003d \u0027SSL exception connecting to %s: %s. You \u0027"},{"line_number":376,"context_line":"                \u0027can retry passing the --insecure argument: \u0027"},{"line_number":377,"context_line":"                \u0027keystone --insecure %s.\u0027 % (url, str(e), method)"},{"line_number":378,"context_line":"                raise exceptions.SSLError(msg)"},{"line_number":379,"context_line":"            except requests.exceptions.Timeout:"},{"line_number":380,"context_line":"                msg \u003d \u0027Request to %s timed out\u0027 % url"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_21eb35b1","line":377,"updated":"2014-10-23 15:13:22.000000000","message":"method here is probably POST. Is that important?\n\nYou don\u0027t need the str(e), just e, as the %s will convert it to a string.","commit_id":"d1ab12bbbcf3e3557e14765b73c0af906b3bc344"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"6753eb246f225ba8fc321319afae1fc7579f5abf","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":375,"context_line":"                msg \u003d \u0027SSL exception connecting to %s: %s. You \u0027"},{"line_number":376,"context_line":"                \u0027can retry passing the --insecure argument: \u0027"},{"line_number":377,"context_line":"                \u0027keystone --insecure %s.\u0027 % (url, str(e), method)"},{"line_number":378,"context_line":"                raise exceptions.SSLError(msg)"},{"line_number":379,"context_line":"            except requests.exceptions.Timeout:"},{"line_number":380,"context_line":"                msg \u003d \u0027Request to %s timed out\u0027 % url"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_57e9d7e4","line":377,"in_reply_to":"9aa7fdbe_21eb35b1","updated":"2014-10-23 15:48:43.000000000","message":"Done","commit_id":"d1ab12bbbcf3e3557e14765b73c0af906b3bc344"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"81ca2667a886d1aa78f8c00b690a191c65ffbb4b","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                resp \u003d self.session.request(method, url, **kwargs)"},{"line_number":374,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":375,"context_line":"                msg \u003d \u0027SSL exception connecting to %s: %s. You can retry \u0027"},{"line_number":376,"context_line":"                \u0027by passing the --insecure argument\u0027 % (url, e)"},{"line_number":377,"context_line":"                raise exceptions.SSLError(msg)"},{"line_number":378,"context_line":"            except requests.exceptions.Timeout:"},{"line_number":379,"context_line":"                msg \u003d \u0027Request to %s timed out\u0027 % url"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_d6a74da5","line":376,"updated":"2014-10-27 12:17:20.000000000","message":"this assumes that the person is running from the CLI where --insecure is a thing. This may not be the case.","commit_id":"acc898407a9257f555c462923a5d4ac24133059a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2abf14862964d595fe5c4767e62fcf6cd8096fbe","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                resp \u003d self.session.request(method, url, **kwargs)"},{"line_number":374,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":375,"context_line":"                msg \u003d \u0027SSL exception connecting to %s: %s. You can retry \u0027"},{"line_number":376,"context_line":"                \u0027by passing the --insecure argument\u0027 % (url, e)"},{"line_number":377,"context_line":"                raise exceptions.SSLError(msg)"},{"line_number":378,"context_line":"            except requests.exceptions.Timeout:"},{"line_number":379,"context_line":"                msg \u003d \u0027Request to %s timed out\u0027 % url"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_723dbf2a","line":376,"in_reply_to":"9aa7fdbe_d6a74da5","updated":"2014-10-27 19:43:59.000000000","message":"++ think that leaving just the exception message will be enough.","commit_id":"acc898407a9257f555c462923a5d4ac24133059a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9e6d629572eaedb5c222c5c324ed008c05f54169","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            try:"},{"line_number":374,"context_line":"                resp \u003d self.session.request(method, url, **kwargs)"},{"line_number":375,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":376,"context_line":"                msg \u003d \u0027SSL exception connecting to %s: %s\u0027 % (url, e)"},{"line_number":377,"context_line":"                raise exceptions.SSLError(msg)"},{"line_number":378,"context_line":"            except requests.exceptions.Timeout:"},{"line_number":379,"context_line":"                msg \u003d _(\u0027Request to %s timed out\u0027) % url"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_fecefb81","line":376,"updated":"2014-11-24 19:13:15.000000000","message":"Just out of curiosity, but why remove the translation here? \n\n    error_stuff \u003d (url, e)\n    msg \u003d _(\u0027SSL exception connecting to %s: %s\u0027) % error_stuff\n\nor does that not work as expected?","commit_id":"12adacb949102696b85564168a1f11d4d6cbd6e5"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9b6e6af9d13dad4e10c889d67c8aa0b6931fce74","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            try:"},{"line_number":374,"context_line":"                resp \u003d self.session.request(method, url, **kwargs)"},{"line_number":375,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":376,"context_line":"                msg \u003d \u0027SSL exception connecting to %s: %s\u0027 % (url, e)"},{"line_number":377,"context_line":"                raise exceptions.SSLError(msg)"},{"line_number":378,"context_line":"            except requests.exceptions.Timeout:"},{"line_number":379,"context_line":"                msg \u003d _(\u0027Request to %s timed out\u0027) % url"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_5bc2bc53","line":376,"in_reply_to":"5a890539_09146f42","updated":"2014-11-24 22:01:06.000000000","message":"++ thanks for the feedback, will fix it.","commit_id":"12adacb949102696b85564168a1f11d4d6cbd6e5"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e7152d8ebb16b9b45a70a0071af45ae5c0a726c1","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            try:"},{"line_number":374,"context_line":"                resp \u003d self.session.request(method, url, **kwargs)"},{"line_number":375,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":376,"context_line":"                msg \u003d \u0027SSL exception connecting to %s: %s\u0027 % (url, e)"},{"line_number":377,"context_line":"                raise exceptions.SSLError(msg)"},{"line_number":378,"context_line":"            except requests.exceptions.Timeout:"},{"line_number":379,"context_line":"                msg \u003d _(\u0027Request to %s timed out\u0027) % url"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_09146f42","line":376,"in_reply_to":"5a890539_fecefb81","updated":"2014-11-24 19:37:35.000000000","message":"If the string to be formatted has two string variable, it is better to use a dict to pass the argument. Because during the translation, the order of the string on other languages may change.","commit_id":"12adacb949102696b85564168a1f11d4d6cbd6e5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b944884ab249cf8468a54d38b5451c56295e2782","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            try:"},{"line_number":374,"context_line":"                resp \u003d self.session.request(method, url, **kwargs)"},{"line_number":375,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":376,"context_line":"                msg \u003d _(\u0027SSL exception connecting to %(url)s:\u0027"},{"line_number":377,"context_line":"                        \u0027%(error)s\u0027) % {\u0027url\u0027: url, \u0027error\u0027: e}"},{"line_number":378,"context_line":"                raise exceptions.SSLError(msg)"},{"line_number":379,"context_line":"            except requests.exceptions.Timeout:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_dea1ad96","line":376,"updated":"2014-12-30 20:29:42.000000000","message":"there should be a space here.","commit_id":"6b163dc64f4afc67eac4d2d859c49c2edc979f9e"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"47887b6dd6895f42fd9b6372e22529cb0af546c4","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            try:"},{"line_number":374,"context_line":"                resp \u003d self.session.request(method, url, **kwargs)"},{"line_number":375,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":376,"context_line":"                msg \u003d _(\u0027SSL exception connecting to %(url)s:\u0027"},{"line_number":377,"context_line":"                        \u0027%(error)s\u0027) % {\u0027url\u0027: url, \u0027error\u0027: e}"},{"line_number":378,"context_line":"                raise exceptions.SSLError(msg)"},{"line_number":379,"context_line":"            except requests.exceptions.Timeout:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_24aad871","line":376,"in_reply_to":"3a961159_dea1ad96","updated":"2015-01-10 04:40:25.000000000","message":"Done","commit_id":"6b163dc64f4afc67eac4d2d859c49c2edc979f9e"}],"keystoneclient/tests/unit/test_session.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0339435ad33942d74c4de8019f1a6e26da9ee94a","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        session \u003d client_session.Session()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # The exception should contain the URL and details about the SSL error"},{"line_number":231,"context_line":"        msg \u003d \u0027SSL exception connecting to \u0027 + self.TEST_URL + \u0027: \u0027 + error"},{"line_number":232,"context_line":"        self.assertRaisesRegexp(exceptions.SSLError,"},{"line_number":233,"context_line":"                                msg,"},{"line_number":234,"context_line":"                                session.get,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_9485caae","line":231,"updated":"2015-03-20 05:59:24.000000000","message":"nit: instead of concatenating string, could use the same approach in the main code to look cleaner: \u0027SSL exception connecting .. \u0027 % values","commit_id":"e5ab69f0377f4d546a9dca5b5d3091719f19c3b6"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"bd09f430244f102a1bdd1566b6852415f8c6bcb2","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        session \u003d client_session.Session()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # The exception should contain the URL and details about the SSL error"},{"line_number":231,"context_line":"        msg \u003d \u0027SSL exception connecting to \u0027 + self.TEST_URL + \u0027: \u0027 + error"},{"line_number":232,"context_line":"        self.assertRaisesRegexp(exceptions.SSLError,"},{"line_number":233,"context_line":"                                msg,"},{"line_number":234,"context_line":"                                session.get,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_605246df","line":231,"in_reply_to":"9a80dd14_37bfbbd1","updated":"2015-03-20 13:02:27.000000000","message":"Done\n\nAlso using _() since we may be running these tests in a different lang environment","commit_id":"e5ab69f0377f4d546a9dca5b5d3091719f19c3b6"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"568c62e6e755d3e6a95165b34eff61df95888303","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        session \u003d client_session.Session()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # The exception should contain the URL and details about the SSL error"},{"line_number":231,"context_line":"        msg \u003d \u0027SSL exception connecting to \u0027 + self.TEST_URL + \u0027: \u0027 + error"},{"line_number":232,"context_line":"        self.assertRaisesRegexp(exceptions.SSLError,"},{"line_number":233,"context_line":"                                msg,"},{"line_number":234,"context_line":"                                session.get,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_bb3e2389","line":231,"in_reply_to":"9a80dd14_605246df","updated":"2015-03-20 16:52:45.000000000","message":"never seen we used _() for tests, but I guess it doesn\u0027t hurt","commit_id":"e5ab69f0377f4d546a9dca5b5d3091719f19c3b6"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"fa3d98f684f3d74a602c0465de38dcf488c0aaca","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        session \u003d client_session.Session()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # The exception should contain the URL and details about the SSL error"},{"line_number":231,"context_line":"        msg \u003d \u0027SSL exception connecting to \u0027 + self.TEST_URL + \u0027: \u0027 + error"},{"line_number":232,"context_line":"        self.assertRaisesRegexp(exceptions.SSLError,"},{"line_number":233,"context_line":"                                msg,"},{"line_number":234,"context_line":"                                session.get,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_37bfbbd1","line":231,"in_reply_to":"9a80dd14_9485caae","updated":"2015-03-20 09:15:53.000000000","message":"++","commit_id":"e5ab69f0377f4d546a9dca5b5d3091719f19c3b6"}]}