)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"7e4c51f67f6488f71190cac396b2b67ba71a6b21","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Does not accept blank password for updation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"keystone has this bug, when we update user password using keystone user-password-update and does not specify any"},{"line_number":10,"context_line":"password when prompted, it accepts it and user can no longer login using blank password or old password."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1391116"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_1138abd3","line":9,"updated":"2015-02-14 06:14:15.000000000","message":"This is too long, subsequent lines in commit msg should be wrapped at 72 characters. \n\nYou can use this for reference: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"17b55ffce40d5015e9fbbd41f9ad8b370a4f5327"}],"creds":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"2376a6ceea3c37d6e633ee1ff00a3d21561ef5fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a890539_54b474d0","updated":"2014-11-14 10:11:59.000000000","message":"I think this file got here by error :)","commit_id":"7e57724a3dac0d4f84b6144c696dbf7568a60f0c"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cd511304ff3a578a7fec927f9ddc56c87a42500e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export OS_USERNAME\u003dadmin"},{"line_number":2,"context_line":"export OS_PASSWORD\u003dadmin"},{"line_number":3,"context_line":"export OS_TENANT_NAME\u003dadmin"},{"line_number":4,"context_line":"export OS_AUTH_URL\u003dhttp://keystone:35357/v2.0/"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a890539_3a0d0f38","line":2,"updated":"2014-11-14 08:30:50.000000000","message":"This file should not be uploaded.","commit_id":"7e57724a3dac0d4f84b6144c696dbf7568a60f0c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"48ae7cb6cf188cc9a7189035d85f5e72e3afed99","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export OS_USERNAME\u003dadmin"},{"line_number":2,"context_line":"export OS_PASSWORD\u003dadmin"},{"line_number":3,"context_line":"export OS_TENANT_NAME\u003dadmin"},{"line_number":4,"context_line":"export OS_AUTH_URL\u003dhttp://keystone:35357/v2.0/"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a890539_fa546700","line":2,"in_reply_to":"5a890539_3a0d0f38","updated":"2014-11-14 08:34:09.000000000","message":"It got committed by mistake. I will keep in mind from next time.","commit_id":"7e57724a3dac0d4f84b6144c696dbf7568a60f0c"}],"keystoneclient/v2_0/shell.py":[{"author":{"_account_id":13314,"name":"juigil-kishore","email":"juigil.kishore@hp.com","username":"kishorju"},"change_message_id":"1ceb3e64037437c214d3962ff70c7ba5e86b655b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a890539_bae01f97","updated":"2014-11-14 09:04:21.000000000","message":"Instead of using two IF blocks, you can condense it into one","commit_id":"7e57724a3dac0d4f84b6144c696dbf7568a60f0c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"25f9a0918ddf1cc4c3b9f3c7a8bfc579d9ee437b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a890539_da4c0ba1","in_reply_to":"5a890539_bae01f97","updated":"2014-11-14 09:07:43.000000000","message":"I think user must know the exact reason of failure. By adding non-blank in error message makes in clear to the user.","commit_id":"7e57724a3dac0d4f84b6144c696dbf7568a60f0c"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"2376a6ceea3c37d6e633ee1ff00a3d21561ef5fd","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    user \u003d utils.find_resource(kc.users, args.user)"},{"line_number":143,"context_line":"    new_passwd \u003d args.passwd or utils.prompt_for_password()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    if new_passwd is \"\":"},{"line_number":146,"context_line":"        msg \u003d (_(\"\\nPlease enter non-blank password using the --pass option \""},{"line_number":147,"context_line":"                 \"or using the prompt\"))"},{"line_number":148,"context_line":"        sys.exit(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_b412f354","line":145,"updated":"2014-11-14 10:11:59.000000000","message":"Sorry, I totally dislike using \u0027is \"\"\u0027 for string comparation. Please check out http://stackoverflow.com/questions/1504717/why-does-comparing-strings-in-python-using-either-or-is-sometimes-produce .","commit_id":"7e57724a3dac0d4f84b6144c696dbf7568a60f0c"},{"author":{"_account_id":7926,"name":"vishal yadav","email":"vyadav@advaoptical.com","username":"vishalcdac"},"change_message_id":"a4f460427ec82d70086f5530bec8ae1805639887","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    user \u003d utils.find_resource(kc.users, args.user)"},{"line_number":143,"context_line":"    new_passwd \u003d args.passwd or utils.prompt_for_password()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    if new_passwd is \"\":"},{"line_number":146,"context_line":"        msg \u003d (_(\"\\nPlease enter non-blank password using the --pass option \""},{"line_number":147,"context_line":"                 \"or using the prompt\"))"},{"line_number":148,"context_line":"        sys.exit(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_b9490462","line":145,"in_reply_to":"5a890539_b412f354","updated":"2014-11-14 13:59:25.000000000","message":"1) Agree with Boris. To avoid any confusion use \u0027\u003d\u003d \"\"\u0027 for comparison with empty string. More specifically \u0027is\u0027 will result \u0027false\u0027 when values of 2 different objects are same.\n\n2) Logically it makes sense to move non-empty string check after checking that user has selected --pass or prompt option.","commit_id":"7e57724a3dac0d4f84b6144c696dbf7568a60f0c"},{"author":{"_account_id":7926,"name":"vishal yadav","email":"vyadav@advaoptical.com","username":"vishalcdac"},"change_message_id":"a4f460427ec82d70086f5530bec8ae1805639887","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    if new_passwd is \"\":"},{"line_number":146,"context_line":"        msg \u003d (_(\"\\nPlease enter non-blank password using the --pass option \""},{"line_number":147,"context_line":"                 \"or using the prompt\"))"},{"line_number":148,"context_line":"        sys.exit(msg)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    if new_passwd is None:"},{"line_number":151,"context_line":"        msg \u003d (_(\"\\nPlease specify password using the --pass option \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_59458015","line":148,"updated":"2014-11-14 13:59:25.000000000","message":"This could be moved out of IF blocks. Common code for both IF blocks.","commit_id":"7e57724a3dac0d4f84b6144c696dbf7568a60f0c"},{"author":{"_account_id":7926,"name":"vishal yadav","email":"vyadav@advaoptical.com","username":"vishalcdac"},"change_message_id":"bc773169357af10cba9f995baf729adbf9faae03","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    if new_passwd is \"\":"},{"line_number":146,"context_line":"        msg \u003d (_(\"\\nPlease enter non-blank password using the --pass option \""},{"line_number":147,"context_line":"                 \"or using the prompt\"))"},{"line_number":148,"context_line":"        sys.exit(msg)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    if new_passwd is None:"},{"line_number":151,"context_line":"        msg \u003d (_(\"\\nPlease specify password using the --pass option \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_89605fa6","line":148,"in_reply_to":"5a890539_59458015","updated":"2014-11-15 12:13:01.000000000","message":"Ignore above comment. Not valid.","commit_id":"7e57724a3dac0d4f84b6144c696dbf7568a60f0c"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"1e6b2d18637907017ab21b7277b9b9ddf5a18144","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \"\"\"Update user password.\"\"\""},{"line_number":142,"context_line":"    user \u003d utils.find_resource(kc.users, args.user)"},{"line_number":143,"context_line":"    new_passwd \u003d args.passwd or utils.prompt_for_password()"},{"line_number":144,"context_line":"    if new_passwd is None or new_passwd \u003d\u003d \"\":"},{"line_number":145,"context_line":"        msg \u003d (_(\"\\nPlease specify password using the --pass option \""},{"line_number":146,"context_line":"                 \"or using the prompt\"))"},{"line_number":147,"context_line":"        sys.exit(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_fcea35d7","line":144,"updated":"2014-12-05 06:37:05.000000000","message":"What about \u0027if not new_passwd\u0027 ?","commit_id":"17b55ffce40d5015e9fbbd41f9ad8b370a4f5327"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"7e4c51f67f6488f71190cac396b2b67ba71a6b21","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \"\"\"Update user password.\"\"\""},{"line_number":142,"context_line":"    user \u003d utils.find_resource(kc.users, args.user)"},{"line_number":143,"context_line":"    new_passwd \u003d args.passwd or utils.prompt_for_password()"},{"line_number":144,"context_line":"    if new_passwd is None or new_passwd \u003d\u003d \"\":"},{"line_number":145,"context_line":"        msg \u003d (_(\"\\nPlease specify password using the --pass option \""},{"line_number":146,"context_line":"                 \"or using the prompt\"))"},{"line_number":147,"context_line":"        sys.exit(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_113fcbb6","line":144,"in_reply_to":"1a930d6b_f75a3e4f","updated":"2015-02-14 06:14:15.000000000","message":"I\u0027d be okay as is too, it is easier to read positive check.","commit_id":"17b55ffce40d5015e9fbbd41f9ad8b370a4f5327"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"61c973790a3f821271cdb217241fd025972b7002","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \"\"\"Update user password.\"\"\""},{"line_number":142,"context_line":"    user \u003d utils.find_resource(kc.users, args.user)"},{"line_number":143,"context_line":"    new_passwd \u003d args.passwd or utils.prompt_for_password()"},{"line_number":144,"context_line":"    if new_passwd is None or new_passwd \u003d\u003d \"\":"},{"line_number":145,"context_line":"        msg \u003d (_(\"\\nPlease specify password using the --pass option \""},{"line_number":146,"context_line":"                 \"or using the prompt\"))"},{"line_number":147,"context_line":"        sys.exit(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_f75a3e4f","line":144,"in_reply_to":"3a961159_81895771","updated":"2015-01-21 11:45:42.000000000","message":"my vote is \n\nif not new_passwd:","commit_id":"17b55ffce40d5015e9fbbd41f9ad8b370a4f5327"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"3d77035cf16f88b064b6c7670ee1dbce3db407bf","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \"\"\"Update user password.\"\"\""},{"line_number":142,"context_line":"    user \u003d utils.find_resource(kc.users, args.user)"},{"line_number":143,"context_line":"    new_passwd \u003d args.passwd or utils.prompt_for_password()"},{"line_number":144,"context_line":"    if new_passwd is None or new_passwd \u003d\u003d \"\":"},{"line_number":145,"context_line":"        msg \u003d (_(\"\\nPlease specify password using the --pass option \""},{"line_number":146,"context_line":"                 \"or using the prompt\"))"},{"line_number":147,"context_line":"        sys.exit(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_81895771","line":144,"in_reply_to":"5a890539_fcea35d7","updated":"2015-01-14 09:26:58.000000000","message":"++, 1 more variant:\n\nnew_passwd in (None, \"\")","commit_id":"17b55ffce40d5015e9fbbd41f9ad8b370a4f5327"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"2d46a851c3445b605e74cd9a3b1fd11e0827cd6c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \"\"\"Update user password.\"\"\""},{"line_number":142,"context_line":"    user \u003d utils.find_resource(kc.users, args.user)"},{"line_number":143,"context_line":"    new_passwd \u003d args.passwd or utils.prompt_for_password()"},{"line_number":144,"context_line":"    if new_passwd is None or new_passwd \u003d\u003d \"\":"},{"line_number":145,"context_line":"        msg \u003d (_(\"\\nPlease specify password using the --pass option \""},{"line_number":146,"context_line":"                 \"or using the prompt\"))"},{"line_number":147,"context_line":"        sys.exit(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_6838e7d4","line":144,"in_reply_to":"5a890539_fcea35d7","updated":"2015-01-13 17:30:34.000000000","message":"++, but I\u0027d be OK as-is","commit_id":"17b55ffce40d5015e9fbbd41f9ad8b370a4f5327"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"2fce3914f13e72df653b134b375aaf92b18907d4","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \"\"\"Update user password.\"\"\""},{"line_number":142,"context_line":"    user \u003d utils.find_resource(kc.users, args.user)"},{"line_number":143,"context_line":"    new_passwd \u003d args.passwd or utils.prompt_for_password()"},{"line_number":144,"context_line":"    if new_passwd is None or new_passwd \u003d\u003d \"\":"},{"line_number":145,"context_line":"        msg \u003d (_(\"\\nPlease specify password using the --pass option \""},{"line_number":146,"context_line":"                 \"or using the prompt\"))"},{"line_number":147,"context_line":"        sys.exit(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_187528cc","line":144,"updated":"2015-02-15 00:32:24.000000000","message":"From previous comments this should be \"if not new_passwd\"","commit_id":"5a29f6e1cb757e89faf09e16aeabf197bec78616"}]}