)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"774b99725137dc59f7432fb6a63fc0a49db2ad53","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Session was just a little weird as the loading interface between it and"},{"line_number":10,"context_line":"the auth plugins was tweaked in review between being merged. Now that we"},{"line_number":11,"context_line":"have a standard loadable interface implement that within session."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I25c83b4d189feaa6d6d618479acdd827cfbc4df8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_994b9a58","line":11,"updated":"2015-03-12 13:40:57.000000000","message":"(nit) this last sentence sounds like you wanted to say something more. Now that we have the interface what? or is is \u0027We now have a standard...\u0027","commit_id":"447f378e8d1109f429d5db9814bfe9a786c51178"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"0c719282b9befb14c006ef1c408c71e762e99e8a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Session was just a little weird as the loading interface between it and"},{"line_number":10,"context_line":"the auth plugins was tweaked in review between being merged. Now that we"},{"line_number":11,"context_line":"have a standard loadable interface implement that within session."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I25c83b4d189feaa6d6d618479acdd827cfbc4df8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_3e04e116","line":11,"in_reply_to":"9a80dd14_994b9a58","updated":"2015-03-16 05:14:28.000000000","message":"Done","commit_id":"447f378e8d1109f429d5db9814bfe9a786c51178"}],"keystoneclient/session.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"774b99725137dc59f7432fb6a63fc0a49db2ad53","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        # tuple as well as two values"},{"line_number":544,"context_line":"        try:"},{"line_number":545,"context_line":"            cert, key \u003d params[\u0027certfile\u0027]"},{"line_number":546,"context_line":"        except (KeyError, ValueError, TypeError):"},{"line_number":547,"context_line":"            pass"},{"line_number":548,"context_line":"        else:"},{"line_number":549,"context_line":"            params[\u0027certfile\u0027] \u003d cert"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_79bfc6fc","line":546,"updated":"2015-03-12 13:40:57.000000000","message":"What is the TypeError protecting against?","commit_id":"447f378e8d1109f429d5db9814bfe9a786c51178"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"774b99725137dc59f7432fb6a63fc0a49db2ad53","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        if certfile and keyfile:"},{"line_number":569,"context_line":"            # passing cert and key together is deprecated in favour of the"},{"line_number":570,"context_line":"            # requests lib form of having the cert and key as a tuple"},{"line_number":571,"context_line":"            kwargs.setdefault(\u0027cert\u0027, (certfile, keyfile))"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        return super(Session, cls).load_from_options(**kwargs)"},{"line_number":574,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_f9cad618","line":571,"updated":"2015-03-12 13:40:57.000000000","message":"Was this change in behavior intentional? In the old version cert would always get a new value if cert and key are specified. The new version will not change it if it already exists.","commit_id":"447f378e8d1109f429d5db9814bfe9a786c51178"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"774b99725137dc59f7432fb6a63fc0a49db2ad53","unresolved":false,"context_lines":[{"line_number":821,"context_line":"                            help\u003d\u0027Set request timeout (in seconds).\u0027)"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"    @classmethod"},{"line_number":824,"context_line":"    def load_from_argparse_arguments(cls, args, **kwargs):"},{"line_number":825,"context_line":"        \"\"\"Create a :py:class:`.Session` object from CLI arguments."},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        The CLI arguments must have been registered with"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_59b0428b","line":824,"updated":"2015-03-12 13:40:57.000000000","message":"Is this part of the public interface or do we make any guarantees about the names of this method or the other ones that changed?","commit_id":"447f378e8d1109f429d5db9814bfe9a786c51178"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"774b99725137dc59f7432fb6a63fc0a49db2ad53","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        :returns: A new session object."},{"line_number":833,"context_line":"        :rtype: :py:class:`.Session`"},{"line_number":834,"context_line":"        \"\"\""},{"line_number":835,"context_line":"        kwargs.setdefault(\u0027insecure\u0027, args.insecure)"},{"line_number":836,"context_line":"        kwargs.setdefault(\u0027cafile\u0027, args.os_cacert)"},{"line_number":837,"context_line":"        kwargs.setdefault(\u0027certfile\u0027, args.os_cert)"},{"line_number":838,"context_line":"        kwargs.setdefault(\u0027keyfile\u0027, args.os_key)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_b9f77e58","line":835,"updated":"2015-03-12 13:40:57.000000000","message":"Same behavior change here.","commit_id":"447f378e8d1109f429d5db9814bfe9a786c51178"}]}