)]}'
{"keystoneclient/tests/v3/test_simple_cert.py":[{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"28a10244821e9d5a181e547df93ab01833091faa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class SimpleCertTests(utils.TestCase, testresources.ResourcedTestCase):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    resources \u003d [(\u0027examples\u0027, client_fixtures.EXAMPLES_RESOURCE)]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_get_ca_certificate(self):"},{"line_number":25,"context_line":"        self.stub_url(\u0027GET\u0027, [\u0027OS-SIMPLE-CERT\u0027, \u0027ca\u0027],"},{"line_number":26,"context_line":"                      headers\u003d{\u0027Content-Type\u0027: \u0027application/x-pem-file\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_73e8d5b4","line":23,"updated":"2015-02-23 17:55:52.000000000","message":"Can you please add a test for multiple CA\u0027s since that\u0027s how it will be in production unless we use self signed cert","commit_id":"debe1343c301f1ec65c7a457ba6a88e68dab71e5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"32e99c8fab03c8bcec61c13141f91e325af4726c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class SimpleCertTests(utils.TestCase, testresources.ResourcedTestCase):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    resources \u003d [(\u0027examples\u0027, client_fixtures.EXAMPLES_RESOURCE)]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_get_ca_certificate(self):"},{"line_number":25,"context_line":"        self.stub_url(\u0027GET\u0027, [\u0027OS-SIMPLE-CERT\u0027, \u0027ca\u0027],"},{"line_number":26,"context_line":"                      headers\u003d{\u0027Content-Type\u0027: \u0027application/x-pem-file\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_2087d210","line":23,"in_reply_to":"ba7be1f8_73e8d5b4","updated":"2015-03-06 01:34:28.000000000","message":"I don\u0027t see the point of making this any more complicated. The client just returns whatever the server returns (a PEM file that might contain 1 or more certificates), so it doesn\u0027t matter to the client whether there\u0027s one or more certificates in the response.","commit_id":"debe1343c301f1ec65c7a457ba6a88e68dab71e5"}],"keystoneclient/v3/contrib/simple_cert.py":[{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"dae09df09a34789e5ca50df0e6e6774a157936d1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        resp, body \u003d self._client.get(\u0027/OS-SIMPLE-CERT/ca\u0027,"},{"line_number":30,"context_line":"                                      authenticated\u003dFalse)"},{"line_number":31,"context_line":"        return resp.text"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_certificates(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_562a162d","line":30,"updated":"2014-12-30 02:07:56.000000000","message":"Could I know the reason that you add authenticated\u003dFalse parameter?","commit_id":"f3b762ae7f1dbb7904cbb0df11a3f22b6b07f4dd"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"c85fa3fef4217fe9fc2b82c228b1f1e7e6998aab","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        resp, body \u003d self._client.get(\u0027/OS-SIMPLE-CERT/ca\u0027,"},{"line_number":30,"context_line":"                                      authenticated\u003dFalse)"},{"line_number":31,"context_line":"        return resp.text"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_certificates(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_a0db1e4e","line":30,"in_reply_to":"3a961159_07da1017","updated":"2015-02-13 16:11:08.000000000","message":"This is OK because \u0027certificates are a public resource and can be shared\" right?  -- source: https://github.com/openstack/keystone-specs/blob/master/api/v3/identity-api-v3-os-simple-certs-ext.rst#certificates","commit_id":"f3b762ae7f1dbb7904cbb0df11a3f22b6b07f4dd"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dd8b70e0375b46fa9b9f806236c6c6109cd1b861","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        resp, body \u003d self._client.get(\u0027/OS-SIMPLE-CERT/ca\u0027,"},{"line_number":30,"context_line":"                                      authenticated\u003dFalse)"},{"line_number":31,"context_line":"        return resp.text"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_certificates(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_07da1017","line":30,"in_reply_to":"3a961159_562a162d","updated":"2014-12-30 15:48:38.000000000","message":"The auth token middleware uses authenticated\u003dFalse ( http://git.openstack.org/cgit/openstack/keystonemiddleware/tree/keystonemiddleware/auth_token.py#n1631 ) , so when I changed the auth_token middleware to use this code ( https://review.openstack.org/#/c/144248/ ) the tests failed.","commit_id":"f3b762ae7f1dbb7904cbb0df11a3f22b6b07f4dd"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"21b01c5fa82192c4fdc43d5d349e2b87a3ed0df9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        resp, body \u003d self._client.get(\u0027/OS-SIMPLE-CERT/ca\u0027,"},{"line_number":30,"context_line":"                                      authenticated\u003dFalse)"},{"line_number":31,"context_line":"        return resp.text"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_certificates(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_f15b17f4","line":30,"in_reply_to":"da86d52c_20048e17","updated":"2015-02-14 06:42:01.000000000","message":"I agree not adding an authenticated argument, when keystoneclient is instantiated it will get a handle on the token already. We should just take care of the logic if token needs to be passed or not.\n\nThis looks good to me.","commit_id":"f3b762ae7f1dbb7904cbb0df11a3f22b6b07f4dd"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"435b5cac4f38a14848f3785c7a5c2aa8c9098242","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        resp, body \u003d self._client.get(\u0027/OS-SIMPLE-CERT/ca\u0027,"},{"line_number":30,"context_line":"                                      authenticated\u003dFalse)"},{"line_number":31,"context_line":"        return resp.text"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_certificates(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_20048e17","line":30,"in_reply_to":"da86d52c_a0db1e4e","updated":"2015-02-13 16:24:50.000000000","message":"the identity API spec generally doesn\u0027t talk about what authority is needed to access resources... although it looks like in this case it does so maybe a conforming server needs to leave these public.\n\nI could add authenticated\u003dFalse as a parameter on the method. (If I did that, then seems like we should have an authenticated parameter to every method in the keystoneclient API.)\n\nSince this is an extension, doesn\u0027t seem like it\u0027s worth it.","commit_id":"f3b762ae7f1dbb7904cbb0df11a3f22b6b07f4dd"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"d323a651f79c70df0f6d1af3ff4b19ed54356a6e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return resp.text"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_certificates(self):"},{"line_number":34,"context_line":"        \"\"\"Get certificates."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :returns: PEM-formatted string."},{"line_number":37,"context_line":"        :rtype: str"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_b108bfda","line":34,"updated":"2015-02-14 06:45:10.000000000","message":"NIT: Get \"signing\" certificates","commit_id":"f3b762ae7f1dbb7904cbb0df11a3f22b6b07f4dd"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7d5f498324514646c9a79dd30cef3ebd8dac0f97","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return resp.text"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_certificates(self):"},{"line_number":34,"context_line":"        \"\"\"Get certificates."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :returns: PEM-formatted string."},{"line_number":37,"context_line":"        :rtype: str"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_c43f16d5","line":34,"in_reply_to":"da86d52c_b108bfda","updated":"2015-02-23 01:37:51.000000000","message":"Done","commit_id":"f3b762ae7f1dbb7904cbb0df11a3f22b6b07f4dd"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"28a10244821e9d5a181e547df93ab01833091faa","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    def __init__(self, client):"},{"line_number":19,"context_line":"        self._client \u003d client"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def get_ca_certificate(self):"},{"line_number":22,"context_line":"        \"\"\"Get CA certificate."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        :returns: PEM-formatted string."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_b3a32d9d","line":21,"updated":"2015-02-23 17:55:52.000000000","message":"I believe it has to be ca_certificates.  Since we need ca_certificate chain.  Most of the public CAs\u0027 are chains","commit_id":"debe1343c301f1ec65c7a457ba6a88e68dab71e5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"32e99c8fab03c8bcec61c13141f91e325af4726c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    def __init__(self, client):"},{"line_number":19,"context_line":"        self._client \u003d client"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def get_ca_certificate(self):"},{"line_number":22,"context_line":"        \"\"\"Get CA certificate."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        :returns: PEM-formatted string."}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_804f9ebc","line":21,"in_reply_to":"ba7be1f8_b3a32d9d","updated":"2015-03-06 01:34:28.000000000","message":"Done","commit_id":"debe1343c301f1ec65c7a457ba6a88e68dab71e5"}]}