)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"87f1c3b5db7dc34cc02a390049626b7a1fed4550","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Basic AccessInfo plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Generally we want people to use the existing plugins to manage there"},{"line_number":10,"context_line":"authentication, however there are a number of existing services that"},{"line_number":11,"context_line":"know how to work with an AccessInfo object directly and either cache it"},{"line_number":12,"context_line":"or manipulate it manually."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa81d914_91d702bf","line":9,"updated":"2015-01-29 12:39:58.000000000","message":"s/there/their/ ?","commit_id":"1b914f3c697ec7851322c037841d3d418a7c93d9"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"295b7773beab953e1f338083db00f93e7cff2421","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Basic AccessInfo plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Generally we want people to use the existing plugins to manage there"},{"line_number":10,"context_line":"authentication, however there are a number of existing services that"},{"line_number":11,"context_line":"know how to work with an AccessInfo object directly and either cache it"},{"line_number":12,"context_line":"or manipulate it manually."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_531e5564","line":9,"in_reply_to":"fa81d914_91d702bf","updated":"2015-02-03 19:43:13.000000000","message":"Done","commit_id":"1b914f3c697ec7851322c037841d3d418a7c93d9"}],"keystoneclient/auth/identity/access.py":[{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"cbd129c2f19cb9c5ac9fde437d4c5f7988c85886","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @utils.positional()"},{"line_number":39,"context_line":"    def __init__(self, auth_ref, auth_url\u003dNone, reauthenticate\u003dFalse):"},{"line_number":40,"context_line":"        super(AccessInfoPlugin, self).__init__(auth_url\u003dauth_url,"},{"line_number":41,"context_line":"                                               reauthenticate\u003dreauthenticate)"},{"line_number":42,"context_line":"        self.auth_ref \u003d auth_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b91a14c4","line":39,"updated":"2015-01-05 03:26:15.000000000","message":"I think this object should not have \u0027reauthenticate\u0027 parameter, because this object just contains static auth_ref and can\u0027t reauthenticate. We should hard code reauthenticate\u003dFalse I think.","commit_id":"852206c505bf93ea4a4ca295ddd2be5619e5b40a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3755a8d0fa69e948b1402ce2efce108925108bd0","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    In certain circumstances you already have an auth_ref/AccessInfo object"},{"line_number":21,"context_line":"    that you just want to reuse. This could have been from a cache, in"},{"line_number":22,"context_line":"    auth_token middleware or other."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Turn that existing object into a simple identity plugin. This plugin cannot"},{"line_number":25,"context_line":"    be refreshed as the AccessInfo object does not contain any authorizing"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_2802700b","line":22,"updated":"2015-02-03 06:55:02.000000000","message":"This documentation should be updated to use active voice instead of passive voice.\n\n\"There are cases where reuse of an auth_ref or AccessInfo object is warranted such as from a cache, from auth_token middleware, or another source.\"","commit_id":"1b914f3c697ec7851322c037841d3d418a7c93d9"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"295b7773beab953e1f338083db00f93e7cff2421","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    In certain circumstances you already have an auth_ref/AccessInfo object"},{"line_number":21,"context_line":"    that you just want to reuse. This could have been from a cache, in"},{"line_number":22,"context_line":"    auth_token middleware or other."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Turn that existing object into a simple identity plugin. This plugin cannot"},{"line_number":25,"context_line":"    be refreshed as the AccessInfo object does not contain any authorizing"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_7802560c","line":22,"in_reply_to":"da86d52c_2802700b","updated":"2015-02-03 19:43:13.000000000","message":"Done","commit_id":"1b914f3c697ec7851322c037841d3d418a7c93d9"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3755a8d0fa69e948b1402ce2efce108925108bd0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    that you just want to reuse. This could have been from a cache, in"},{"line_number":22,"context_line":"    auth_token middleware or other."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Turn that existing object into a simple identity plugin. This plugin cannot"},{"line_number":25,"context_line":"    be refreshed as the AccessInfo object does not contain any authorizing"},{"line_number":26,"context_line":"    information."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_6b03820d","line":24,"updated":"2015-02-03 06:55:02.000000000","message":"Turn the existing object into a simple ...","commit_id":"1b914f3c697ec7851322c037841d3d418a7c93d9"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"295b7773beab953e1f338083db00f93e7cff2421","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    that you just want to reuse. This could have been from a cache, in"},{"line_number":22,"context_line":"    auth_token middleware or other."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Turn that existing object into a simple identity plugin. This plugin cannot"},{"line_number":25,"context_line":"    be refreshed as the AccessInfo object does not contain any authorizing"},{"line_number":26,"context_line":"    information."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_3808de2c","line":24,"in_reply_to":"da86d52c_6b03820d","updated":"2015-02-03 19:43:13.000000000","message":"Done","commit_id":"1b914f3c697ec7851322c037841d3d418a7c93d9"}]}
