)]}'
{"id":"openstack%2Fpython-keystoneclient~144422","triplet_id":"openstack%2Fpython-keystoneclient~master~I8b392ff228691b2735b06747dcfb802d4c191a54","project":"openstack/python-keystoneclient","branch":"master","topic":"enabled_default","hashtags":[],"change_id":"I8b392ff228691b2735b06747dcfb802d4c191a54","subject":"fix enabled parameter of update doesn\u0027t default to None","status":"MERGED","created":"2014-12-30 09:30:05.000000000","updated":"2015-01-27 14:41:05.000000000","submitted":"2015-01-27 14:41:04.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f258291a22dcb3b8cad2550e6b4b317b65143f8e","_number":144422,"virtual_id_number":144422,"owner":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-01-27 14:41:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"date":"2015-01-21 06:26:11.000000000","_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-01-27 14:07:10.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2015-01-21 05:23:40.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-01-27 14:07:10.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-21 05:23:40.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2015-01-27 14:07:10.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-01-27 14:41:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"53ed546919595ff11e5e3dd70ed4a2b9569d17e4","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-12-30 09:30:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d940cbf855224a09d80bd495174f8e0d7e21f162","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-30 10:15:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/22/144422/1/check/gate-python-keystoneclient-python26/c10dcc4/ : SUCCESS in 2m 47s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/22/144422/1/check/gate-python-keystoneclient-pep8/6e22b16/ : SUCCESS in 1m 49s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/22/144422/1/check/gate-python-keystoneclient-docs/c35ad00//doc/build/html/ : SUCCESS in 2m 59s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/22/144422/1/check/gate-python-keystoneclient-python27/7c7227b/ : SUCCESS in 2m 34s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/22/144422/1/check/gate-python-keystoneclient-python33/3fefcfd/ : SUCCESS in 3m 23s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/22/144422/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/33db9c0/ : SUCCESS in 41m 41s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/22/144422/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/c705aab/ : SUCCESS in 37m 34s","accounts_in_message":[],"_revision_number":1},{"id":"401eebd5442fb70346cc79cbe41d76c82535cc27","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-01-20 08:13:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI think this one is worth of a bug. \n\nIt means that the value of enabled would be set to True if you don\u0027t otherwise specify something. If using None it will remain the default. \n\nInclude a test please.","accounts_in_message":[],"_revision_number":1},{"id":"0f0b1653f30119309648e21ec3426ee0a0716530","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2015-01-20 10:38:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f7536fbf564a00b1e78aa0f3dfc9d8a267f4fa20","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-20 11:28:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/22/144422/2/check/gate-python-keystoneclient-python26/7c047b3/ : SUCCESS in 1m 53s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/22/144422/2/check/gate-python-keystoneclient-pep8/bcc7350/ : SUCCESS in 2m 07s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/22/144422/2/check/gate-python-keystoneclient-docs/f6d87b2//doc/build/html/ : SUCCESS in 3m 00s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/22/144422/2/check/gate-python-keystoneclient-python27/df77999/ : SUCCESS in 2m 30s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/22/144422/2/check/gate-python-keystoneclient-python33/6811532/ : SUCCESS in 3m 11s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/22/144422/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/489fc4c/ : SUCCESS in 34m 04s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/22/144422/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/dde3d89/ : SUCCESS in 40m 46s","accounts_in_message":[],"_revision_number":2},{"id":"daeed5c1bcebb5277a8598108ad0dc575f56d600","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2015-01-21 05:10:29.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"206a57936aca22bca0853f006a8a3bb3721be813","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-01-21 05:23:40.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)\n\nHad to step through the tests to figure out why it worked - but they do.","accounts_in_message":[],"_revision_number":3},{"id":"b9261508138103c2949c9e45c7444c12a1a597a3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-21 05:50:46.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/22/144422/3/check/gate-python-keystoneclient-python26/574a9ab/ : SUCCESS in 1m 47s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/22/144422/3/check/gate-python-keystoneclient-pep8/ef7f6bf/ : SUCCESS in 1m 52s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/22/144422/3/check/gate-python-keystoneclient-docs/424738a//doc/build/html/ : SUCCESS in 3m 06s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/22/144422/3/check/gate-python-keystoneclient-python27/0086282/ : SUCCESS in 2m 36s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/22/144422/3/check/gate-python-keystoneclient-python33/27901ad/ : SUCCESS in 3m 30s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/22/144422/3/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/88b4764/ : SUCCESS in 29m 47s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/22/144422/3/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/57349e3/ : SUCCESS in 40m 15s","accounts_in_message":[],"_revision_number":3},{"id":"7ae61b6cc7636ab23c24571386ecd2f718e76caa","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2015-01-21 06:26:11.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"670dd50137f9d3808f739fb63daf3a2ba2c89b06","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-01-21 11:15:17.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b5f5a144cd76ea3bb9a83fcd5256924bf2cc59d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-27 14:07:10.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"6a4503ed21d4b0869c3d29b993dbe2dc3b6cbca4","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-01-27 14:07:10.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"f5e53d4d2c4493ee1520f8a9d09024724facbc34","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-27 14:41:04.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/22/144422/3/gate/gate-python-keystoneclient-python26/c14eb6b/ : SUCCESS in 1m 54s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/22/144422/3/gate/gate-python-keystoneclient-docs/329fa98//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/22/144422/3/gate/gate-python-keystoneclient-pep8/63f964e/ : SUCCESS in 1m 54s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/22/144422/3/gate/gate-python-keystoneclient-python27/6fd3b50/ : SUCCESS in 2m 15s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/22/144422/3/gate/gate-python-keystoneclient-python33/6d52538/ : SUCCESS in 3m 12s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/22/144422/3/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/303c4d1/ : SUCCESS in 32m 57s","accounts_in_message":[],"_revision_number":3},{"id":"a00dd87b0a72ab569a4d1a5f95e7316dc1889019","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-27 14:41:05.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"acfbff0258e9f8de2b49ddf7af927b67d1dbba1d","revisions":{"290406aa6774001cf1c3ae7c6cf1510be5f8c62d":{"kind":"REWORK","_number":1,"created":"2014-12-30 09:30:05.000000000","uploader":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"ref":"refs/changes/22/144422/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/22/144422/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/1"}}},"commit":{"parents":[{"commit":"10860db5f155052ca0d353ce9058e1c16eec8437","subject":"Merge \"Take plugin params from ENV rather than default\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/10860db5f155052ca0d353ce9058e1c16eec8437"}]}],"author":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2014-12-30 09:14:48.000000000","tz":480},"committer":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2014-12-30 09:14:48.000000000","tz":480},"subject":"fix enabled parameter of update doesn\u0027t default to None","message":"fix enabled parameter of update doesn\u0027t default to None\n\nCurrently, enabled parameter of v3.domains.update and v3.regions.update\ndefaults to True. It is easy to make mistakes and difficult to use.\n\nChange-Id: I8b392ff228691b2735b06747dcfb802d4c191a54\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/290406aa6774001cf1c3ae7c6cf1510be5f8c62d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/290406aa6774001cf1c3ae7c6cf1510be5f8c62d"}]},"branch":"refs/heads/master"},"0a52a7389c4db47c517932357272483520d80477":{"kind":"REWORK","_number":2,"created":"2015-01-20 10:38:36.000000000","uploader":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"ref":"refs/changes/22/144422/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/22/144422/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/2"}}},"commit":{"parents":[{"commit":"d0069876390825309ac0920ecc1fdd57336507f7","subject":"Merge \"Fix up types within API documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d0069876390825309ac0920ecc1fdd57336507f7"}]}],"author":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2014-12-30 09:14:48.000000000","tz":480},"committer":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2015-01-20 10:38:07.000000000","tz":480},"subject":"fix enabled parameter of update doesn\u0027t default to None","message":"fix enabled parameter of update doesn\u0027t default to None\n\nCurrently, enabled parameter of v3.domains.update and v3.regions.update\ndefaults to True. It is easy to make mistakes and difficult to use.\n\nChange-Id: I8b392ff228691b2735b06747dcfb802d4c191a54\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0a52a7389c4db47c517932357272483520d80477"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0a52a7389c4db47c517932357272483520d80477"}]},"branch":"refs/heads/master"},"acfbff0258e9f8de2b49ddf7af927b67d1dbba1d":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2015-01-21 05:10:29.000000000","uploader":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"ref":"refs/changes/22/144422/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/22/144422/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/22/144422/3"}}},"commit":{"parents":[{"commit":"eaab62aca5f570bd119b4c602db7845a017c958e","subject":"Merge \"Enable hacking rule F821\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/eaab62aca5f570bd119b4c602db7845a017c958e"}]}],"author":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2014-12-30 09:14:48.000000000","tz":480},"committer":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2015-01-21 05:09:37.000000000","tz":480},"subject":"fix enabled parameter of update doesn\u0027t default to None","message":"fix enabled parameter of update doesn\u0027t default to None\n\nCurrently, enabled parameter of v3.domains.update and v3.regions.update\ndefaults to True. It is easy to make mistakes and difficult to use.\n\nCloses-Bug: #1413071\nChange-Id: I8b392ff228691b2735b06747dcfb802d4c191a54\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/acfbff0258e9f8de2b49ddf7af927b67d1dbba1d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/acfbff0258e9f8de2b49ddf7af927b67d1dbba1d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}