)]}'
{"id":"openstack%2Fpython-keystoneclient~14487","triplet_id":"openstack%2Fpython-keystoneclient~master~I761ee19169b39e47c4aa191b553965446432dba9","project":"openstack/python-keystoneclient","branch":"master","topic":"tests_context_managers","hashtags":[],"change_id":"I761ee19169b39e47c4aa191b553965446432dba9","subject":"use mock context managers instead of decorators+functions","status":"MERGED","created":"2012-10-16 15:46:15.000000000","updated":"2012-10-19 19:48:04.000000000","submitted":"2012-10-19 19:48:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9c562d36c4d5e4a51797489b70e13ba67189b819","_number":14487,"virtual_id_number":14487,"owner":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-10-19 19:48:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-10-18 11:44:59.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":2,"date":"2012-10-18 16:03:50.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2012-10-19 19:22:11.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":0,"date":"2012-10-18 16:03:50.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2012-10-19 19:22:11.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-10-17 05:19:55.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2012-10-18 16:03:50.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2012-10-19 19:22:11.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2012-10-19 19:48:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0dab806c66aa0a1ddac51c5c7b41af7226a3a755","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-16 16:04:37.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14487/1/check/gate-python-keystoneclient-merge/356 : SUCCESS\n- http://logs.openstack.org/14487/1/check/gate-python-keystoneclient-docs/208 : SUCCESS\n- http://logs.openstack.org/14487/1/check/gate-python-keystoneclient-pep8/352 : SUCCESS\n- http://logs.openstack.org/14487/1/check/gate-python-keystoneclient-python26/284 : SUCCESS\n- http://logs.openstack.org/14487/1/check/gate-python-keystoneclient-python27/286 : SUCCESS\n- http://logs.openstack.org/14487/1/check/gate-tempest-devstack-vm/14649 : SUCCESS\n- http://logs.openstack.org/14487/1/check/gate-tempest-devstack-vm-cinder/4628 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"b864b5e945883a96d8be74eeea93b5c821fde3de","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2012-10-17 05:19:55.000000000","message":"Patch Set 1: (1 inline comment)\n\nWhy is this a good idea?","accounts_in_message":[],"_revision_number":1},{"id":"14c4019fd6f97ccc14c4d626f12f6c2d315ef0a3","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-17 08:49:59.000000000","message":"Patch Set 1: (1 inline comment)\n\nI think it\u0027s a good idea because those functions look like they were created artificially just so the decorators could be applied. Also, the purpose is more clear and there\u0027s less code.","accounts_in_message":[],"_revision_number":1},{"id":"a8b09000a045b0e4e35fdfa160949d86af898d28","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-10-17 17:40:25.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\ni\u0027d like to avoid using contextlib.nested here, as it\u0027s deprecated; but I like the overall change","accounts_in_message":[],"_revision_number":1},{"id":"b18d650a9ac23260a3282dd40fe63f185444a2a3","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-18 11:44:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cac48060dc7d0e69f7192f84655b48377c87776a","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2012-10-18 11:44:59.000000000","message":"Patch Set 2:\n\nOk. This syntax should be good for both 2.6 and 2.7.","accounts_in_message":[],"_revision_number":2},{"id":"ca9d72242973f4cd8c35335f2746855c336e3d99","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-18 12:03:58.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/14487/2/check/gate-python-keystoneclient-merge/360 : SUCCESS\n- http://logs.openstack.org/14487/2/check/gate-python-keystoneclient-docs/212 : SUCCESS\n- http://logs.openstack.org/14487/2/check/gate-python-keystoneclient-pep8/356 : SUCCESS\n- http://logs.openstack.org/14487/2/check/gate-python-keystoneclient-python26/288 : SUCCESS\n- http://logs.openstack.org/14487/2/check/gate-python-keystoneclient-python27/290 : SUCCESS\n- http://logs.openstack.org/14487/2/check/gate-tempest-devstack-vm/14719 : SUCCESS\n- http://logs.openstack.org/14487/2/check/gate-tempest-devstack-vm-cinder/4698 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"d7e9dfce666ed4c3a7679428dab4f5148f7aa5b3","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-10-18 16:03:50.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"55134f70e2b0570316a5ccef2bd829a794db6949","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-19 19:22:11.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"e3427dbc0133b2d93d9a4faa6ca4c9129156f114","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-10-19 19:22:11.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"94f194e4ab89d15ff24a34ec60e995fe1013feec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-19 19:48:03.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/14487/2/gate/gate-python-keystoneclient-merge/364 : SUCCESS\n- http://logs.openstack.org/14487/2/gate/gate-python-keystoneclient-docs/215 : SUCCESS\n- http://logs.openstack.org/14487/2/gate/gate-python-keystoneclient-pep8/359 : SUCCESS\n- http://logs.openstack.org/14487/2/gate/gate-python-keystoneclient-python26/291 : SUCCESS\n- http://logs.openstack.org/14487/2/gate/gate-python-keystoneclient-python27/293 : SUCCESS\n- http://logs.openstack.org/14487/2/gate/gate-tempest-devstack-vm/14823 : SUCCESS\n- http://logs.openstack.org/14487/2/gate/gate-tempest-devstack-vm-cinder/4802 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"e76a1741389c70f3f651a5a03c6317cc64676af2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-19 19:48:04.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bec66e8c8650a0d433f1ed50bf3b104dd0c07f3e","revisions":{"3e03a74b6fb7ecde195c1270f798d0a362b80807":{"kind":"REWORK","_number":1,"created":"2012-10-16 15:46:15.000000000","uploader":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"ref":"refs/changes/87/14487/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/87/14487/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/14487/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/14487/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/14487/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/14487/1"}}},"commit":{"parents":[{"commit":"fc4cbcae39ee094cef2c3cce4c96813eb9affcff","subject":"Merge \"Added \u0027service_id\u0027 column to endpoint-list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fc4cbcae39ee094cef2c3cce4c96813eb9affcff"}]}],"author":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-10-16 15:45:58.000000000","tz":120},"committer":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-10-16 15:45:58.000000000","tz":120},"subject":"use mock context managers instead of decorators+functions","message":"use mock context managers instead of decorators+functions\n\nChange-Id: I761ee19169b39e47c4aa191b553965446432dba9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3e03a74b6fb7ecde195c1270f798d0a362b80807"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3e03a74b6fb7ecde195c1270f798d0a362b80807"}]},"branch":"refs/heads/master"},"bec66e8c8650a0d433f1ed50bf3b104dd0c07f3e":{"kind":"REWORK","_number":2,"created":"2012-10-18 11:44:13.000000000","uploader":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"ref":"refs/changes/87/14487/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/87/14487/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/14487/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/14487/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/14487/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/14487/2"}}},"commit":{"parents":[{"commit":"fc4cbcae39ee094cef2c3cce4c96813eb9affcff","subject":"Merge \"Added \u0027service_id\u0027 column to endpoint-list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fc4cbcae39ee094cef2c3cce4c96813eb9affcff"}]}],"author":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-10-16 15:45:58.000000000","tz":120},"committer":{"name":"Ionuț Arțăriși","email":"iartarisi@suse.cz","date":"2012-10-18 11:43:39.000000000","tz":120},"subject":"use mock context managers instead of decorators+functions","message":"use mock context managers instead of decorators+functions\n\nChange-Id: I761ee19169b39e47c4aa191b553965446432dba9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bec66e8c8650a0d433f1ed50bf3b104dd0c07f3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bec66e8c8650a0d433f1ed50bf3b104dd0c07f3e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}