)]}'
{"id":"openstack%2Fpython-keystoneclient~145532","triplet_id":"openstack%2Fpython-keystoneclient~master~I95832d0f13ca93c4618784da9d1eb9ca166cae53","project":"openstack/python-keystoneclient","branch":"master","topic":"smaller_logging","hashtags":[],"change_id":"I95832d0f13ca93c4618784da9d1eb9ca166cae53","subject":"don\u0027t log service catalog in every token response","status":"MERGED","created":"2015-01-07 16:02:23.000000000","updated":"2015-01-10 00:57:36.000000000","submitted":"2015-01-10 00:57:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dac918d1501e8027cd8c0868407f2e850aabc0da","_number":145532,"virtual_id_number":145532,"owner":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-01-10 00:57:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-01-09 23:50:20.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2015-01-09 23:47:18.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":2,"date":"2015-01-10 00:10:30.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":1,"date":"2015-01-10 00:10:30.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-09 23:14:10.000000000","updated_by":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"reviewer":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"state":"REVIEWER"},{"updated":"2015-01-09 23:47:18.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2015-01-09 23:50:20.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-01-10 00:10:30.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2015-01-10 00:57:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e666184e5bb6563a2878e621dd1e1aa8f00213c1","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-01-07 16:02:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"70346fdea289917087ff2744f75739641c4fba46","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-07 16:46:59.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/145532/1/check/gate-python-keystoneclient-python26/d924e1f/ : SUCCESS in 4m 51s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/145532/1/check/gate-python-keystoneclient-pep8/3c3c37a/ : SUCCESS in 2m 41s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/145532/1/check/gate-python-keystoneclient-docs/dec24e8//doc/build/html/ : SUCCESS in 2m 58s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/145532/1/check/gate-python-keystoneclient-python27/41d1ac9/ : SUCCESS in 2m 03s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/145532/1/check/gate-python-keystoneclient-python33/0c3fa89/ : SUCCESS in 4m 48s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/32/145532/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/e03ab09/ : SUCCESS in 35m 59s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/32/145532/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/1273356/ : FAILURE in 34m 15s","accounts_in_message":[],"_revision_number":1},{"id":"dea70ccb22d96d84b215f2e563371ca94e3cbeab","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-01-09 14:42:43.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"f4376c1de4af3dc23511e78ee4221ded29b0c5f6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-09 15:20:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/145532/1/check/gate-python-keystoneclient-python26/196001d/ : SUCCESS in 1m 54s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/145532/1/check/gate-python-keystoneclient-pep8/d2033a2/ : SUCCESS in 3m 10s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/145532/1/check/gate-python-keystoneclient-docs/378e63a//doc/build/html/ : SUCCESS in 2m 32s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/145532/1/check/gate-python-keystoneclient-python27/1d3da52/ : SUCCESS in 1m 57s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/145532/1/check/gate-python-keystoneclient-python33/32825e6/ : SUCCESS in 3m 38s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/32/145532/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/3037541/ : SUCCESS in 32m 04s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/32/145532/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/7cd4a2d/ : SUCCESS in 31m 19s","accounts_in_message":[],"_revision_number":1},{"id":"4e0984cf8a187e60a3021f2d1a74c40e5c89ab48","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2015-01-09 23:14:10.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"695e1acf80ad472a74248540605bbcc63b1f13ab","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2015-01-09 23:31:11.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nMinor issue, but this is generally a good idea.","accounts_in_message":[],"_revision_number":1},{"id":"466ba7bd6b86e6b6f899ce8c062e13b5d8470703","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-01-09 23:32:04.000000000","message":"Patch Set 1:\n\nFYI, this creates the following reduction in the gz compressed versions of the following logs:\n\nn-api: -28%\ng-api: -33%\nc-api: -35%","accounts_in_message":[],"_revision_number":1},{"id":"7610e6597909559049a0f1b6ebe78e1decf5d638","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-01-09 23:45:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1090c1722a60e6f74f4127dae3533f88b6d57e7a","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2015-01-09 23:47:18.000000000","message":"Patch Set 2: Code-Review+2\n\nOnce we get Trace level logging we should add in a way to see the catalog again. This makes a lot of sense to limit the volume of log data.","accounts_in_message":[],"_revision_number":2},{"id":"c20179751811fdf9a56fe6cce1e6841b5c4f8369","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-01-09 23:50:20.000000000","message":"Patch Set 2: Code-Review+2\n\nCode looks fine to me. Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"ce623b27f2c31322b74b8a733497e5f3d2597780","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2015-01-10 00:10:30.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"7f7e5a555a86fcb2d70e4dedd475c1725f0d8830","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-10 00:22:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/145532/2/check/gate-python-keystoneclient-python26/edfd76c/ : SUCCESS in 1m 55s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/145532/2/check/gate-python-keystoneclient-pep8/6666f34/ : SUCCESS in 2m 19s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/145532/2/check/gate-python-keystoneclient-docs/8e0ee7a//doc/build/html/ : SUCCESS in 3m 28s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/145532/2/check/gate-python-keystoneclient-python27/7e5f1e1/ : SUCCESS in 2m 27s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/145532/2/check/gate-python-keystoneclient-python33/fcb20a1/ : SUCCESS in 3m 19s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/32/145532/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/57c3f4f/ : SUCCESS in 34m 38s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/32/145532/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/8d1d79d/ : SUCCESS in 36m 42s","accounts_in_message":[],"_revision_number":2},{"id":"b5a3ddea5dc23e635e14b25b35101dde886a038e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-10 00:22:39.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c66298a52dc01f076852f637cc96789295661f9d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-10 00:57:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/145532/2/gate/gate-python-keystoneclient-python26/5556f34/ : SUCCESS in 2m 00s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/145532/2/gate/gate-python-keystoneclient-docs/c82edbc//doc/build/html/ : SUCCESS in 3m 05s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/145532/2/gate/gate-python-keystoneclient-pep8/452871f/ : SUCCESS in 2m 45s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/145532/2/gate/gate-python-keystoneclient-python27/a970f3f/ : SUCCESS in 2m 49s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/145532/2/gate/gate-python-keystoneclient-python33/a44fdb8/ : SUCCESS in 3m 18s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/32/145532/2/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/47d9d31/ : SUCCESS in 34m 54s","accounts_in_message":[],"_revision_number":2},{"id":"af89e98d24de4ba544870838c8bfc34b579bb334","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-10 00:57:36.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"453e926322ffdbc4862ed5d0b13d0f98760c6b67","revisions":{"dadddaf42c2fde23f8d07881fe5c114b265aa1f0":{"kind":"REWORK","_number":1,"created":"2015-01-07 16:02:23.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/32/145532/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/145532/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/145532/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/145532/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/145532/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/145532/1"}}},"commit":{"parents":[{"commit":"260f54dad7f53cad10b02f562a666c96da176a40","subject":"Merge \"Add get certificates for v2.0\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/260f54dad7f53cad10b02f562a666c96da176a40"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-01-07 15:59:34.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-01-07 16:02:22.000000000","tz":-300},"subject":"don\u0027t log service catalog in every token response","message":"don\u0027t log service catalog in every token response\n\nThe whole service catalog is embedded in every token, and by default\nall token responses are logged at DEBUG. This adds a huge amount of\nbasically const data into system logs, over and over and over again.\n\nWe should not log the service catalog by default on every token\nresponse. The following is one way to purge this out.\n\nChange-Id: I95832d0f13ca93c4618784da9d1eb9ca166cae53\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/dadddaf42c2fde23f8d07881fe5c114b265aa1f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/dadddaf42c2fde23f8d07881fe5c114b265aa1f0"}]},"branch":"refs/heads/master"},"453e926322ffdbc4862ed5d0b13d0f98760c6b67":{"kind":"REWORK","_number":2,"created":"2015-01-09 23:45:49.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/32/145532/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/145532/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/145532/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/145532/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/145532/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/145532/2"}}},"commit":{"parents":[{"commit":"260f54dad7f53cad10b02f562a666c96da176a40","subject":"Merge \"Add get certificates for v2.0\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/260f54dad7f53cad10b02f562a666c96da176a40"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-01-07 15:59:34.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-01-09 23:43:00.000000000","tz":-300},"subject":"don\u0027t log service catalog in every token response","message":"don\u0027t log service catalog in every token response\n\nThe whole service catalog is embedded in every token, and by default\nall token responses are logged at DEBUG. This adds a huge amount of\nbasically const data into system logs, over and over and over again.\n\nWe should not log the service catalog by default on every token\nresponse. The following replaces the service catalog with the token\n\u003cremoved\u003e.\n\nThis reduces the compressed logs of API services by about 1/3.\n\nChange-Id: I95832d0f13ca93c4618784da9d1eb9ca166cae53\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/453e926322ffdbc4862ed5d0b13d0f98760c6b67"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/453e926322ffdbc4862ed5d0b13d0f98760c6b67"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}