)]}'
{"keystoneclient/tests/v3/utils.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"7e5b1bf28009230107c23d3f1a5639ab7a2114e2","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        # from datetime object to timestamp string)"},{"line_number":205,"context_line":"        req_ref \u003d (req_ref or ref).copy()"},{"line_number":206,"context_line":"        if \u0027id\u0027 in req_ref:"},{"line_number":207,"context_line":"            req_ref.pop(\u0027id\u0027)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        self.stub_entity(\u0027POST\u0027, entity\u003dreq_ref, status_code\u003d201)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_a87302b0","line":207,"updated":"2015-01-21 05:28:11.000000000","message":"nit: this is just req_ref.pop(\u0027id\u0027, None)","commit_id":"558832ec2343c29d7dc41660973e524beaaf8633"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"7e5b1bf28009230107c23d3f1a5639ab7a2114e2","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        # from datetime object to timestamp string)"},{"line_number":315,"context_line":"        req_ref \u003d (req_ref or ref).copy()"},{"line_number":316,"context_line":"        if \u0027id\u0027 in req_ref:"},{"line_number":317,"context_line":"            req_ref.pop(\u0027id\u0027)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        returned \u003d self.manager.update(ref[\u0027id\u0027], **parameterize(req_ref))"},{"line_number":320,"context_line":"        self.assertIsInstance(returned, self.model)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_c8676ee9","line":317,"updated":"2015-01-21 05:28:11.000000000","message":"same","commit_id":"558832ec2343c29d7dc41660973e524beaaf8633"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"7e5b1bf28009230107c23d3f1a5639ab7a2114e2","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                getattr(returned, attr),"},{"line_number":324,"context_line":"                ref[attr],"},{"line_number":325,"context_line":"                \u0027Expected different %s\u0027 % attr)"},{"line_number":326,"context_line":"        self.assertEntityRequestBodyIs(req_ref)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def test_delete(self, ref\u003dNone):"},{"line_number":329,"context_line":"        ref \u003d ref or self.new_ref()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_28b6323e","line":326,"updated":"2015-01-21 05:28:11.000000000","message":"at no point in these tests does it check that the values that were sent to update are retrieved (and they\u0027re not) and available on the object.","commit_id":"558832ec2343c29d7dc41660973e524beaaf8633"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"31ef86ef0cc4780810281ef4b703e2209bfa3d90","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        # conversion before doing the request (e.g. converting"},{"line_number":204,"context_line":"        # from datetime object to timestamp string)"},{"line_number":205,"context_line":"        req_ref \u003d (req_ref or ref).copy()"},{"line_number":206,"context_line":"        req_ref.pop(\u0027id\u0027, None)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.stub_entity(\u0027POST\u0027, entity\u003dreq_ref, status_code\u003d201)"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_5370bd71","line":206,"updated":"2015-01-27 14:14:58.000000000","message":"this should be changed so that if req_ref is used then the id isn\u0027t popped and if ref is used then id is popped.\n\n if req_ref:\n     req_ref \u003d req_ref.copy()\n else:\n    req_ref \u003d ref.copy()\n    req_ref.pop(\u0027id\u0027)\n\nWe don\u0027t want new tests to be written that include id in the req_ref.","commit_id":"b56ab6ba292235a3488479a80fb880c061ac8d1e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"31ef86ef0cc4780810281ef4b703e2209bfa3d90","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        # conversion before doing the request (e.g. converting"},{"line_number":313,"context_line":"        # from datetime object to timestamp string)"},{"line_number":314,"context_line":"        req_ref \u003d (req_ref or ref).copy()"},{"line_number":315,"context_line":"        req_ref.pop(\u0027id\u0027, None)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        returned \u003d self.manager.update(ref[\u0027id\u0027], **parameterize(req_ref))"},{"line_number":318,"context_line":"        self.assertIsInstance(returned, self.model)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_9314e5e9","line":315,"updated":"2015-01-27 14:14:58.000000000","message":"same here.","commit_id":"b56ab6ba292235a3488479a80fb880c061ac8d1e"}]}