)]}'
{"id":"openstack%2Fpython-keystoneclient~152831","triplet_id":"openstack%2Fpython-keystoneclient~master~I4fc444b266c61da0a131651d7aa636021f6ea5f9","project":"openstack/python-keystoneclient","branch":"master","topic":"wrong_manager","hashtags":[],"change_id":"I4fc444b266c61da0a131651d7aa636021f6ea5f9","subject":"use right resource_class to create resource instance","status":"MERGED","created":"2015-02-04 09:06:50.000000000","updated":"2015-02-08 16:04:06.000000000","submitted":"2015-02-08 16:04:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"827fd59cbc14fd3f5761af9527a87ec9e86586ea","_number":152831,"virtual_id_number":152831,"owner":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-02-08 16:04:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-02-05 04:14:19.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-02-05 09:18:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":1,"date":"2015-02-05 10:55:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"value":2,"date":"2015-02-08 15:31:05.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2015-02-05 13:33:52.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"value":1,"date":"2015-02-08 15:31:05.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-05 04:14:19.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-02-05 09:18:13.000000000","updated_by":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"reviewer":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"state":"REVIEWER"},{"updated":"2015-02-05 10:55:36.000000000","updated_by":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"reviewer":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"state":"REVIEWER"},{"updated":"2015-02-05 13:33:52.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2015-02-08 15:31:05.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-02-08 16:04:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8e88187a78b11db0d3436b70c85e58ba3a303e82","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2015-02-04 09:06:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"38bfcfdfd372d7299e3e116e49272a015376e3f7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 09:39:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/31/152831/1/check/gate-python-keystoneclient-python26/6fc4fd3/ : SUCCESS in 1m 56s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/31/152831/1/check/gate-python-keystoneclient-pep8/62195ab/ : SUCCESS in 2m 28s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/31/152831/1/check/gate-python-keystoneclient-docs/edf3264//doc/build/html/ : SUCCESS in 3m 01s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/31/152831/1/check/gate-python-keystoneclient-python27/13f96cf/ : SUCCESS in 2m 02s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/31/152831/1/check/gate-python-keystoneclient-python34/2435955/ : SUCCESS in 3m 27s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/31/152831/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/ad2ab36/ : SUCCESS in 32m 23s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/31/152831/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/cce1cff/ : SUCCESS in 31m 49s","accounts_in_message":[],"_revision_number":1},{"id":"4411702f4692c160f96f6999dd0304575c598eb2","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-02-04 16:14:37.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"711513976a392d8d59c42a29cac59d6970d003ee","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-02-04 16:14:53.000000000","message":"Patch Set 1:\n\ni have no idea how that was working before","accounts_in_message":[],"_revision_number":1},{"id":"b32d2746060086c9f2bc05f8c42222b8b38156a6","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-02-04 17:37:51.000000000","message":"Patch Set 1: Code-Review-1\n\nSorry, but the tests pass even without the patch and it is totally wrong. The patch deserved a bugreport with description why tests were passing before and why they shoudn\u0027t have.","accounts_in_message":[],"_revision_number":1},{"id":"14bede07bb13529d60932ce038984c1ba31d2d3e","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2015-02-05 01:29:57.000000000","message":"Patch Set 1:\n\n@Steve Martinelli, Boris Bobrov.\n\nThis is because almost all the resource_class are the same. They are just inherited from base.Resource and don\u0027t have  special attributes different with others.\n\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/projects.py#L21\n\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/policies.py#L21","accounts_in_message":[],"_revision_number":1},{"id":"98b71593878e86224978fa82e167ac0ee12818be","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2015-02-05 01:31:14.000000000","message":"Patch Set 1:\n\n@Boris Bobrov, OK. I will report a bug then.","accounts_in_message":[],"_revision_number":1},{"id":"a80f9a168515e3f18d875983a9f0ae7093834be7","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2015-02-05 04:10:30.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"234d168e1a20509af33c77b591c109fdeed2e58b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-02-05 04:14:19.000000000","message":"Patch Set 2: Code-Review+2\n\ni\u0027m still ok with this","accounts_in_message":[],"_revision_number":2},{"id":"e669633a8bfdccca2dd7fb2b59b9ef69e1715467","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-05 04:49:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/31/152831/2/check/gate-python-keystoneclient-python26/0bb6b48/ : SUCCESS in 1m 55s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/31/152831/2/check/gate-python-keystoneclient-pep8/294dc48/ : SUCCESS in 2m 19s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/31/152831/2/check/gate-python-keystoneclient-docs/394ef49//doc/build/html/ : SUCCESS in 3m 13s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/31/152831/2/check/gate-python-keystoneclient-python27/c67bf41/ : SUCCESS in 3m 15s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/31/152831/2/check/gate-python-keystoneclient-python34/e486b41/ : SUCCESS in 5m 08s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/31/152831/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/ae47d50/ : SUCCESS in 38m 32s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/31/152831/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/138f906/ : SUCCESS in 33m 33s","accounts_in_message":[],"_revision_number":2},{"id":"b95ecc34afdb727e7b327ebe3447d19d9e00054c","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-02-05 09:18:13.000000000","message":"Patch Set 2: Code-Review+1\n\nGot it, thank you!","accounts_in_message":[],"_revision_number":2},{"id":"e1fa7b05fecf1dc8d802d202ba37f9f903bbfed8","author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"date":"2015-02-05 10:55:36.000000000","message":"Patch Set 2: Code-Review+1\n\nNice catch!","accounts_in_message":[],"_revision_number":2},{"id":"a32b22cd05cdd044276dc7fa54613d93e5a556f3","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-02-05 13:33:52.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"71bd3023e6bd0fb889589ef17bd9bb006f655c28","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-08 15:31:05.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"3ecc05dd1231f7b32a11b3399ea66b505437c30a","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-02-08 15:31:05.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"997f0cfd5fbf1d09ba89a9058a12bcd6e3ff3948","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-08 16:04:05.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/31/152831/2/gate/gate-python-keystoneclient-python26/f76caca/ : SUCCESS in 2m 02s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/31/152831/2/gate/gate-python-keystoneclient-docs/3dfa021//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/31/152831/2/gate/gate-python-keystoneclient-pep8/f1ccbcb/ : SUCCESS in 1m 38s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/31/152831/2/gate/gate-python-keystoneclient-python27/1d1d443/ : SUCCESS in 1m 53s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/31/152831/2/gate/gate-python-keystoneclient-python34/d5af121/ : SUCCESS in 3m 16s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/31/152831/2/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/b38d5df/ : SUCCESS in 32m 57s","accounts_in_message":[],"_revision_number":2},{"id":"207a5f90f16f935a0d2df8014cb7ffaeb047853e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-08 16:04:06.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5ad4cc0b68ec49f18caa92082a062acc0848c807","revisions":{"bc9f8dc42336368c445b0c7dd636292d6d20629d":{"kind":"REWORK","_number":1,"created":"2015-02-04 09:06:50.000000000","uploader":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"ref":"refs/changes/31/152831/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/152831/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/152831/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/152831/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/152831/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/152831/1"}}},"commit":{"parents":[{"commit":"cef7775cda6d4113171ff713ee36b93731b89242","subject":"Merge \"Enable hacking rule E122 and H304\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/cef7775cda6d4113171ff713ee36b93731b89242"}]}],"author":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2015-02-04 08:55:42.000000000","tz":480},"committer":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2015-02-04 08:55:42.000000000","tz":480},"subject":"use right resource_class to create resource instance","message":"use right resource_class to create resource instance\n\nCurrently, in test_endpoint_policy.py we use the resource_class of\nproject to create a policy instance. We should use the resource_class\nof policy to create policy instance.\n\nChange-Id: I4fc444b266c61da0a131651d7aa636021f6ea5f9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bc9f8dc42336368c445b0c7dd636292d6d20629d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bc9f8dc42336368c445b0c7dd636292d6d20629d"}]},"branch":"refs/heads/master"},"5ad4cc0b68ec49f18caa92082a062acc0848c807":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-02-05 04:10:30.000000000","uploader":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"ref":"refs/changes/31/152831/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/152831/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/152831/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/152831/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/152831/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/152831/2"}}},"commit":{"parents":[{"commit":"cef7775cda6d4113171ff713ee36b93731b89242","subject":"Merge \"Enable hacking rule E122 and H304\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/cef7775cda6d4113171ff713ee36b93731b89242"}]}],"author":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2015-02-04 08:55:42.000000000","tz":480},"committer":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2015-02-05 04:10:30.000000000","tz":0},"subject":"use right resource_class to create resource instance","message":"use right resource_class to create resource instance\n\nCurrently, in test_endpoint_policy.py we use the resource_class of\nproject to create a policy instance. We should use the resource_class\nof policy to create policy instance.\n\nCloses-Bug: #1418316\nChange-Id: I4fc444b266c61da0a131651d7aa636021f6ea5f9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5ad4cc0b68ec49f18caa92082a062acc0848c807"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5ad4cc0b68ec49f18caa92082a062acc0848c807"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}