)]}'
{"id":"openstack%2Fpython-keystoneclient~155962","triplet_id":"openstack%2Fpython-keystoneclient~master~Idcf5b9f6ed766d3bc1541e158bdd8e58b06223e2","project":"openstack/python-keystoneclient","branch":"master","topic":"empty_method","hashtags":[],"change_id":"Idcf5b9f6ed766d3bc1541e158bdd8e58b06223e2","subject":"Add default body for non-abstract empty methods","status":"MERGED","created":"2015-02-14 05:53:46.000000000","updated":"2015-02-23 01:38:28.000000000","submitted":"2015-02-23 01:38:27.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"30bf88f31526f1ad2be042ac59c345ada3890adc","_number":155962,"virtual_id_number":155962,"owner":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-02-23 01:38:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-02-15 00:44:58.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-02-23 00:33:21.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-02-23 00:33:21.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-15 00:44:58.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-02-23 00:33:21.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2015-02-23 01:38:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"11c6f6e3aa93b2077a2ba4b6334d6155c4dff7a6","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-02-14 05:53:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"53ea33d2cb812eb64e4e417539f678ab26076145","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-02-14 05:57:37.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"fb827fe0a317dd172050e0d45535c0bef5ad5406","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-14 06:38:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/62/155962/2/check/gate-python-keystoneclient-python26/3c44315/ : SUCCESS in 2m 00s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/62/155962/2/check/gate-python-keystoneclient-pep8/cee7a0a/ : SUCCESS in 1m 42s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/62/155962/2/check/gate-python-keystoneclient-docs/64d0b30//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/62/155962/2/check/gate-python-keystoneclient-python27/9e58cbe/ : SUCCESS in 1m 50s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/62/155962/2/check/gate-python-keystoneclient-python34/9c3dc10/ : SUCCESS in 3m 12s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/62/155962/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/5da2cb0/ : SUCCESS in 28m 49s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/62/155962/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/2d223b2/ : SUCCESS in 40m 26s","accounts_in_message":[],"_revision_number":2},{"id":"b3064d17181b304cc7a0bdca18904d3a4d2de71c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-02-15 00:44:58.000000000","message":"Patch Set 2: Code-Review+2\n\ni\u0027m okay with this, both are supposed to return strings, so None works well for checking the returned value","accounts_in_message":[],"_revision_number":2},{"id":"ba63de94353f060181398d25fff8688a5b168f5e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-23 00:33:21.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7b4a56a9371f54e79e100ca1c694dab52984e9d7","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-02-23 00:33:21.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nNone is returned by default if nothing is returned so this has no impact. \n\nIf you have a reason for needing a body then that\u0027s fine.","accounts_in_message":[],"_revision_number":2},{"id":"1eae2ab147c16f3e605f4c6a29a90b984851dd85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-23 01:38:27.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/62/155962/2/gate/gate-python-keystoneclient-python26/6aa1cfe/ : SUCCESS in 2m 07s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/62/155962/2/gate/gate-python-keystoneclient-docs/c2c470c//doc/build/html/ : SUCCESS in 2m 36s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/62/155962/2/gate/gate-python-keystoneclient-pep8/96f5b00/ : SUCCESS in 2m 35s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/62/155962/2/gate/gate-python-keystoneclient-python27/0c40925/ : SUCCESS in 2m 50s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/62/155962/2/gate/gate-python-keystoneclient-python34/a8365e8/ : SUCCESS in 4m 24s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/62/155962/2/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/f60732d/ : SUCCESS in 1h 03m 45s","accounts_in_message":[],"_revision_number":2},{"id":"eae5130504f0a258a6e594af432f2705159e952c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-23 01:38:28.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"67a0c2e31ae19947067fd95a0bb4c53cfcb2b6cc","revisions":{"26ea107d716b76a008495fcd420e202d056abd21":{"kind":"REWORK","_number":1,"created":"2015-02-14 05:53:46.000000000","uploader":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"ref":"refs/changes/62/155962/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/62/155962/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/62/155962/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/62/155962/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/62/155962/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/62/155962/1"}}},"commit":{"parents":[{"commit":"96c038004fbd42b391926038ffd7429a7de12500","subject":"Merge \"Make remove_service_catalog private\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/96c038004fbd42b391926038ffd7429a7de12500"}]}],"author":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-02-14 05:53:39.000000000","tz":-480},"committer":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-02-14 05:53:39.000000000","tz":-480},"subject":"Add default body for non-abstract empty methods","message":"Add default body for non-abstract empty methods\n\nChange-Id: Idcf5b9f6ed766d3bc1541e158bdd8e58b06223e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/26ea107d716b76a008495fcd420e202d056abd21"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/26ea107d716b76a008495fcd420e202d056abd21"}]},"branch":"refs/heads/master"},"67a0c2e31ae19947067fd95a0bb4c53cfcb2b6cc":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-02-14 05:57:37.000000000","uploader":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"ref":"refs/changes/62/155962/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/62/155962/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/62/155962/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/62/155962/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/62/155962/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/62/155962/2"}}},"commit":{"parents":[{"commit":"96c038004fbd42b391926038ffd7429a7de12500","subject":"Merge \"Make remove_service_catalog private\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/96c038004fbd42b391926038ffd7429a7de12500"}]}],"author":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-02-14 05:53:39.000000000","tz":-480},"committer":{"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","date":"2015-02-14 05:57:37.000000000","tz":0},"subject":"Add default body for non-abstract empty methods","message":"Add default body for non-abstract empty methods\n\nSome non-abstract methods only have docstring with no content,\nthis just add a default content to those function.\n\nChange-Id: Idcf5b9f6ed766d3bc1541e158bdd8e58b06223e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/67a0c2e31ae19947067fd95a0bb4c53cfcb2b6cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/67a0c2e31ae19947067fd95a0bb4c53cfcb2b6cc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}