)]}'
{"id":"openstack%2Fpython-keystoneclient~161164","triplet_id":"openstack%2Fpython-keystoneclient~master~Ieec767da6cfdd444843c9d9d66a422bd7b75d09e","project":"openstack/python-keystoneclient","branch":"master","topic":"Bug/1425345","hashtags":[],"change_id":"Ieec767da6cfdd444843c9d9d66a422bd7b75d09e","subject":"Enable to specify auth plugin as full class name","status":"ABANDONED","created":"2015-03-04 10:30:49.000000000","updated":"2015-05-08 15:58:36.000000000","total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"97ea2c1b4f93ea57806f915d13cb84c356691455","_number":161164,"virtual_id_number":161164,"owner":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-03-13 18:57:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"date":"2015-03-16 10:57:46.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},{"date":"2015-03-13 15:40:46.000000000","_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2015-04-29 15:11:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2015-03-15 07:44:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-13 18:57:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-03-15 07:44:50.000000000","updated_by":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"reviewer":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"state":"REVIEWER"},{"updated":"2015-03-16 10:57:46.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2015-04-29 15:11:39.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"}],"messages":[{"id":"0eb28804c30a5dc608226cd85eeb4e21f57569d2","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2015-03-04 10:30:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7f9f1f24261cb4f00c95ae1e806e1aae92dc9058","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-04 20:28:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/64/161164/1/check/gate-python-keystoneclient-python26/bab85ae/ : SUCCESS in 1m 59s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/64/161164/1/check/gate-python-keystoneclient-pep8/a621e5d/ : FAILURE in 2m 14s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/64/161164/1/check/gate-python-keystoneclient-docs/8eb5ac1//doc/build/html/ : SUCCESS in 2m 47s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/64/161164/1/check/gate-python-keystoneclient-python27/d025825/ : SUCCESS in 2m 34s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/64/161164/1/check/gate-python-keystoneclient-python34/aa10d6d/ : FAILURE in 3m 37s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/64/161164/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/c2d11ce/ : SUCCESS in 37m 59s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/64/161164/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/09fdfd9/ : SUCCESS in 50m 34s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/64/161164/1/check/check-keystoneclient-dsvm-functional/2b4d2a7/ : SUCCESS in 23m 24s","accounts_in_message":[],"_revision_number":1},{"id":"e2c0b3de3ad8616cee764e3c464a93d45c610cce","author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"date":"2015-03-13 14:02:16.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nInline comments. Additionaly please fix the pep8 errors, because other reviewers often ignore patchsets which doesn\u0027t pass the Jenkins build.","accounts_in_message":[],"_revision_number":1},{"id":"8cf6634e28ef9db2863ece3ab87b5508d9f50d83","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2015-03-13 15:19:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a5bac9029e48838e517b99ee2f63580c30090619","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2015-03-13 15:40:46.000000000","message":"Patch Set 2:\n\nHi Kamil !\nThank you for your comment.\n\nI\u0027m about to reply your comment. \nFirst of all , about why I used \u0027StandardError\u0027 instead of \u0027ImportError\u0027.\nThe import_class method of oslo_utils raise two exception ( ImportError , ValueError ) as far as I know. So I used StandardError which is based class of two exception. Because I thought this approach is smart implementation.\nBut this approach is wrong. So I have changed to catch ImportError and ValueError from to catch StandardError.\n\nAbout the advice of commit message . Thank you for indicating miss grammar.\nI have fixed it.","accounts_in_message":[],"_revision_number":2},{"id":"df798e28afdb4398b94212c7366417400a9e4b07","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2015-03-13 15:42:56.000000000","message":"Topic changed from Close#1425345_Enable_to_specify_auth_plugin_as_full_class_name to Bug#1425345_Enable_to_specify_auth_plugin_as_full_class_name","accounts_in_message":[],"_revision_number":2},{"id":"6371c9f001dbabaff8188f08c95ec90485145637","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2015-03-13 15:43:16.000000000","message":"Topic changed from Bug#1425345_Enable_to_specify_auth_plugin_as_full_class_name to Bug/1425345","accounts_in_message":[],"_revision_number":2},{"id":"d8f1a35856bade84b9d8bff0d3dcbb37df2515b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-13 18:57:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/64/161164/2/check/gate-python-keystoneclient-python26/5342264/ : SUCCESS in 2m 10s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/64/161164/2/check/gate-python-keystoneclient-pep8/e40816b/ : SUCCESS in 2m 08s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/64/161164/2/check/gate-python-keystoneclient-docs/6817326//doc/build/html/ : SUCCESS in 3m 04s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/64/161164/2/check/gate-python-keystoneclient-python27/fec081a/ : SUCCESS in 2m 37s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/64/161164/2/check/gate-python-keystoneclient-python34/7470c88/ : SUCCESS in 4m 39s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/64/161164/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/5176414/ : SUCCESS in 42m 56s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/64/161164/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/7fff0a0/ : SUCCESS in 53m 59s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/64/161164/2/check/check-keystoneclient-dsvm-functional/0a099d8/ : SUCCESS in 19m 20s","accounts_in_message":[],"_revision_number":2},{"id":"66c529f04e2cd8e395f225d7477203c123f6e7e3","author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"date":"2015-03-15 07:44:50.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"1d843f7dec8e35c6d68c3109eb6480ee2b9304f9","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-03-16 10:57:46.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nI put a comment on the bug. There doesn\u0027t appear to be anything wrong with the code - i\u0027m just wondering why you would want to use the full class name functionality instead of the entrypoints?","accounts_in_message":[],"_revision_number":2},{"id":"d979a6dc542ee56ce0f8dd3eeddc3d57b7a0a777","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2015-03-16 13:59:45.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nI left my comment about the reason to use full class name for auth plugin and your comment in source.\nPlease Check it.\nhttps://bugs.launchpad.net/python-keystoneclient/+bug/1425345/comments/3\nhttps://review.openstack.org/#/c/161164/2/keystoneclient/auth/base.py","accounts_in_message":[],"_revision_number":2},{"id":"95c0c2e17dfc60e3bd01c02cdccb3f779616283b","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-04-29 15:11:39.000000000","message":"Patch Set 2: Code-Review-2\n\nLet\u0027s use stevedore.","accounts_in_message":[],"_revision_number":2},{"id":"97ea2c1b4f93ea57806f915d13cb84c356691455","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2015-05-08 15:58:36.000000000","message":"Abandoned\n\nMr Brant.\nThanks for review","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a44589b84d5afff5f807dc879cb73aadcc15e548","revisions":{"b4e80babf792384b97d10a970a70bd96d3769417":{"kind":"REWORK","_number":1,"created":"2015-03-04 10:30:49.000000000","uploader":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"ref":"refs/changes/64/161164/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/64/161164/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/161164/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/161164/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/161164/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/161164/1"}}},"commit":{"parents":[{"commit":"94e01e20d1f27a44b0543734f3125077cd06fc88","subject":"Merge \"Import functional CLI tests from tempest\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/94e01e20d1f27a44b0543734f3125077cd06fc88"}]}],"author":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2015-03-04 10:07:04.000000000","tz":540},"committer":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2015-03-04 10:27:51.000000000","tz":540},"subject":"Enable to specify auth plugin as full class name","message":"Enable to specify auth plugin as full class name\n\nThis patch will enable us to specify auth_plugin as full class name (ex,\nkeystoneclient.auth.identity.generic.Password) as well as plugin alias (\nex, password ).\nThe implement like this is used by Neutron plugin loading system.\n\nChange-Id: Ieec767da6cfdd444843c9d9d66a422bd7b75d09e\nCloses-Bug: #1425345\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b4e80babf792384b97d10a970a70bd96d3769417"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b4e80babf792384b97d10a970a70bd96d3769417"}]},"branch":"refs/heads/master"},"a44589b84d5afff5f807dc879cb73aadcc15e548":{"kind":"REWORK","_number":2,"created":"2015-03-13 15:19:28.000000000","uploader":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"ref":"refs/changes/64/161164/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/64/161164/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/161164/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/161164/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/161164/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/161164/2"}}},"commit":{"parents":[{"commit":"385c19b8b6bfb717fc4b39e211c9ef05b80d2df0","subject":"Merge \"Fix time issue in AccessInfo test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/385c19b8b6bfb717fc4b39e211c9ef05b80d2df0"}]}],"author":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2015-03-13 15:12:42.000000000","tz":540},"committer":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2015-03-13 15:19:25.000000000","tz":540},"subject":"Enable to specify auth plugin as full class name","message":"Enable to specify auth plugin as full class name\n\nThis patch will enable us to specify auth_plugin as full class name (e.g.\nkeystoneclient.auth.identity.generic.Password) as well as plugin alias (\ne.g. password ).\nThe implementation like this is used by Neutron plugin loading system.\n\nChange-Id: Ieec767da6cfdd444843c9d9d66a422bd7b75d09e\nCloses-Bug: #1425345\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a44589b84d5afff5f807dc879cb73aadcc15e548"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a44589b84d5afff5f807dc879cb73aadcc15e548"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}